From: Iain Sandoe <idsandoe@googlemail.com>
To: Pascal Obry <obry@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Subject: Re: [Ada] Fix serial port baud rate setting on GNU/Linux
Date: Wed, 16 Dec 2020 10:15:24 +0000 [thread overview]
Message-ID: <C3E97745-DB3A-4AE1-8BFE-7AC76496D86D@googlemail.com> (raw)
In-Reply-To: <yddsg86ytpg.fsf@CeBiTec.Uni-Bielefeld.DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>
>> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>>
>>> Hi Pierre-Marie,
>>>
>>>> This fixes an issue when setting the baud rate. The baud rate is set
>>>> using the cfsetospeed and cfsetispeed system calls. The code is using
>>>> speed_t for clarity. The non-blocking status is only reset when Block is
>>>> True. And serial blocking mode is now properly set according to termios
>>>> manual.
>>>>
>>>> Add documentation about a way to debug and test a serial port on
>>>> GNU/Linux without the need for a physical serial port.
>>>>
>>>> Tested on x86_64-pc-linux-gnu, committed on trunk
>>>
>>> this patch broke Linux/x86_64 bootstrap (Fedora 29):
>>
>> also Darwin (which seems to be using g-sercom-linux.adb)
>
> ah. In hindsight, I'd wondered why my Solaris builds weren't affected.
> termios is common to all POSIX targets after all.
Actually, the linux file seems to contain quite a bit more advanced than
SUSv3,
it might be worth having a Posix_susv3 version (there are quite a few targets
qualified to SUSv3, but it seems not many [1?] qualified to UNIX7).
Iain
prev parent reply other threads:[~2020-12-16 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 11:42 Pierre-Marie de Rodat
2020-12-15 22:58 ` Rainer Orth
2020-12-16 7:56 ` Iain Sandoe
2020-12-16 8:31 ` Martin Liška
2020-12-16 12:18 ` Pierre-Marie de Rodat
2020-12-16 13:18 ` Pierre-Marie de Rodat
2020-12-16 13:21 ` Rainer Orth
2020-12-16 9:40 ` Rainer Orth
2020-12-16 10:15 ` Iain Sandoe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3E97745-DB3A-4AE1-8BFE-7AC76496D86D@googlemail.com \
--to=idsandoe@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=obry@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).