From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8E6823858D1E for ; Wed, 2 Aug 2023 16:46:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E6823858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 372FY9qs009500; Wed, 2 Aug 2023 16:46:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=80a1yhtozd6ikydwIl39/KMqoYZO/xyG4r7Dm279Gxo=; b=0MgUswgOyStUfABIKfZPucc7zDTSXyqoPzykrDuVCKQXQhVX0LxM5+E4OAZVyioibuOE pq8kFM26RdeKCbKWqbauxU2jWSNdTPqXsso+QbyXi8/TAZHYe6i+tZ8k7mMKRe7bpPx4 awMInC2UI8w/5M8m9ewosAzPRVmhfcYC7ZeL5/lzH3nMCtH9EvKP3LRHpK2qV7Gtvd51 d76ireROdxbJbgnpz39eTl5BVNAeoGojKaN7CT1S9sSlmyJbRXc0DptNlP8wF8NIV4rO 3uiDgkcdGt6Gv5Kvh9iJg+tvzpmrBKrqoSY5w32FGn52WHWGFRkjSF9DBY90Z507MxYb 5g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s4uauyr42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Aug 2023 16:46:00 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 372FKXVw006581; Wed, 2 Aug 2023 16:45:58 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2171.outbound.protection.outlook.com [104.47.59.171]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3s4s7eptfs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Aug 2023 16:45:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URwTdhdkG2kgC170uaO04i4g06PUIxItVy/qJ/cGhptMC2Ejqnc6nOszucNJ9vNGV7XPI+u9ErSpd5YgkQiNyQbHYMNE/10vpPM1kZ7LVQo/FwbVYndC2a97xIkFczPBkBVDE7JIJhQDFLxd6OTUdmjCFX2CsW0d94UQ5sODvmnLvQaTi0fRn4whaRNTbPEw0s+VOzhPXGE7D8wUi4ZmCS7eWswj0LXGiWM7HgxNoGIWO9hkLuky+YVBkgfyx+SgY17+m3p1d8xq6jt77DNwipDtTaqXiWwgetV+T7V3hsrqpzgIZG75Pe6JKlHgLSBc4g+nBNSSDWTCHN6USCzFbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80a1yhtozd6ikydwIl39/KMqoYZO/xyG4r7Dm279Gxo=; b=Nm/GkwueUHmWzAi/50HnegQokpzMkCZthYzYWQ4nHInViuLdF5AYI1bzffQay16oDFpWEJ+GzXxr2+YIiyZe1dFGjP0dN8LqcMrFAabZJOM44WigRgjcXR/BHI7T1w47CxIHjYH1Wae4z0kUjeDyghQF/7UYWJSOm7RjXcVALpFEuDe+TwVnwImoBWSZJEJgehk9n/+ZXYsUbH25UH5qKlQPXIEbI+UGFvavgsJe0okcV5hpPD2TCXdTnjQTZK1sLmaun+sXQqpk1YAnnul1N9z8difl2HOxNemdz4bO0B0rgjKQGcKR1UR1RpNOVy5nAXBYeo2Zcf0kevJgkW/7ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=80a1yhtozd6ikydwIl39/KMqoYZO/xyG4r7Dm279Gxo=; b=lJlAm9FW0GN3M8VFOYl6a93hN8k67BY6RybitykZRVfEtbpOXgHxx+dlV3jyfxHpjYuC8OC5dP3szNF4jozXOxV2rGpzcvoNCwUa/gTPcBe7S2Sxr26xd2Bth8biUz4CNcpcD6XluEIMrSzRKtbHdsJeE3ZxdPtIC5TBB7s6w/4= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by DS7PR10MB5182.namprd10.prod.outlook.com (2603:10b6:5:38f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 16:45:56 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::5afd:d02a:38ef:94ba]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::5afd:d02a:38ef:94ba%7]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 16:45:56 +0000 From: Qing Zhao To: Martin Uecker CC: Prathamesh Kulkarni , "gcc-patches@gcc.gnu.org" , Joseph Myers Subject: Re: [C PATCH]: Add Walloc-type to warn about insufficient size in allocations Thread-Topic: [C PATCH]: Add Walloc-type to warn about insufficient size in allocations Thread-Index: AQHZu8Wx4KRUrk7iNUCCknDM1JLu+K/UZ1oAgAC6+oCAAF3rgIAAEgOAgAG30AA= Date: Wed, 2 Aug 2023 16:45:56 +0000 Message-ID: References: <09c7e37362800bf5eacffc8b442d3a84c3f7f817.camel@tugraz.at> In-Reply-To: <09c7e37362800bf5eacffc8b442d3a84c3f7f817.camel@tugraz.at> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.3) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|DS7PR10MB5182:EE_ x-ms-office365-filtering-correlation-id: 4801bb3e-06fd-46d7-b907-08db9377f1a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5HjklmPrg8DsS6foem0hkPE4/jUHVCH8TCfh0VMu6635TQvdVjWcqXvQEL1VzUrO9CB8inZKtJLYCm74QVn29RTiH2uoRw04VBkJhYaGmz8UVxsUJHcx9uG3iNwnicYf7xvcnTqXnaBukX+nvGF9LsWp92POiS0t9Qfe274e2BxoRWZmvvYS3Z2OlGW/JyXD3nzs9pBddU47zO6VZCqUcoBXwbDG4tFhiX0R8RPn29c0vgLPUgTqadyqrKXXYcZeZMdXWUP3RTYtQIiR3nOlTviopsnZTUTQybVJq9qJvCN/XUe1cfdRz08f2iKPABZ/3LUY9but3xOIgYUqvT06NfnFCUXBL90Bk3ClFgOf7g4FA/CzOv0YZaX3hYq8BSzHHm+VNfJXuygNOJea1PR+QlgUcNMtP21DF0eDEeBb2RYgV4+rnUWvFNZrQZGi/Q3UufBaOOcO2R5npcV7gg+4Pj3hFCGN8EtRtzoY/kgw/LgROnx+wMnzV35mO9Tmro6p9XmZfotbqekqFR7ppp3TYHbQjJMHp3M2W/oGxK6QpdIAejsOr8yNFHKLOK7cuVTH3B5JR3KS7LZXdBZ5gMpj+jeoSOQwp5tb6ACKSd706UiNsVdTw8g1L6UC+QuWCMmlBTKUzA6SnxEqzpuGppdCuA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199021)(41300700001)(2906002)(6916009)(316002)(4326008)(8936002)(8676002)(38070700005)(44832011)(83380400001)(5660300002)(66556008)(2616005)(66446008)(66476007)(64756008)(91956017)(66946007)(76116006)(86362001)(38100700002)(478600001)(33656002)(186003)(53546011)(6506007)(122000001)(6486002)(6512007)(71200400001)(36756003)(54906003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TGHRHYFwF8/pKX/znwEfUtTnM3mbH0LZL1juF2FGUfMzUx/5OAtku2khmVzs?= =?us-ascii?Q?tSYskaGZV5yZANmUw68BCcp6g7w+y5XOUPLZ0CbsJhawuWTw0scyu13lCZPG?= =?us-ascii?Q?8PruRbZGqJG2rVcxFkDY3KVmV7RfGBlk3QHwb0yBYLLrjsHyWe+knu7F7Dwi?= =?us-ascii?Q?JaMdpobnFP4A60NcHb8MmfI/f4FQCpLMY2hJun1+qVcRBwDkLSxJb3jP43Yu?= =?us-ascii?Q?b+XpYKqbuKKyegR/iM7cddeSirC9+vh/1GEgnNuueRCv8JYm6BzP9r9bsEIJ?= =?us-ascii?Q?phn7aympkgMlCmXc26Q3iv/vlwhVRUe0H8j4CFQTr82pp9mqX8LISHpZ2BVm?= =?us-ascii?Q?fGwMcuoKZqkkMrGP9xZIWxreKz2hu0iy2vsxsvlzV9mwAxQBmZZGjOxFlSX8?= =?us-ascii?Q?GWbrw2+LeS7lUGsX1v2dOq+Oep6sfbhv4zf2u4XSaGJdSt9xBbuxPPWKx0P5?= =?us-ascii?Q?KLW32PGMxirqw6YjxNFiAw4i88SvF0y/f4XGaCTfzliOGZmVy4knLdM53TUz?= =?us-ascii?Q?UWnvbSqANjyoKIZvgsLUJzeussC72sB/8CKE98dsTZ4r6KvMV/FCbffu/8Hs?= =?us-ascii?Q?kavGUVBUjltjAfkqCF9T0lfJUM7V+zTfzWZQZVXtiIvZF5zhvKp5MPMmZw0Y?= =?us-ascii?Q?G2Xu20Qw0L+XIp1xAfVUAGlNzu7QmttgWRB2v8yvLYpQ7GtIdUwDB5Zxlec0?= =?us-ascii?Q?QMz3ScO7IrFzZnjnpLshGmZkjp0RMKk8rwrD7IzG0uU+c3rVZMyaezBJoFC+?= =?us-ascii?Q?ka+bu+DVCOKEOMihWzHKYKIWafhbeBgppqP/8M32L+iuT8SNsBWSgr3rUN9h?= =?us-ascii?Q?t0Z1uC7oTBUOOMjRz1wG5utFNDGPJ5EWwve3iA7dvG479SFWBrRTqz5Hg4H0?= =?us-ascii?Q?t3dSgWJ8PwEX0nS06f/YfGhglivl3ipuxX999yIIaBz5j3beV4QvCD1xFaHf?= =?us-ascii?Q?lOKBRzTlyeyuSj9y4rHEsGlyJG5OFHXUT1jCedpZPJ61p6MJtlyAhkNX/ByZ?= =?us-ascii?Q?bsSqZtKdS0KQhm3ii90jpDhIP112roX05fmp8Asncc4ogG4oozNQL7d4vOTB?= =?us-ascii?Q?YQ6sOoFrpuObCSdi6pMJYJBZhxjaVP03PIu7T6JdJ9cqkunYQ2/rJtkASGSE?= =?us-ascii?Q?1XHeMrRvSB1UWaK/c8G08c9AY8Dvnp7rvyjuW8hHvs0RzVd01QpKSXFfzJQi?= =?us-ascii?Q?XXxDcWthpLcqPcTSWPgmMY0ks0G3rXH9rRIeUYvb2hlbwQS8MRYjpVwqY4/t?= =?us-ascii?Q?GygWqP232kuwA4kcSK/IYRI3K7PT+0hFYxqigam3yen4k2nBX2N2RSXPbohe?= =?us-ascii?Q?H3qgeWD32/S5QW3e6r9I41ZE1WTK9Y0NatDhL1NDDAk2c3ltb1jKlbm/9y+u?= =?us-ascii?Q?CODZcMsdRWFv7bRn+eWD2l/k3tVLPQwq9u8m7v+MK/HJJCoy6yQFzW1pD0WY?= =?us-ascii?Q?zOiTI6yYWavGnIO1gzgb75/4F+pU0LnT7Fgxtc7k1TgVOF1DKtpXQ2mNlGA2?= =?us-ascii?Q?ZuPv4BMpJVU1Ee7nurdJ3n8npX3i7QcnIHSBH3Hd75i+L7v41zhncSSnAO/O?= =?us-ascii?Q?b6LVKqDvGTvlqAsmAE7J7e76cBEwGNHjT78Koj1UwYZu3AW7RAOyjxrSHypi?= =?us-ascii?Q?RdXtv+MYIFK82Z9ObSJXUZg=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <2E18364FB86A6F41925B6D3598985A68@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WxaZwTjqZ0zvPA3gyJhN5k03cKYFfgPZp2U8/j4/Xajbq+GAM93i/Ly9d/csuwswIVogF4jWyvcrU8Cht+y4cgWIEy/iZkM8LBF0I1vciYaZ2Z5FYj5XdYVAIYyEB+RCdDB6K6cOVVCJ5f9SqD9BY5YDAtxY77f32hP8pCrcLiEG+25ZRCkTen26DCWIlfB2+qkmzO6jZTzdS4qbjZeh7paxn/4hWsWJm3WNUqhFP8Gl6WDXXUS9N7rBG5VABcludcNJWmR6TBX4VK8ZLeJxG+ur3LyiunBspUN+vo5XimnVaZq+qqlHIkzw+u3jsY+/RJVQVR3HOIKKAxYqB4x03+eAIKZSD/mTEpd01k7fanGEZLcZEXarIDvVqVIdDbfzYxG5LysW9G49Irq376nQJxdYL1UimRE38CawbI9p8lvZ7RYQDVhl3pA0si6gFuKAwp0Zm6DXDWSs6ZHsJ0xKxz8ESjbRRQggFBkFKb8dMZW5lJeiCcuHZfRNBEn1sw3G8/IqVSLJXH7+rymH5UhzyHxTq9DE8SzmLyr6sRsRNCGg2QEB2sH2j5JfdLH1Te0hP1pdqs3OruBAn7MidzAt21nf2n9jSyyaSGW0DyNbV8S1QFUfJbEgcrOasHR/opOGo1i8uM2mSmLGld3T4fkGieORN3HvXX1dzKZXxxNxVgB637fKNTLQ08f/KLo0jtUr7hUuDa9Yhonqkjaz5n0phAbHlGSfjCffHR7Nq1/W1l1vYGvkRGFp5ewnePblVm/uts2qe2NIDHDChfi+Xkb/jV+89FsFV2mfRbl2YNToLVpnAAv3GflVBUKqx0fZT4AqkagGiKjawYowb7LRoIhOMVEgNlJSZMA96eOI8CRKa4I= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4801bb3e-06fd-46d7-b907-08db9377f1a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 16:45:56.7197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7bJbjmgHe74KanQP+7FrIcOQh1wlDFB+514x4AbRXAL2PzFiBBN4kKMjFiNoGFrDYVFxNmVtGvRFjlpsR5YZpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5182 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-02_13,2023-08-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308020148 X-Proofpoint-ORIG-GUID: IBxL1Oj3mUz356Yiav8eNMg6ogwPpJ5n X-Proofpoint-GUID: IBxL1Oj3mUz356Yiav8eNMg6ogwPpJ5n X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Aug 1, 2023, at 10:31 AM, Martin Uecker wrote: >=20 > Am Dienstag, dem 01.08.2023 um 13:27 +0000 schrieb Qing Zhao: >>=20 >>> On Aug 1, 2023, at 3:51 AM, Martin Uecker via Gcc-patches wrote: >>>=20 >=20 > .... >>>> Hi Martin, >>>> Just wondering if it'd be a good idea perhaps to warn if alloc size is >>>> not a multiple of TYPE_SIZE_UNIT instead of just less-than ? >>>> So it can catch cases like: >>>> int *p =3D malloc (sizeof (int) + 2); // probably intended malloc >>>> (sizeof (int) * 2) >>>>=20 >>>> FWIW, this is caught using -fanalyzer: >>>> f.c: In function 'f': >>>> f.c:3:12: warning: allocated buffer size is not a multiple of the >>>> pointee's size [CWE-131] [-Wanalyzer-allocation-size] >>>> 3 | int *p =3D __builtin_malloc (sizeof(int) + 2); >>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>=20 >>>> Thanks, >>>> Prathamesh >>>=20 >>> Yes, this is probably a good idea. It might need special >>> logic for flexible array members then... >>=20 >> Why special logic for FAM on such warning? (Not a multiple of TYPE_SIZE_= UNIT for the element). >>=20 >=20 > For >=20 > struct { int n; char buf[]; } *p =3D malloc(sizeof *p + n); > p->n =3D n; >=20 > the size would not be a multiple. But n is still a multiple of sizeof (char), right? Do I miss anything here? Qing >=20 > Martin >=20 >=20 >=20 >=20