From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 22019385559C for ; Mon, 21 Aug 2023 19:50:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22019385559C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fef6cee938so645045e9.0 for ; Mon, 21 Aug 2023 12:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692647449; x=1693252249; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nzcWATXGNRcpq5wwwlOskaPgEBUoeb1fvET3tyyYB9g=; b=lWRMyg9dwfzuKo2gIpHWL1jpd3oq1BTa9gm1AqPQpFvoE/R9TJiXbBtaS+CP5MXu7W DITFhsoJPTys9Xcq5i4buXtP56NEYSoNtA2yNd/Ve+ciXCcta3ytE9wCCZqdnrHlIpus D99vQdFWLrlSrrafh71E6EGecuRVXwtguSZ1Lf1ybKUklwlK/awWzTJV5Ayug7QcPq5I jl8tJES2JJdJX01P/IE8sfxGFM+ictGx6u4v20yzUY0SepQsvRLarQOTGWmmr30WydyT x95JPCGOe04DP06utqteD2K9In7TKCAZgHzH0a3BlVRCyA1ubc4UTD6KD+vzj2C/AO6e C0fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692647449; x=1693252249; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nzcWATXGNRcpq5wwwlOskaPgEBUoeb1fvET3tyyYB9g=; b=YLuWZlS/ZZAYYzQ2tsPfFrepL3F/85YctyuAyr4z8v9ffHZJ1o5kYUcejF+tD2TY7i TTPmmnnSwE0za6fVFivIHf0lHdc0OTQYyKUa9aK0H/UuxrSkys0FUOu5sbCjHNH184UT fGtGMk+XrjtWsiz1BC3so0iCaVOJYA4/E5kno3vQFl5aFaPoemQKS9+80/gDim/1LScS y5r8VfXl0GklmGsJbjxaSbme7gy0Aa242rGaiz7i/6VfWxH/SEVKVs1DFJnCDXK5cCeU trZc5zHqivrTyNGFqFrtlOxblWIhVo1bg/I7FqGMDc18XOXV9fh+XqRS95RlVsBvI9tm eTbg== X-Gm-Message-State: AOJu0YzE0vYKzkvq+J7X3q5Qu68qsYIrXPnC+UDvwqsZjGSvZ2V3mEcN 8WK/IMM+LsZ1KCkFcPJtCYk= X-Google-Smtp-Source: AGHT+IGcLGohEswsDO5GJBbhWTK+1q9U/RuoOKOJ4mHdTEDA47/yd//yAngdss12Fuis4X4RHLWRYg== X-Received: by 2002:a5d:5242:0:b0:317:5f08:329f with SMTP id k2-20020a5d5242000000b003175f08329fmr6096487wrc.1.1692647448477; Mon, 21 Aug 2023 12:50:48 -0700 (PDT) Received: from smtpclient.apple ([2a01:e34:ec28:8cb0:dd00:7ef9:421d:f19d]) by smtp.gmail.com with ESMTPSA id x8-20020a5d4448000000b0031432f1528csm13457164wrr.45.2023.08.21.12.50.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2023 12:50:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH] libgomp, testsuite: Do not call nonstandard functions on darwin From: FX Coudert In-Reply-To: Date: Mon, 21 Aug 2023 21:50:37 +0200 Cc: Tobias Burnus , GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <1B1BFD2E-20FB-4A33-A96D-78872595C416@gmail.com> To: Jakub Jelinek X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I don't like the #if !defined(__APPLE__) conditionals everywhere in = the > test, I think much cleaner would be to add an effective target to test > for those functions I understand, I wanted to not just report the issue but propose an = option. It seems a bit heavy to design an effective target just for one = test, though, no? Another possibility would be to replace #if !defined(__APPLE__) by #if = defined(__linux__), or glibc? FX