From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp002.apm-internet.net (smtp002.apm-internet.net [85.119.248.221]) by sourceware.org (Postfix) with ESMTPS id 3E0AE3858C2D for ; Sun, 8 Oct 2023 22:14:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E0AE3858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sandoe.co.uk Received: (qmail 22421 invoked from network); 8 Oct 2023 22:14:41 -0000 X-APM-Out-ID: 16968032812241 X-APM-Authkey: 257869/1(257869/1) 13 Received: from unknown (HELO smtpclient.apple) (81.138.1.83) by smtp002.apm-internet.net with SMTP; 8 Oct 2023 22:14:41 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] From: Iain Sandoe In-Reply-To: <129c7396-2aa4-4551-8e4c-291519f9b6ae@app.fastmail.com> Date: Sun, 8 Oct 2023 23:14:41 +0100 Cc: FX Coudert , GCC Patches , Joseph Myers , "bonzini@gnu.org" , neroden@gcc.gnu.org, aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de Content-Transfer-Encoding: quoted-printable Message-Id: References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> <129c7396-2aa4-4551-8e4c-291519f9b6ae@app.fastmail.com> To: Nathanael Nerode , Jeff Law X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,KAM_COUK,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: + Jeff > On 8 Oct 2023, at 14:07, Nathanael Nerode = wrote: >=20 > I hope a global maintainer can step up. I've been on hiatus from GCC = work for some years, and this was never my part of the build system = anyway -- and I don't use Darwin -- so I'm not qualified to review it. = It looks fine but it should be reviewed by someone who knows what = they're doing. Thanks Nathanael for taking a look,=20 @Jeff as we discussed at the Cauldron, I suspected it might be difficult = to get this review, so would really appreciate if could cast an eye over = it at some point, thanks Iain >=20 > On Wed, Sep 20, 2023, at 9:52 AM, FX Coudert wrote: >> ping**2 for a build maintainer or global maintainer to review, please >> It restores testing on darwin >=3D 21, which is not currently working >>=20 >> If no maintainer is available to review build system, could I get=20 >> guidance on how to proceed further? >>=20 >> Thanks, >> FX >>=20 >>=20 >>> Le 12 sept. 2023 =C3=A0 19:52, FX Coudert a = =C3=A9crit : >>>=20 >>> Hi build maintainers, >>>=20 >>> May I ping this series of patches for review? In particular, they = allow to restore testing on darwin, which is currently broken with = darwin >=3D 21, due to DYLD_LIBRARY_PATH being systematically removed = from the environment by system tools. >>>=20 >>> It has been tested for two years on darwin, and would allow to = restore regular regtesting on that target. It is a big step to help = prevent bugs being undetected on this port. >>>=20 >>> The patchset was okayed from the driver point of view, but we need a = build reviewer (or global reviewer) to okay those bits. Original = presentation of the patches: >>>=20 >>> ------ >>> I=E2=80=99d like to post an updated and rebased version of Iain = Sandoe=E2=80=99s patches for modern darwin, originally posted in = November 2021: = https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584775.html >>>=20 >>> The rationale in that message is pretty much unchanged, and the = patches have been since tested thoroughly on darwin (both Intel and ARM) = for almost two years now. We have been shipping Iain=E2=80=99s branch = (including these patches) since then in Homebrew and most other major = distros of GCC on Darwin. So I think it=E2=80=99s been very thoroughly = tested. >>>=20 >>> The main comment that arose from review in the previous incarnation = was the need to at least offer the libtool part of the patch to = upstream, in order to reduce in the long term the divergence between our = version and upstream. I have done so in = https://savannah.gnu.org/patch/index.php?10385 >>>=20 >>> (I would also note that I have offered other suggestions of small = snippets that could be upstream in libtool for darwin, but have not = received much feedback for now: https://savannah.gnu.org/patch/?10371) >>> ------ >>>=20 >>>=20 >>> Thanks, >>> FX >>>=20 >>>=20 >>>=20 >>>> Le 29 ao=C3=BBt 2023 =C3=A0 22:17, FX Coudert = a =C3=A9crit : >>>>=20 >>>>> I think a build machinery review is needed. >>>>=20 >>>> Thanks. CC=E2=80=99ing the relevant maintainers for review of the = build part. >>>> The driver part and the darwin-specific part are already okayed. >>>>=20 >>>> FX >>=20 >>=20 >> Attachments: >> * 0001-Driver-Provide-a-spec-to-insert-rpaths-for-compiler-.patch >> * 0002-Darwin-Allow-for-configuring-Darwin-to-use-embedded-.patch >> * 0003-Darwin-rpaths-Add-with-darwin-extra-rpath.patch >> * 0004-Testsuite-allow-non-installed-testing-on-darwin.patch >> * 0005-Doc-document-the-new-Darwin-options.patch