public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: Olivier Hainque <hainque@adacore.com>,
	gcc-patches@gcc.gnu.org, bkorb@gnu.org
Subject: Re: [PATCH] fixincludes: vxworks: regs.h: Guard include of vxTypesOld.h by !_ASMLANGUAGE
Date: Mon, 03 Sep 2018 12:11:00 -0000	[thread overview]
Message-ID: <C6653648-26AA-4B42-8C87-11134867A9D2@adacore.com> (raw)
In-Reply-To: <20180627142715.10534-1-rv@rasmusvillemoes.dk>

Hi Rasmus,

> On 27 Jun 2018, at 16:27, Rasmus Villemoes <rv@rasmusvillemoes.dk> wrote:
> 	* inclhack.def (AAB_vxworks_regs_vxtypes): Guard include of
> 	types/vxTypesOld.h by #ifndef _ASMLANGUAGE.
> 	* fixincl.x: Regenerate.
> ---
> fixincludes/inclhack.def | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/fixincludes/inclhack.def b/fixincludes/inclhack.def
> index c1f5a13eda4..bac0079b69f 100644
> --- a/fixincludes/inclhack.def
> +++ b/fixincludes/inclhack.def
> @@ -426,7 +426,9 @@ fix = {
>     replace     = <<- _EndOfHeader_
> 	#ifndef _REGS_H
> 	#define _REGS_H
> +	#ifndef _ASMLANGUAGE
> 	#include <types/vxTypesOld.h>
> +	#endif
> 	#include_next <arch/../regs.h>
> 	#endif
> 	_EndOfHeader_;

This will really look puzzling to a reader and would
at least deserve a comment. 

How do we not get in assembly the problems we'd get in C
when not including vxTypesOld ?

Olivier



  reply	other threads:[~2018-09-03 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 14:27 Rasmus Villemoes
2018-09-03 12:11 ` Olivier Hainque [this message]
2018-09-03 13:20   ` Rasmus Villemoes
2018-09-05  9:38     ` Olivier Hainque
2018-09-13  0:46       ` Rasmus Villemoes
2018-09-14 13:02         ` Olivier Hainque
2018-10-08 11:59           ` Rasmus Villemoes
2018-10-08 13:14 ` [PATCH v2] fixincludes: vxworks: regs.h: Fix includes in regs.h wrapper Rasmus Villemoes
2018-10-15 15:50   ` Olivier Hainque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6653648-26AA-4B42-8C87-11134867A9D2@adacore.com \
    --to=hainque@adacore.com \
    --cc=bkorb@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rv@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).