From: IainS <developer@sandoe-acoustics.co.uk>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: mrs@gcc.gnu.org
Subject: [patch, testsuite, objc] committed fix testsuite aspect of PR44488
Date: Tue, 13 Jul 2010 15:31:00 -0000 [thread overview]
Message-ID: <C75C450D-7654-4A0C-8174-60C7E75C6E86@sandoe-acoustics.co.uk> (raw)
committed, under mike's pre-appr. of objc testsuite fixes.
tested on {powerpc,i686}-apple-darwin9, x86_64-apple-darwin10, x86_64-
unknown-linux-gnu, cris-elf (sim), mipsia64(sim).
will let it settle for a few days, and then apply to 4.5
r162144
Iain
PR objc/44488
* lib/objc-torture.exp (objc-set-runtime-options): Base runtime list
on the target. Make sure that we can assemble the emitted asm when
the test type is 'compile'.
Index: gcc/testsuite/lib/objc-torture.exp
===================================================================
--- gcc/testsuite/lib/objc-torture.exp (revision 162143)
+++ gcc/testsuite/lib/objc-torture.exp (working copy)
@@ -23,17 +23,24 @@ load_lib target-supports.exp
# Make sure that the runtime list is re-evaluated for each multilib.
proc objc-set-runtime-options { dowhat args } {
global OBJC_RUNTIME_OPTIONS
- if ![info exists OBJC_RUNTIME_OPTIONS] {
- set rtlist [list "-fgnu-runtime" "-fnext-runtime" ]
- } else {
- set rtlist [list "-fgnu-runtime" "-fnext-runtime" ]
- foreach other $OBJC_RUNTIME_OPTIONS {
- # Don't do tests twice...
- if { ( $other == "-fnext-runtime" || $other == "-fgnu-
runtime" ) } {
- continue
- }
- lappend rtlist $other
+ set rtlist [list "-fgnu-runtime" ]
+ # At present (4.6), the only NeXT runtime target is Darwin.
+ # The previously used approach of testing trivial compiles is not
reliable
+ # for determining the absence of the NeXT runtime, since a non-
Darwin
+ # installation can have the objc headers present in the same
locations
+ # that Darwin uses. If NeXT is ported to another target, then it
should
+ # be listed here.
+ if [istarget "*-*-darwin*" ] {
+ lappend rtlist "-fnext-runtime"
+ }
+ if [info exists OBJC_RUNTIME_OPTIONS] {
+ foreach other $OBJC_RUNTIME_OPTIONS {
+ # Don't do tests twice...
+ if { ( $other == "-fnext-runtime" || $other == "-fgnu-runtime" ) } {
+ continue
}
+ lappend rtlist $other
+ }
}
set OBJC_RUNTIME_OPTIONS ""
@@ -49,8 +56,10 @@ proc objc-set-runtime-options { dowhat args } {
if [info exists dowhat] {
switch $dowhat {
"compile" {
- set compile_type "assembly"
- set output_file "trivial.s"
+ # We should check that the generated asm is sensible,
so do
+ # the equivalent of -c.
+ set compile_type "object"
+ set output_file "trivial.o"
set comp_output [objc_target_compile \
"$srcdir/$subdir/trivial.m" "$output_file" "$compile_type"
$options]
reply other threads:[~2010-07-13 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C75C450D-7654-4A0C-8174-60C7E75C6E86@sandoe-acoustics.co.uk \
--to=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=mrs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).