From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 1BCFA384B82B for ; Thu, 27 Oct 2022 18:15:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BCFA384B82B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62c.google.com with SMTP id t25so7010738ejb.8 for ; Thu, 27 Oct 2022 11:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=XJCONCwrRf9uwMVqEJ6wxJ4mwcXPCYO8m7riqpW/UYo=; b=FSySp5m1xC9YXn+XBmqEsYHVTrGSE/1GDschBjbV2qTCVBjNuMv7MtEAMswK+Mdd+G qNaYhXa+Wo5m9odn7UwxGQwnV9nbb7MfPmZF12uekqdIvATnnTRaM9YSyW0tX+++OiXp l/WYvlaFZUIie9az3gpLiWPbPD3F7TGypFmzGScwCDDxuBcN7/LHzY/h8v9E6GlGuzn/ Sr1suYIxsAHx6qYq5Hh8ei/ww2Rm2W4DZ7SzSyZpq3yNnA/CgqxRoQwQxqEqX0ThgdH7 2AHG5zKoQw2Kf3/f0MyTB27EEk6GGx0aVNUWWVwTVry/31oZdIngyf4WhDP3jgNXhF21 WTDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJCONCwrRf9uwMVqEJ6wxJ4mwcXPCYO8m7riqpW/UYo=; b=t5nZu6ZCaCZ0nAmccK+tEXq9JBu9vU5vX/J7UMZXvF6YhQkgnApzVdhC8dAlaLt9aV si+0adpHpDhQg3475tz89gqZSBtVvIbqQt1hSEvhz08qs7XSc1B8TbgqfQj8Awq26GFa 5MfDHUKcHF4cUZ3j9cH2yRffozPYSKbN0OJynqpTG0sMBqhYw4Dqv6RRRRiOuSnJnL5l KrDM8oWo/+WNoVtLLchirHO+fRLxCUxQf39f14UKlnzwxJnSRyc5p5XLV80CAUvaw4ix NSsWE9Zxfg9mwDGHD/YBdNZsoml4zu8NnzmGYy77pTOh2wNiifL7xrmRjtfO5HNRQOS3 0D8w== X-Gm-Message-State: ACrzQf0HZB0mW0JiVrXzKc8OOfD5TxBCoobUWZ0CuR/Foria9mWNSk0Q AHQlg7aT4b5G7UaxLatNhCXc71KwuRg= X-Google-Smtp-Source: AMsMyM5rmIe5/zfSd9YfNv7AEr4Tlv1oeJTAoxmhL/pw5Pv+rlRrrgJ8sNqtjDCdyQ0oSsMWIcChPg== X-Received: by 2002:a17:906:5dce:b0:78d:e71a:6e0 with SMTP id p14-20020a1709065dce00b0078de71a06e0mr42696369ejv.360.1666894541302; Thu, 27 Oct 2022 11:15:41 -0700 (PDT) Received: from smtpclient.apple (dynamic-095-117-080-125.95.117.pool.telefonica.de. [95.117.80.125]) by smtp.gmail.com with ESMTPSA id k18-20020a17090632d200b0078116c361d9sm1149545ejk.10.2022.10.27.11.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 11:15:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] lto-dump: modernize a bit Date: Thu, 27 Oct 2022 20:15:29 +0200 Message-Id: References: Cc: gcc-patches@gcc.gnu.org In-Reply-To: To: =?utf-8?Q?Martin_Li=C5=A1ka?= X-Mailer: iPhone Mail (20B82) X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 27.10.2022 um 10:43 schrieb Martin Li=C5=A1ka : >=20 > =EF=BB=BFHi. >=20 > Ready to be installed? Ok Richard=20 > Thanks, > Martin >=20 > gcc/lto/ChangeLog: >=20 > * lto-dump.cc (dump_list): Remove trailing return. > (dump_symbol): Likewise. > (dump_body): Filter name based on mangled name. > (dump_tool_help): Use GIMPLE wording. > (lto_main): Update wording. > --- > gcc/lto/lto-dump.cc | 19 +++++++------------ > 1 file changed, 7 insertions(+), 12 deletions(-) >=20 > diff --git a/gcc/lto/lto-dump.cc b/gcc/lto/lto-dump.cc > index cb9782722a9..5c4dbf5d297 100644 > --- a/gcc/lto/lto-dump.cc > +++ b/gcc/lto/lto-dump.cc > @@ -227,7 +227,6 @@ void dump_list (void) > { > dump_list_functions (); > dump_list_variables (); > - return; > } > /* Dump specific variables and functions used in IL. */ > @@ -243,7 +242,6 @@ void dump_symbol () > printf ("\n"); > } > } > - return; > } > /* Dump specific gimple body of specified function. */ > @@ -259,19 +257,17 @@ void dump_body () > return; > } > cgraph_node *cnode; > - FOR_EACH_FUNCTION (cnode) > - if (cnode->definition > - && !cnode->alias > - && !strcmp (cnode->name (), flag_dump_body)) > + FOR_EACH_DEFINED_FUNCTION (cnode) > + if (!cnode->alias > + && !strcmp (cnode->asm_name (), flag_dump_body)) > { > - printf ("Gimple Body of Function: %s\n", cnode->name ()); > + printf ("GIMPLE body of function: %s\n\n", cnode->asm_name ()); > cnode->get_untransformed_body (); > debug_function (cnode->decl, flags); > flag =3D 1; > } > if (!flag) > error_at (input_location, "Function not found."); > - return; > } > /* List of command line options for dumping. */ > @@ -292,13 +288,12 @@ void dump_tool_help () > " -callgraph Dump the callgraph in graphviz format.\n"= > " -type-stats Dump statistics of tree types.\n" > " -tree-stats Dump statistics of trees.\n" > - " -gimple-stats Dump statistics of gimple statements.\n"= > - " -dump-body=3D Dump the specific gimple body.\n" > + " -gimple-stats Dump statistics of GIMPLE statements.\n"= > + " -dump-body=3D Dump the specific GIMPLE body.\n" > " -dump-level=3D Deciding the optimization level of body= .\n" > " -help Display the dump tool help.\n"; > fputs (msg, stdout); > - return; > } > unsigned int > @@ -365,7 +360,7 @@ lto_main (void) > "%<--enable-gather-detailed-mem-stats%>."); > else > { > - printf ("Tree Statistics\n"); > + printf ("Tree statistics\n"); > dump_tree_statistics (); > } > } > --=20 > 2.38.0 >=20