* [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
@ 2011-10-14 10:19 Iain Sandoe
2011-10-22 14:24 ` PING * : " Iain Sandoe
0 siblings, 1 reply; 6+ messages in thread
From: Iain Sandoe @ 2011-10-14 10:19 UTC (permalink / raw)
To: GCC Patches; +Cc: Arnaud Charlet, Mike Stump
As per the PR audit trail, there is no reason to retain this in the
building of GCC.
As for its use as a general option in tool-builds;
With current darwin toolsets it has the potential to cause issues when
using convenience libs containing common.
OK for trunk?
Iain
gcc/ada:
PR target/49992
* mlib-tgt-specific-darwin.adb: Remove ranlib special case.
* gcc-interface/Makefile.in (darwin): Likewise.
Index: gcc/ada/mlib-tgt-specific-darwin.adb
===================================================================
--- gcc/ada/mlib-tgt-specific-darwin.adb (revision 179962)
+++ gcc/ada/mlib-tgt-specific-darwin.adb (working copy)
@@ -68,7 +68,7 @@ package body MLib.Tgt.Specific is
function Archive_Indexer_Options return String_List_Access is
begin
- return new String_List'(1 => new String'("-c"));
+ return new String_List'(1 => new String'(""));
end Archive_Indexer_Options;
---------------------------
Index: gcc/ada/gcc-interface/Makefile.in
===================================================================
--- gcc/ada/gcc-interface/Makefile.in (revision 179962)
+++ gcc/ada/gcc-interface/Makefile.in (working copy)
@@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
EH_MECHANISM=-gcc
GNATLIB_SHARED = gnatlib-shared-darwin
- RANLIB = ranlib -c
GMEM_LIB = gmemlib
LIBRARY_VERSION := $(LIB_VERSION)
soext = .dylib
^ permalink raw reply [flat|nested] 6+ messages in thread
* PING * : [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
2011-10-14 10:19 [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port Iain Sandoe
@ 2011-10-22 14:24 ` Iain Sandoe
2011-10-28 15:54 ` PING 2 " Iain Sandoe
2011-11-17 12:37 ` PING * " Arnaud Charlet
0 siblings, 2 replies; 6+ messages in thread
From: Iain Sandoe @ 2011-10-22 14:24 UTC (permalink / raw)
To: GCC Patches; +Cc: Arnaud Charlet, Mike Stump
On 14 Oct 2011, at 10:37, Iain Sandoe wrote:
> As per the PR audit trail, there is no reason to retain this in the
> building of GCC.
>
> As for its use as a general option in tool-builds;
> With current darwin toolsets it has the potential to cause issues
> when using convenience libs containing common.
> OK for trunk?
> Iain
>
> gcc/ada:
>
> PR target/49992
> * mlib-tgt-specific-darwin.adb: Remove ranlib special case.
> * gcc-interface/Makefile.in (darwin): Likewise.
>
>
> Index: gcc/ada/mlib-tgt-specific-darwin.adb
> ===================================================================
> --- gcc/ada/mlib-tgt-specific-darwin.adb (revision 179962)
> +++ gcc/ada/mlib-tgt-specific-darwin.adb (working copy)
> @@ -68,7 +68,7 @@ package body MLib.Tgt.Specific is
>
> function Archive_Indexer_Options return String_List_Access is
> begin
> - return new String_List'(1 => new String'("-c"));
> + return new String_List'(1 => new String'(""));
> end Archive_Indexer_Options;
>
> ---------------------------
> Index: gcc/ada/gcc-interface/Makefile.in
> ===================================================================
> --- gcc/ada/gcc-interface/Makefile.in (revision 179962)
> +++ gcc/ada/gcc-interface/Makefile.in (working copy)
> @@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
>
> EH_MECHANISM=-gcc
> GNATLIB_SHARED = gnatlib-shared-darwin
> - RANLIB = ranlib -c
> GMEM_LIB = gmemlib
> LIBRARY_VERSION := $(LIB_VERSION)
> soext = .dylib
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* PING 2 : [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
2011-10-22 14:24 ` PING * : " Iain Sandoe
@ 2011-10-28 15:54 ` Iain Sandoe
2011-10-28 19:37 ` Mike Stump
2011-11-01 21:02 ` Arnaud Charlet
2011-11-17 12:37 ` PING * " Arnaud Charlet
1 sibling, 2 replies; 6+ messages in thread
From: Iain Sandoe @ 2011-10-28 15:54 UTC (permalink / raw)
To: Arnaud Charlet; +Cc: GCC Patches, Mike Stump
This is unreviewed for 2 weeks.
I am sure that this issue will be affecting Ada on Darwin10/11 with
the latest toolchains.
It might be subtle without LTO - OTOH when LTO is engaged it breaks
things completely.
On 22 Oct 2011, at 08:37, Iain Sandoe wrote:
>
> On 14 Oct 2011, at 10:37, Iain Sandoe wrote:
>
>> As per the PR audit trail, there is no reason to retain this in the
>> building of GCC.
>>
>> As for its use as a general option in tool-builds;
>> With current darwin toolsets it has the potential to cause issues
>> when using convenience libs containing common.
>> OK for trunk?
>> Iain
>>
>> gcc/ada:
>>
>> PR target/49992
>> * mlib-tgt-specific-darwin.adb: Remove ranlib special case.
>> * gcc-interface/Makefile.in (darwin): Likewise.
>>
>>
>> Index: gcc/ada/mlib-tgt-specific-darwin.adb
>> ===================================================================
>> --- gcc/ada/mlib-tgt-specific-darwin.adb (revision 179962)
>> +++ gcc/ada/mlib-tgt-specific-darwin.adb (working copy)
>> @@ -68,7 +68,7 @@ package body MLib.Tgt.Specific is
>>
>> function Archive_Indexer_Options return String_List_Access is
>> begin
>> - return new String_List'(1 => new String'("-c"));
>> + return new String_List'(1 => new String'(""));
>> end Archive_Indexer_Options;
>>
>> ---------------------------
>> Index: gcc/ada/gcc-interface/Makefile.in
>> ===================================================================
>> --- gcc/ada/gcc-interface/Makefile.in (revision 179962)
>> +++ gcc/ada/gcc-interface/Makefile.in (working copy)
>> @@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
>>
>> EH_MECHANISM=-gcc
>> GNATLIB_SHARED = gnatlib-shared-darwin
>> - RANLIB = ranlib -c
>> GMEM_LIB = gmemlib
>> LIBRARY_VERSION := $(LIB_VERSION)
>> soext = .dylib
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PING 2 : [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
2011-10-28 15:54 ` PING 2 " Iain Sandoe
@ 2011-10-28 19:37 ` Mike Stump
2011-11-01 21:02 ` Arnaud Charlet
1 sibling, 0 replies; 6+ messages in thread
From: Mike Stump @ 2011-10-28 19:37 UTC (permalink / raw)
To: Iain Sandoe; +Cc: Arnaud Charlet, GCC Patches
On Oct 28, 2011, at 8:41 AM, Iain Sandoe wrote:
> This is unreviewed for 2 weeks.
Odd, usually the Ada people are fairly responsive. If they want me to weigh in, I approve of the concept behind the work.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PING 2 : [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
2011-10-28 15:54 ` PING 2 " Iain Sandoe
2011-10-28 19:37 ` Mike Stump
@ 2011-11-01 21:02 ` Arnaud Charlet
1 sibling, 0 replies; 6+ messages in thread
From: Arnaud Charlet @ 2011-11-01 21:02 UTC (permalink / raw)
To: Iain Sandoe; +Cc: GCC Patches, Mike Stump
Le 28/10/2011 17:41, Iain Sandoe a écrit :
> This is unreviewed for 2 weeks.
>
> I am sure that this issue will be affecting Ada on Darwin10/11 with
> the latest toolchains.
It's actually under discussion and is pretty subtle, so delicate. Thanks
for your patience.
Arno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PING * : [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
2011-10-22 14:24 ` PING * : " Iain Sandoe
2011-10-28 15:54 ` PING 2 " Iain Sandoe
@ 2011-11-17 12:37 ` Arnaud Charlet
1 sibling, 0 replies; 6+ messages in thread
From: Arnaud Charlet @ 2011-11-17 12:37 UTC (permalink / raw)
To: Iain Sandoe; +Cc: GCC Patches, Mike Stump, Tristan Gingold
The new version of the patch as suggested by Tristan is OK to commit,
thanks.
Arno
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-17 11:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-14 10:19 [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port Iain Sandoe
2011-10-22 14:24 ` PING * : " Iain Sandoe
2011-10-28 15:54 ` PING 2 " Iain Sandoe
2011-10-28 19:37 ` Mike Stump
2011-11-01 21:02 ` Arnaud Charlet
2011-11-17 12:37 ` PING * " Arnaud Charlet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).