From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85979 invoked by alias); 16 Jan 2017 23:08:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85873 invoked by uid 89); 16 Jan 2017 23:08:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=HX-Received:10.200.48.14 X-HELO: mail-qt0-f169.google.com Received: from mail-qt0-f169.google.com (HELO mail-qt0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jan 2017 23:08:17 +0000 Received: by mail-qt0-f169.google.com with SMTP id l7so127286393qtd.1 for ; Mon, 16 Jan 2017 15:08:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=badcfuthArFXCWd24NAGHG94+9wRDb7uZmkUCB4Ybco=; b=Te7bMWzkv7l+rsxbF6AofkDGRwfklvX6irUnD1tLfNNoXGkJRH8XS/9j8VpUitE2dq u6Dwauq03DicLLspptUJucI2DT5zwt5R8BTy5IzGRF5oqvwQzvIPHqRUhTZwTAGOvUO7 B359mvsidc/df1HUc+XqFtQZQNNay/hpW7zIMWawCjw0YiHcQVeqDWPSD2p70OmQ+TDm 0SwGhaLcwHHJtzdeKB81XzeADyiTwzgQuUMKzqMsEou+fw4XdmuyFIhaXpfq42VnbQgs YWU1n1FRJqvGDnoVDNYsUx2pGIBqAph3qKA62BZFLgVTnrzyZs3T7QIp4AD9c88cYvvu TW+w== X-Gm-Message-State: AIkVDXJEUalcN6HSKdCr7Ml2zemxeKO48p/R89Sba9EoqNOJvsBYaEYhaU5ETrpkKGt+xg== X-Received: by 10.200.48.14 with SMTP id f14mr27421024qte.236.1484608095751; Mon, 16 Jan 2017 15:08:15 -0800 (PST) Received: from mail-qt0-f170.google.com (mail-qt0-f170.google.com. [209.85.216.170]) by smtp.gmail.com with ESMTPSA id i5sm2768772qtb.9.2017.01.16.15.08.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jan 2017 15:08:14 -0800 (PST) Received: by mail-qt0-f170.google.com with SMTP id v23so126833470qtb.0 for ; Mon, 16 Jan 2017 15:08:14 -0800 (PST) X-Received: by 10.200.48.206 with SMTP id w14mr34796021qta.50.1484608094369; Mon, 16 Jan 2017 15:08:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.176.213 with HTTP; Mon, 16 Jan 2017 15:07:53 -0800 (PST) In-Reply-To: References: <20170112023038.13449-1-palmer@dabbelt.com> <20170112023038.13449-2-palmer@dabbelt.com> From: Andrew Waterman Date: Mon, 16 Jan 2017 23:08:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] RISC-V Port: gcc/config/riscv/riscv.c To: Joseph Myers Cc: Palmer Dabbelt , gcc-patches@gcc.gnu.org, Kito Cheng Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2017-01/txt/msg01144.txt.bz2 On Thu, Jan 12, 2017 at 1:38 PM, Joseph Myers wrote: > On Wed, 11 Jan 2017, Palmer Dabbelt wrote: > >> +#include > > This is included in system.h, so don't include it here. OK. > >> + error ("unknown cpu `%s' for -mtune", cpu_string); > > This is using very-old-style `' quotes. Diagnostics should use e.g. %qs > for quoting the output of a single % directive, or %< and %> for quoting > anything more complicated, so that Unicode quotes can be used when the > locale permits. > > Likewise elsewhere in this patch and in patch 2. Will do, throughout. > >> +#undef TARGET_LRA_P >> +#define TARGET_LRA_P hook_bool_void_true > > Using LRA is the default; you shouldn't need this definition. Ah, glad to see LRA is now the default. > > I don't see a definition of TARGET_ATOMIC_ASSIGN_EXPAND_FENV. Since you > have floating-point exceptions, I'd expect lack this to result in > c11-atomic-exec-5.c failing. Indeed, and after implementing the hook, those failures disappeared. Thanks. > > -- > Joseph S. Myers > joseph@codesourcery.com