From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24919 invoked by alias); 19 Oct 2012 18:02:16 -0000 Received: (qmail 24911 invoked by uid 22791); 19 Oct 2012 18:02:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_LV X-Spam-Check-By: sourceware.org Received: from mail-qa0-f54.google.com (HELO mail-qa0-f54.google.com) (209.85.216.54) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 18:02:10 +0000 Received: by mail-qa0-f54.google.com with SMTP id p27so295328qat.20 for ; Fri, 19 Oct 2012 11:02:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=3nWvQi8itQbgmTT3Hs9vVDT9mPnVwyxRej3IRhng6vY=; b=RgWUys5Egm0dogTKAcKZxi0pLmeIW+L/uUFHaKeCwnX9QryJreEWxXgBqdvBdIvJQM WOGajLuHWfGkpLI95yE+ikFoiC5iRtg3hEUabsFVFjzxx07O/JiXtC32xhyhGEijQ+9y gO3vD4LlgsDBd173/XEebsus4IMQpfsft46hFZl6etoCTnWvILzsdrcVPlPSg+iMfnxM UKXPbxQsJG5UvrDy2uF7uDq82SkMHzUi94jJbKEBJlB/85MGKT4LqzoiWWlNm20U6qaS PPhH3jUbun9AI7IYSWLxtAtiMwZt0ickKAAUXYAXcYvvqdFVjvniOqiIhCM8EYccQBLh C0mA== MIME-Version: 1.0 Received: by 10.229.171.7 with SMTP id f7mr235902qcz.14.1350669729797; Fri, 19 Oct 2012 11:02:09 -0700 (PDT) Received: by 10.49.108.194 with HTTP; Fri, 19 Oct 2012 11:02:09 -0700 (PDT) In-Reply-To: References: <20121016072730.GE584@tucnak.redhat.com> <20121018181636.GZ584@tucnak.redhat.com> Date: Fri, 19 Oct 2012 19:02:00 -0000 Message-ID: Subject: Re: [asan] migrate runtime from llvm From: Wei Mi To: Xinliang David Li Cc: Jakub Jelinek , Andrew Pinski , gcc-patches@gcc.gnu.org, Diego Novillo Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQnX/n2BmJw4+0q4mTont4NxuYhMvtZ6VnfxNaktsBQNb9TcGvJJ4urtTaY3vezktcxJZAQ7Z53PuGNFdHBmNGK4dwhtPWH31s5ohR7j8FbG/vQ+C4kPIertvp9JFCJmEhznMoxL6tG8A57xwRSUvgfwhecM+a76S1g9DKYZR80hixhTB+cOBvO+EgknQS2MxxBv/gKC Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg01828.txt.bz2 David, I put the m4 subdir under libasan because once I use the .m4 files (libtool.m4 lt~obsolete.m4 ltoptions.m4 ltsugar.m4 ltversion.m4) and ltmain.sh under $topsrcdir, the problem that a bad libtool was generated under $topbuilddir/x86_64-unknown-linux-gnu/libasan you met yesterday appeared. That is why I had to generate the new libtool m4 files and ltmain.sh using libtoolize. Thanks, Wei. On Fri, Oct 19, 2012 at 10:16 AM, Xinliang David Li wrote: > I tried it, and this version works for me. > > Your probably do not need to add the m4 subdir under libasan. The > required m4 files are either in .. or ../config dir. See how > libmudflap does it. > > Other than that, if there are no other comments, the change is good to > check into the branch. Remaining bugs can always be found and fixed > later. > > thanks, > > David > > > > On Thu, Oct 18, 2012 at 8:04 PM, Wei Mi wrote: >> Hi, >> >> David cought a problem in the last patch when he tries to built >> libasan. The problem was that an incomplete libtool under libasan >> build directory was generated. The cause is that the old patch used an >> old ltmain.sh to generate libtool. I fix it and attach a new patch. >> And the new patch move -lpthread and -ldl to libasan LDFLAGS. >> >> Thanks, >> Wei.