adding -Wshadow-local and -Wshadow-compatible-local ?

adding -Wshadow-local and -Wshadow-compatible-local ?

[Jim Meyering]

Hi Diego,

I noticed this patch that adds support for improved -Wshadow-related options:

  [google] Add two new -Wshadow warnings (issue4452058)
   https://gcc.gnu.org/ml/gcc-patches/2011-04/msg02317.html
   https://codereview.appspot.com/4452058/

Here are the proposed descriptions:

    -Wshadow-local which warns if a local variable shadows another local
    variable or parameter,

    -Wshadow-compatible-local which warns if a local variable shadows another
    local variable or parameter whose type is compatible with that of the
    shadowing variable.

Yet, I see no further discussion of them, other than Jason's review feedback.
Was this change deemed unsuitable for upstream gcc?

Thanks,
Jim

Re: adding -Wshadow-local and -Wshadow-compatible-local ?

[Diego Novillo]

On Fri, Dec 11, 2015 at 6:41 PM, Jim Meyering <jim@meyering.net> wrote:
>
> Hi Diego,
>
> I noticed this patch that adds support for improved -Wshadow-related options:
>
>   [google] Add two new -Wshadow warnings (issue4452058)
>    https://gcc.gnu.org/ml/gcc-patches/2011-04/msg02317.html
>    https://codereview.appspot.com/4452058/
>
> Here are the proposed descriptions:
>
>     -Wshadow-local which warns if a local variable shadows another local
>     variable or parameter,
>
>     -Wshadow-compatible-local which warns if a local variable shadows another
>     local variable or parameter whose type is compatible with that of the
>     shadowing variable.
>
> Yet, I see no further discussion of them, other than Jason's review feedback.
> Was this change deemed unsuitable for upstream gcc?

TBH, I do not remember.  That patch is available in the google
branches, IIRC.   I have no plans to pursue it for trunk.  Feel free
to propose it again.


Diego.