From: Andrew Pinski <pinskia@gmail.com>
To: Wei Mi <wmi@google.com>
Cc: gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>,
David Li <davidxl@google.com>
Subject: Re: [asan] migrate runtime from llvm
Date: Tue, 16 Oct 2012 07:47:00 -0000 [thread overview]
Message-ID: <CA+=Sn1=3GP3vBHNDZP9wAUX3ss9dPWMRur7dUeSBYiCy64x8JA@mail.gmail.com> (raw)
In-Reply-To: <CA+4CFy5S1cyAc+GzvoceBy_aR-ZGqqrtikhx89RiO3_ygwi=1w@mail.gmail.com>
On Mon, Oct 15, 2012 at 11:39 PM, Wei Mi <wmi@google.com> wrote:
>>
>> This is a good start. Can you send a patch out without including
>> libasan so at least the toplevel parts can be reviewed easier?
>> Also the changelog entry for gcc.c go under the gcc/ChangeLog rather
>> than the toplevel one.
>>
>> Thanks,
>> Andrew Pinski
>
> Sure, I attach it. Thanks for pointing out the changelog error.
+ %{fasan|coverage:-lasan -lpthread -ldl -lstdc++}\
Just curious, does asan runtime really require linking against pthread
and the standard C++ library?
Also I think the above will not work if shared libraries are disabled
as -lsupc++ is also needed when linking against the stdc++.
Also if libasan really depends on the C++ library, then most likely
you should a dependency in the toplevel makefile itself and maybe even
have the shared version of libasan link against libstdc++.
Thanks,
Andrew Pinski
>
> Thanks,
> Wei.
next prev parent reply other threads:[~2012-10-16 6:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 6:40 Wei Mi
2012-10-16 6:40 ` Andrew Pinski
2012-10-16 6:45 ` Wei Mi
2012-10-16 7:47 ` Andrew Pinski [this message]
2012-10-16 15:27 ` Jakub Jelinek
2012-10-18 17:00 ` Wei Mi
2012-10-18 18:28 ` Jakub Jelinek
2012-10-18 20:25 ` Wei Mi
2012-10-19 3:49 ` Wei Mi
2012-10-19 17:43 ` Xinliang David Li
2012-10-19 18:52 ` Diego Novillo
2012-10-19 19:02 ` Wei Mi
2012-10-19 20:28 ` Xinliang David Li
2012-10-19 20:41 ` Diego Novillo
2012-10-20 2:08 ` Wei Mi
2012-10-20 2:33 ` Wei Mi
2012-10-25 16:49 ` Xinliang David Li
2012-10-25 16:51 ` Jakub Jelinek
2012-10-25 16:53 ` Xinliang David Li
2012-10-25 16:55 ` Diego Novillo
2012-10-25 16:56 ` Xinliang David Li
2012-10-25 17:00 ` Jakub Jelinek
2012-10-25 17:13 ` Xinliang David Li
2012-10-25 17:27 ` Jakub Jelinek
2012-10-25 18:08 ` Xinliang David Li
2012-10-25 18:11 ` Diego Novillo
2012-10-18 18:22 ` Xinliang David Li
2012-10-18 18:32 ` Jakub Jelinek
2012-10-18 19:29 ` Xinliang David Li
2012-10-18 19:45 ` Xinliang David Li
[not found] ` <CAN=P9piGAbcEmLLVF+77jJvOHAh3dFpEWMgrYqAHqKynrfFNeQ@mail.gmail.com>
2012-10-19 5:14 ` Xinliang David Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1=3GP3vBHNDZP9wAUX3ss9dPWMRur7dUeSBYiCy64x8JA@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=davidxl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=wmi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).