From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id C92C2385703F for ; Fri, 11 Nov 2022 19:56:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C92C2385703F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id p12so5021157plq.4 for ; Fri, 11 Nov 2022 11:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ys2szM2LMEmx812AAUbZAVONDmo1PnFFLAHYXzLcL0s=; b=lSp8MjynVwnbPlh1Ns4aCNwxo+hTRwjeZ0BOE90KbEHtQAUxkMSYwfy0CjH6kojrN3 KYKtMYdL2yvX7I5njvhhOP9riInj013qUILVQN5enwtDpxYLuHZFmdmnPLsqebveLkYg 2f72QemAI1MsRymoKjhE/dS3xKgk30seAsGde8xEF0AofvOUaHNDXBvw2AyaMP+4g+H7 l1mzrefopCDgswdbN941GivDRbGmZK5mQPW4zBiQFVtS1RJnjV4G3S3V4ASG8r1SJk9k iebQldAX/8Ip/xp7V8GMMhph6Gh/5GPCFruhPnCXCV3kJ2YI+w/OnXzjE3so+d/JVr0w 7wyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ys2szM2LMEmx812AAUbZAVONDmo1PnFFLAHYXzLcL0s=; b=LCiV08WLLh+WMfhisVQXGaaQy/pRQkWWWwAD2IjuvExbV22iQD4qlxmoLTciYx4SHD H1u9UVZ28HZeYnVGFtz22SjdbOizXQ/ttGsXLZMkwr6uTuoOwieyTN9CmyYh27yxAyb2 n09QC+vWa6HxtEKaBt3wm7KQYoiLfcYDLKlmYdmtCSuxqF5qb8ebV3kMQCFXazxarbpe J1uElNQ9Nru0J1O4bNGH5ui1Bvtm9h9s47pjL4DyOpZ5GkX5OrcMCRZxOaB07Vj2C9QQ /71VIGT+FrF6ChTKvaDYxjgxCp6uUqlsfJ+4ucJTRh26xYL7WvWg5kxlYsvOzYC/BXvN 9S7A== X-Gm-Message-State: ANoB5pn+PWAx7pws2zBM0fN5ohmJHMEzH8SfZwjVfjuW/gZ4y/K9C34N DNW5Kd7I6WW6vK42DDJtJOBuXLVYxN2r5tZIGSE= X-Google-Smtp-Source: AA0mqf7F1F0JWLSSS7aJbOKkAxmO1qSP9hHj2UjZs5D8p8j8kP5AFCSOkF5fnKdgPkgGUAf7BY7aXy5m44qqkaoAEGk= X-Received: by 2002:a17:902:da86:b0:188:62b7:1d6b with SMTP id j6-20020a170902da8600b0018862b71d6bmr4004454plx.106.1668196581838; Fri, 11 Nov 2022 11:56:21 -0800 (PST) MIME-Version: 1.0 References: <20221111130221.541603-1-oriachiuan@gmail.com> In-Reply-To: <20221111130221.541603-1-oriachiuan@gmail.com> From: Andrew Pinski Date: Fri, 11 Nov 2022 11:56:08 -0800 Message-ID: Subject: Re: [PATCH] fix small const data for riscv To: Oria Chen Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, andrew@sifive.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 11, 2022 at 5:03 AM Oria Chen via Gcc-patches wrote: > > gcc/testsuite ChangeLog: > > 2022-11-11 Oria Chen > > * gcc/testsuite/gcc.dg/pr25521.c: Add compile option "-msmall-data-limit=0" to avoid using .srodata section. I noticed g++.dg/cpp0x/constexpr-rom.C has some slightly different handling here. Seems like there should be a generic way to add -G0/-msmall-data-limit=0 if we don't want small data for a testcase rather than the current scheme of things. Thanks, Andrew Pinski > --- > gcc/testsuite/gcc.dg/pr25521.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c > index 74fe2ae6626..628ddf1a761 100644 > --- a/gcc/testsuite/gcc.dg/pr25521.c > +++ b/gcc/testsuite/gcc.dg/pr25521.c > @@ -2,7 +2,8 @@ > sections. > > { dg-require-effective-target elf } > - { dg-do compile } */ > + { dg-do compile } > + { dg-options "-msmall-data-limit=0" { target { riscv*-*-* } } } */ > > const volatile int foo = 30; > > -- > 2.37.2 >