Re: [PATCH 1/3] Put a TARGET_LRA_P into every target

[Andrew Pinski <pinskia@gmail.com>]

On Tue, Sep 13, 2016 at 12:03 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> On Tue, Sep 13, 2016 at 12:26:04PM +0200, Bernd Schmidt wrote:
>> On 09/13/2016 12:22 AM, Segher Boessenkool wrote:
>> >This patch adds a TARGET_LRA_P (defined to hook_bool_void_false) to
>> >every target that didn't yet override the hook.  No functional change.
>>
>> This patch series makes very little sense to me. Adding 35 new instances
>> of a hook definition so you can delete four others?
>
> No, the purpose is to default to LRA instead of reload.  Everything should
> switch to LRA eventually, so over time we need to define the macro in fewer
> and fewer targets, until one day whatever remains can all be ripped out.
>
> Yes, many targets need the hook definition after this series; that should
> stick out like a sore thumb, help to remind people to change their target
> to use LRA (not a huge amount of work for most, although it can get tricky).
>
> And all new ports should use LRA, so it should be the default.

Since nobody else has said anything on this patch besides Bernd, I am
going to say yes please.  This patch in my mind is the right way
forward.  In the same new ports should not be cc0 ports (though I know
some folks try that every once in a while).

Thanks,
Andrew

>
> Wrt "delete only four"...  There are five or six or so more that use LRA,
> but those can all be switched to use old reload instead.  Some day that
> will be turned off, too.
>
>
> Segher