From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id A98273858D37 for ; Mon, 26 Sep 2022 15:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A98273858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x435.google.com with SMTP id b23so7023214pfp.9 for ; Mon, 26 Sep 2022 08:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=6koAvVHpWgJH7x9HKjIh4uMfbXniNgApNxa4GSmPuGY=; b=OFno9OLzmoGZ3+Hle67OO84DR9RloRxSf/olQPRRuws2zmsJ4KgbJtfXIYJLLUTgir cmW4sw5AP3bszcqxU7qbfZl+UiuJhtP/KO+ZhZo4aljKsyAb1oUY5Lc1U1Bl9C3zuqqw ZxWNYmz94Eag1hG/3ma9maf/nmxpmb8RV+1S02fTW6sxxJgx2pgDcl7Fy2FsxsPpKfvW h4guvrNdlS9bk7PuIQ5Ae90yOR9Yatf0LayquY2kaJSHQLANykLmyJF4QlHxyXIrnNZb A4h3poFCTiXqUu1u+D5vozU2yYLM3kczljaNspf+nwidqzTVL0WVx7OnxRrQ1Z9RTos4 cTCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=6koAvVHpWgJH7x9HKjIh4uMfbXniNgApNxa4GSmPuGY=; b=SzhkyHowZEKylg3q8iRB4J87U1Q41qth1DqX0D+zqzh0ymH9V1CRI9gG22jlMzJFuL VvMGMflLedv1046swr/8xaZ1I9CREViK6WgJLyPCP563H17sFxOZXzKHKcJjAbPcDSJr i4U/LJHRucvJjE8Jun9T/LvyAA1Z/cxh1N0ywDNe+lyu9dpNMdTH4QNnrsl7pFAwKb9g 0xulHbfuw7GTGAyhRppkyhc5Y/ruaEfhzFWSZ3ihh+eYlV73dg9y2FYthG4yob6AxsEH SE+FSq1TcsfKQX7BTHelqK2gWQhjlcvFXnwHPY++kZfpYkeC1jOGiKDe3WebX+gNCPfO jNHA== X-Gm-Message-State: ACrzQf1xjaB3JqJWiDJrekqQmDa7Tw7kuO3uflWoYKEZwIlI2VgLmZwm U9H6bUBrt6s4peAyvzawyp0kNBYXl4PzgU8haq8= X-Google-Smtp-Source: AMsMyM5+HjN/Jef5FIz2No5e/AHwWKWQ1pb5TojXnlkUFEGWibSKFKJUi+tqbdF3Ri/YrpuKLRbmV983axiXAYemroE= X-Received: by 2002:a65:5b05:0:b0:439:a0ae:7e6a with SMTP id y5-20020a655b05000000b00439a0ae7e6amr20218680pgq.16.1664205908310; Mon, 26 Sep 2022 08:25:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Mon, 26 Sep 2022 08:24:55 -0700 Message-ID: Subject: Re: [PATCH 1/2]middle-end Fold BIT_FIELD_REF and Shifts into BIT_FIELD_REFs alone To: Tamar Christina Cc: "gcc-patches@gcc.gnu.org" , nd , "rguenther@suse.de" Content-Type: multipart/mixed; boundary="000000000000ffd42705e9962150" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ffd42705e9962150 Content-Type: text/plain; charset="UTF-8" On Sun, Sep 25, 2022 at 9:56 PM Tamar Christina wrote: > > > -----Original Message----- > > From: Andrew Pinski > > Sent: Saturday, September 24, 2022 8:57 PM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; rguenther@suse.de > > Subject: Re: [PATCH 1/2]middle-end Fold BIT_FIELD_REF and Shifts into > > BIT_FIELD_REFs alone > > > > On Fri, Sep 23, 2022 at 4:43 AM Tamar Christina via Gcc-patches > patches@gcc.gnu.org> wrote: > > > > > > Hi All, > > > > > > This adds a match.pd rule that can fold right shifts and > > > bit_field_refs of integers into just a bit_field_ref by adjusting the > > > offset and the size of the extract and adds an extend to the previous size. > > > > > > Concretely turns: > > > > > > #include > > > > > > unsigned int foor (uint32x4_t x) > > > { > > > return x[1] >> 16; > > > } > > > > > > which used to generate: > > > > > > _1 = BIT_FIELD_REF ; > > > _3 = _1 >> 16; > > > > > > into > > > > > > _4 = BIT_FIELD_REF ; > > > _2 = (unsigned int) _4; > > > > > > I currently limit the rewrite to only doing it if the resulting > > > extract is in a mode the target supports. i.e. it won't rewrite it to > > > extract say 13-bits because I worry that for targets that won't have a > > > bitfield extract instruction this may be a de-optimization. > > > > It is only a de-optimization for the following case: > > * vector extraction > > > > All other cases should be handled correctly in the middle-end when > > expanding to RTL because they need to be handled for bit-fields anyways. > > Plus SIGN_EXTRACT and ZERO_EXTRACT would be used in the integer case > > for the RTL. > > Getting SIGN_EXTRACT/ZERO_EXTRACT early on in the RTL is better than > > waiting until combine really. > > > > Fair enough, I've dropped the constraint. Well the constraint should be done still for VECTOR_TYPE I think. Attached is what I had done for left shift for integer types. Note the BYTES_BIG_ENDIAN part which you missed for the right shift case. Thanks, Andrew Pinski > > > > > > > > > Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu > > > and no issues. > > > > > > Testcase are added in patch 2/2. > > > > > > Ok for master? > > > > > > Thanks, > > > Tamar > > > > > > gcc/ChangeLog: > > > > > > * match.pd: Add bitfield and shift folding. > > > > > > --- inline copy of patch -- > > > diff --git a/gcc/match.pd b/gcc/match.pd index > > > > > 1d407414bee278c64c00d425d9f025c1c58d853d..b225d36dc758f1581502c8d03 > > 761 > > > 544bfd499c01 100644 > > > --- a/gcc/match.pd > > > +++ b/gcc/match.pd > > > @@ -7245,6 +7245,23 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > > > && ANY_INTEGRAL_TYPE_P (type) && ANY_INTEGRAL_TYPE_P > > (TREE_TYPE(@0))) > > > (IFN_REDUC_PLUS_WIDEN @0))) > > > > > > +/* Canonicalize BIT_FIELD_REFS and shifts to BIT_FIELD_REFS. */ (for > > > +shift (rshift) > > > + op (plus) > > > + (simplify > > > + (shift (BIT_FIELD_REF @0 @1 @2) integer_pow2p@3) > > > + (if (INTEGRAL_TYPE_P (type)) > > > + (with { /* Can't use wide-int here as the precision differs between > > > + @1 and @3. */ > > > + unsigned HOST_WIDE_INT size = tree_to_uhwi (@1); > > > + unsigned HOST_WIDE_INT shiftc = tree_to_uhwi (@3); > > > + unsigned HOST_WIDE_INT newsize = size - shiftc; > > > + tree nsize = wide_int_to_tree (bitsizetype, newsize); > > > + tree ntype > > > + = build_nonstandard_integer_type (newsize, 1); } > > > > Maybe use `build_nonstandard_integer_type (newsize, /* unsignedp = */ > > true);` or better yet `build_nonstandard_integer_type (newsize, > > UNSIGNED);` > > Ah, will do, > Tamar. > > > > > I had started to convert some of the unsignedp into enum signop but I never > > finished or submitted the patch. > > > > Thanks, > > Andrew Pinski > > > > > > > + (if (ntype) > > > + (convert:type (BIT_FIELD_REF:ntype @0 { nsize; } (op @2 > > > + @3)))))))) > > > + > > > (simplify > > > (BIT_FIELD_REF (BIT_FIELD_REF @0 @1 @2) @3 @4) > > > (BIT_FIELD_REF @0 @3 { const_binop (PLUS_EXPR, bitsizetype, @2, @4); > > > })) > > > > > > > > > > > > > > > -- --000000000000ffd42705e9962150 Content-Type: text/plain; charset="US-ASCII"; name="ed7c08c.diff" Content-Disposition: attachment; filename="ed7c08c.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8ix5duk0 RnJvbSBlZDdjMDhjNGQ1NjViZDQ0MThjZjJkY2UzYmJmZWNjMThmZGQ0MmEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgUGluc2tpIDxhcGluc2tpQG1hcnZlbGwuY29tPgpE YXRlOiBXZWQsIDI1IERlYyAyMDE5IDAxOjIwOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IHNpbXBsaWZpY2F0aW9uIG9mIHNoaWZ0IG9mIGEgYml0X2ZpZWxkLgoKV2UgY2FuIHNpbXBsaWZ5 IGEgc2hpZnQgb2YgYSBiaXRfZmllbGRfcmVmIHRvCmEgc2hpZnQgb2YgYW4gYW5kIChub3RlIHNv bWV0aW1lcyB0aGUgc2hpZnQgY2FuCmJlIHJlbW92ZWQpLgoKQ2hhbmdlLUlkOiBJMWE5ZjNmYzg3 ODg5ZWNkN2NmNTY5MjcyNDA1YjZlZTdkZDVmOGQ3YgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgUGlu c2tpIDxhcGluc2tpQG1hcnZlbGwuY29tPgotLS0KCmRpZmYgLS1naXQgYS9nY2MvbWF0Y2gucGQg Yi9nY2MvbWF0Y2gucGQKaW5kZXggY2I5ODFlYy4uZTRmNmQ0NyAxMDA2NDQKLS0tIGEvZ2NjL21h dGNoLnBkCisrKyBiL2djYy9tYXRjaC5wZApAQCAtNjA3MSw2ICs2MDcxLDM0IEBACiAgICAgKGNt cCAoYml0X2FuZCBAMCB7IHdpZGVfaW50X3RvX3RyZWUgKHR5cGUxLCBtYXNrKTsgfSkKICAgICAg ICAgIHsgd2lkZV9pbnRfdG9fdHJlZSAodHlwZTEsIGNzdCk7IH0pKSkpKQogCisvKiBsc2hpZnQ8 Yml0ZmllbGQ8Pj4gLT4gc2hpZnQoYml0X2FuZChAMCwgbWFzaykpICovCisoc2ltcGxpZnkKKyAo bHNoaWZ0IChjb252ZXJ0IChCSVRfRklFTERfUkVGQGJpdCBAMCBAYml0c2l6ZSBAYml0cG9zKSkg SU5URUdFUl9DU1RAMSkKKyAoaWYgKElOVEVHUkFMX1RZUEVfUCAodHlwZSkKKyAgICAgICYmIElO VEVHUkFMX1RZUEVfUCAoVFJFRV9UWVBFIChAMCkpCisgICAgICAmJiB0cmVlX2ZpdHNfdWh3aV9w IChAMSkKKyAgICAgICYmICh0cmVlX25vcF9jb252ZXJzaW9uX3AgKHR5cGUsIFRSRUVfVFlQRSAo QDApKQorCSAgfHwgKFRZUEVfVU5TSUdORUQgKFRSRUVfVFlQRSAoQDApKQorCSAgICAgICYmIFRZ UEVfVU5TSUdORUQgKFRSRUVfVFlQRSAoQGJpdCkpCisJICAgICAgJiYgVFlQRV9VTlNJR05FRCAo dHlwZSkKKwkgICAgICAmJiBUWVBFX1BSRUNJU0lPTiAodHlwZSkgPiB0cmVlX3RvX3Vod2kgKEBi aXRzaXplKSkpKQorICAod2l0aAorICAgeworICAgICB1bnNpZ25lZCBIT1NUX1dJREVfSU5UIGJp dHBvcyA9IHRyZWVfdG9fdWh3aSAoQGJpdHBvcyk7CisgICAgIHVuc2lnbmVkIEhPU1RfV0lERV9J TlQgYml0c2l6ZSA9IHRyZWVfdG9fdWh3aSAoQGJpdHNpemUpOworICAgICBpZiAoQllURVNfQklH X0VORElBTikKKyAgICAgICBiaXRwb3MgPSBUWVBFX1BSRUNJU0lPTiAoVFJFRV9UWVBFIChAMCkp IC0gYml0cG9zIC0gYml0c2l6ZTsKKyAgICAgd2lkZV9pbnQgd21hc2sgPSB3aTo6c2hpZnRlZF9t YXNrIChiaXRwb3MsIGJpdHNpemUsIGZhbHNlLCBUWVBFX1BSRUNJU0lPTiAodHlwZSkpOworICAg fQorICAgKHN3aXRjaAorICAgIChpZiAodHJlZV90b191aHdpIChAMSkgPT0gYml0cG9zKQorICAg ICAoYml0X2FuZCAoY29udmVydCBAMCkgeyB3aWRlX2ludF90b190cmVlICh0eXBlLCB3bWFzayk7 IH0pKQorICAgIChpZiAodHJlZV90b191aHdpIChAMSkgPiBiaXRwb3MpCisgICAgIChsc2hpZnQg KGJpdF9hbmQgKGNvbnZlcnQgQDApIHsgd2lkZV9pbnRfdG9fdHJlZSAodHlwZSwgd21hc2spOyB9 KQorCSAgICAgeyB3aWRlX2ludF90b190cmVlIChpbnRlZ2VyX3R5cGVfbm9kZSwgdHJlZV90b191 aHdpIChAMSkgLSBiaXRwb3MpOyB9ICkpCisgICAgKGlmICh0cmVlX3RvX3Vod2kgKEAxKSA8IGJp dHBvcykKKyAgICAgKHJzaGlmdCAoYml0X2FuZCAoY29udmVydCBAMCkgeyB3aWRlX2ludF90b190 cmVlICh0eXBlLCB3bWFzayk7IH0pCisJICAgICB7IHdpZGVfaW50X3RvX3RyZWUgKGludGVnZXJf dHlwZV9ub2RlLCBiaXRwb3MgLSB0cmVlX3RvX3Vod2kgKEAxKSk7IH0gKSkpKSkpCiAKIChpZiAo Y2Fub25pY2FsaXplX21hdGhfYWZ0ZXJfdmVjdG9yaXphdGlvbl9wICgpKQogIChmb3IgZm1hcyAo Rk1BKQo= --000000000000ffd42705e9962150--