From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 6F9743858D33 for ; Sat, 2 Dec 2023 19:23:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F9743858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F9743858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701545038; cv=none; b=xAKG7M1Nx5oTc+8y00hvAgTwZvU4Glh2SniDU7eOTJPemuO93QJaoRBQ6QaiXuGd6YOd3ybzgCkTxAwbUJfJOjjc0GknvpKBklVo03zvo3c65cBoIe+2+3W3voZ0eMChy3H9jNnxhTeBQgOJDNAts31hkVN3S/DAz2rS5Z0GVAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701545038; c=relaxed/simple; bh=xK6gNSbWKQazWXoLcsedKmS+1aRLYVGOlBQfojyeSFM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Eh7cCRiqnmgfR94N/npuVsvXuc7P5cpoCfgW/6EFMyRmQtAKnDSbIHkQRBIDZk0/dsgRuQmplwtorEGib92I5jCSB2FWk/Dv9H+Y6OSEjn9VvJgJk3Lovu2nqQrvFJpHXw8c+p+Jqi5fbT/0djXkNIb/27DlNzEKIvDpnddI2yQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3580b94ac2eso16758935ab.0 for ; Sat, 02 Dec 2023 11:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701545036; x=1702149836; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P65kKU9OR71Dbr94k3ztW32ug5MZ+EXRUH78Cu+u7eo=; b=Y9DcF9C8JNyTcPlb9ovwajq0b4k96fwud+bmdqZW1GXoS7jM4ug31ssT6OCiEUf9Ch rA6oOI9rTp25+DqDPay28Mv03ocUkwpSomf6tjZVIwoDxea1zFTl5dgNv1HYZB1QQiN+ m9rMz1q6AjzEfWqkhhc4lBiJvFl2ZPQBwsXkxOMlbEz5yloii4q2ZSCmw9eDZiz8cqZd W+sKiHHCFjeIoun08Wagkhakk5CilVzi2LY+EWLMnhCwzlnjnRKQKnsCqBtxB6FyJQXa 7NzRCJHTuJoRevgxvEyfI0D61/Mw8j7lUr3Lwm+I6O6w1NvhRvmplm5FjGgD/G0VWjLY oa5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701545036; x=1702149836; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P65kKU9OR71Dbr94k3ztW32ug5MZ+EXRUH78Cu+u7eo=; b=AvqspgNQ+sLpzriFlWqNwW5CK6N5EDtavOGWuRNrd26J/XHLi02KFMdroh2+IYSelD 8aIf5627IalEtL5GQZAARJAR1Z4CnJ4Mo4t6HBpZBHCQrlZJnenvQrj9nBS/sCYrs/7A XlMSW3PiR6VNyWPbEHaUgE2dQ3YXUeJCKlF/LC4ksd+qbI8dq7FFuCNH7uB/aA7lOjjf JQtcYAKx7q8m+HFc4DOGqW9Wt8Od4Y2IMg38vMKRdl6uFSxXishYxAu/v+ZkOO8q162f g30QY5zEJKY4FFiUyAM0Iau6QNXvIpau9zBkYhkUeeQQV9+G49Uvlb3SGv73MbI9f8h1 do/g== X-Gm-Message-State: AOJu0YzKmzhi8a84dXOEEdahLUCc78su83Baj1WWB5cz5LkoUjBnY/lf aaF4uY3XILCiYBk5UO8TDintT7R9cb7YplSxNEY= X-Google-Smtp-Source: AGHT+IHRaigH3YVWToVTbSLor+TKV/RJ8hx0QRIfPG2B1zLPuYjEjb2/M3+iQe5qRTnyeyAoGBg0i8OYob3yctr0QDE= X-Received: by 2002:a05:6e02:130f:b0:35d:59a2:2bb with SMTP id g15-20020a056e02130f00b0035d59a202bbmr2022789ilr.91.1701545036543; Sat, 02 Dec 2023 11:23:56 -0800 (PST) MIME-Version: 1.0 References: <60a89113beb96fc0183c8ebc2a0dc8d6feb91478.1699025214.git.szabolcs.nagy@arm.com> In-Reply-To: <60a89113beb96fc0183c8ebc2a0dc8d6feb91478.1699025214.git.szabolcs.nagy@arm.com> From: Andrew Pinski Date: Sat, 2 Dec 2023 11:23:44 -0800 Message-ID: Subject: Re: [PATCH v2 3/7] aarch64: Add eh_return compile tests To: Szabolcs Nagy Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 3, 2023 at 8:37=E2=80=AFAM Szabolcs Nagy wrote: > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/eh_return-2.c: New test. > * gcc.target/aarch64/eh_return-3.c: New test. gcc.target/aarch64/eh_return-3.c fails when running the testsuite with `-march=3Darmv9-a+sve` . I think it is a good idea to try to keep the testsuite clean when running with different -march=3D/-mcpu=3D options even. I know there are many failures due to -march=3D/-mcpu option right now but this is a new testcase and all. Thanks, Andrew > > --- > v2: check-function-bodies in eh_return-3.c > (this is not very robust, but easier to read) > --- > .../gcc.target/aarch64/eh_return-2.c | 9 ++++++ > .../gcc.target/aarch64/eh_return-3.c | 30 +++++++++++++++++++ > 2 files changed, 39 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/aarch64/eh_return-2.c > create mode 100644 gcc/testsuite/gcc.target/aarch64/eh_return-3.c > > diff --git a/gcc/testsuite/gcc.target/aarch64/eh_return-2.c b/gcc/testsui= te/gcc.target/aarch64/eh_return-2.c > new file mode 100644 > index 00000000000..4a9d124e891 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/eh_return-2.c > @@ -0,0 +1,9 @@ > +/* { dg-do compile } */ > +/* { dg-final { scan-assembler "add\tsp, sp, x5" } } */ > +/* { dg-final { scan-assembler "br\tx6" } } */ > + > +void > +foo (unsigned long off, void *handler) > +{ > + __builtin_eh_return (off, handler); > +} > diff --git a/gcc/testsuite/gcc.target/aarch64/eh_return-3.c b/gcc/testsui= te/gcc.target/aarch64/eh_return-3.c > new file mode 100644 > index 00000000000..bfbe92af427 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/eh_return-3.c > @@ -0,0 +1,30 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -mbranch-protection=3Dpac-ret+leaf" } */ > +/* { dg-final { check-function-bodies "**" "" "" } } */ > + > +/* > +**foo: > +** hint 25 // paciasp > +** stp x0, x1, .* > +** stp x2, x3, .* > +** cbz w2, .* > +** mov x4, 0 > +** ldp x2, x3, .* > +** ldp x0, x1, .* > +** cbz x4, .* > +** add sp, sp, x5 > +** br x6 > +** hint 29 // autiasp > +** ret > +** mov x5, x0 > +** mov x6, x1 > +** mov x4, 1 > +** b .* > +*/ > +void > +foo (unsigned long off, void *handler, int c) > +{ > + if (c) > + return; > + __builtin_eh_return (off, handler); > +} > -- > 2.25.1 >