From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 30E3C3858D1E for ; Mon, 17 Jul 2023 07:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30E3C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-3487d75e4c5so7630425ab.0 for ; Mon, 17 Jul 2023 00:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689578855; x=1692170855; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ypMAkicHcXM6GhtAtEZaCPiOJ71AcgZwlJ/bGr2Lm2c=; b=fUJ5g0aa7UEhCRAOXzr2A5ZObcmdYM9jyYHGCkSAvisImYaeB6wVIhd+bztbRQh1w5 llp8rk6pwAgT6E1jr4bVDoKaQ2ENupepODxZQrq8S4DdqExa38Q+beft+nP/R1Cx6mSi Uy72L8+O9LS56SNJrAGFjRM2opIWH9pqA5LEVlIMszoZQxwM7du3KIKe4eLC20qxXvlQ MBpUDrwnuTUZArQ4gxPhYVfWP2zDj3e7NRfaV9Tr0EgI2J4HOuXZC9BQhfHCMXX8zcwu MXQ/4WJhDtKtyUtCbIxSAa9/WrDajXRvLE1n3T8dFnKxc6fHuLuwGNMgMseY5yW3n7S4 uJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689578855; x=1692170855; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ypMAkicHcXM6GhtAtEZaCPiOJ71AcgZwlJ/bGr2Lm2c=; b=UiYxEWKG+ZLyXOO+OX9yp/Ls4j4KM3oLaEyZAOp0yCIYZCESt1gx54FIjjnrWCAvtC 7UXtuQkvdkFllPPDPxuvP4gIl71tHcb5FuVWwydFCoO5cR5y3oZWpIl+TxL4S3SdgUvE njsp7qJXw8WKek554sCdjCR3pbjHbfMoHbUDjhZ79jzrX0uMJrGCMwNCNqq3NSZuHF/+ 3jynonP6a4GVzcXRH7FFcDSmtX2YbxJJmRXwmROlN+EU0/OQfFiLwsekURYDkiXrBrst PCKCeJMtgTRiKxrgzhRVaaWIpbEnlMYLBIbpACHEeebtZ4kDavRYxPMRRzbtIGE+efKv cCxg== X-Gm-Message-State: ABy/qLbln3HHhHoPpkR3MpvCLBUxHElnrQtr97P6aYG81UJz6tbNJGyQ pwW9AlS8ADjOZYzUpakBLTiJEVl1J3WqnNnIKjg= X-Google-Smtp-Source: APBJJlFsfjCfdaweARfqQ42ldSKZ24PIZTofFsxy01NsU2dwyc1Tf/i/DTv3RJ1wJmu13oCkdyKoKrTMVFGM3qZ0psA= X-Received: by 2002:a05:6e02:144d:b0:348:8aec:179c with SMTP id p13-20020a056e02144d00b003488aec179cmr1153536ilo.32.1689578855284; Mon, 17 Jul 2023 00:27:35 -0700 (PDT) MIME-Version: 1.0 References: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com> In-Reply-To: From: Andrew Pinski Date: Mon, 17 Jul 2023 00:27:23 -0700 Message-ID: Subject: Re: [PATCH] Fix bootstrap failure (with g++ 4.8.5) in tree-if-conv.cc. To: Tamar Christina Cc: Richard Biener , Roger Sayle , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 17, 2023 at 12:21=E2=80=AFAM Tamar Christina via Gcc-patches wrote: > > > -----Original Message----- > > From: Richard Biener > > Sent: Monday, July 17, 2023 7:19 AM > > To: Roger Sayle > > Cc: gcc-patches@gcc.gnu.org; Tamar Christina > > Subject: Re: [PATCH] Fix bootstrap failure (with g++ 4.8.5) in tree-if-= conv.cc. > > > > On Fri, Jul 14, 2023 at 8:56=E2=80=AFPM Roger Sayle > > wrote: > > > > > > > > > > > > This patch fixes the bootstrap failure I'm seeing using gcc 4.8.5 as > > > > > > the host compiler. Ok for mainline? [I might be missing something] > > > > OK. Btw, while I didn't spot this during review I would appreciate > > if the code could use vec.[q]sort, this should work with a lambda as we= ll I > > think. > > That was my first use, but that hits https://gcc.gnu.org/bugzilla/show_bu= g.cgi?id=3D99469 That is not hitting PR 99469 but rather it means your comparison is not correct for an (unstable) sort. That is qsort comparator should have this relationship `f(a,b) =3D=3D !f(b, a)` and `f(a,a)` should also return false. If you are running into this for qsort here, you will most likely run into issues with std::sort later on too. Thanks, Andrew > > Regards, > Tamar