From: Andrew Pinski <pinskia@gmail.com>
To: James Greenhalgh <james.greenhalgh@arm.com>
Cc: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>,
Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Pinski, Andrew" <Andrew.Pinski@cavium.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH] [AArch64] Implement popcount pattern
Date: Fri, 03 Feb 2017 05:56:00 -0000 [thread overview]
Message-ID: <CA+=Sn1=cjE36cLvbPr+DsgNdW83rzN6a=-dZuVgzjoh8hVoiHw@mail.gmail.com> (raw)
In-Reply-To: <20170202115540.GB37031@arm.com>
On Thu, Feb 2, 2017 at 3:55 AM, James Greenhalgh
<james.greenhalgh@arm.com> wrote:
> On Thu, Feb 02, 2017 at 04:03:42AM +0000, Hurugalawadi, Naveen wrote:
>> Hi James and Kyrill,
>>
>> Thanks for the review and comments on the patch.
>>
>> >> On ILP32 systems this would still use the SImode patterns,
>> >> so I suggest you use __builtin_popcountll and
>> >> an unsigned long long return type to ensure you always exercise the 64-bit code.
>>
>> Sorry for not commenting on this part.
>> The issue is that code generates "__popcountdi2" for all the codes in testcase
>> for LP64 and ILP32 variants.
>> __builtin_popcount, __builtin_popcountl and __builtin_popcount.
>>
>> Hence, modified the patch to check for "popcount".
>
> I don't understand this comment and how it relates to your updated
> patch (which still checks for CNT).
Now I understand Kyrill's comments as Naveen and I did not understand
before. What Naveen was trying to test was that there was no longer
any call to __popcountdi2 or __popcountsi2 any more for all three:
__builtin_popcount, __builtin_popcountl and __builtin_popcountll.
Kyrill was asking him to change the test for __builtin_popcountl to
__builtin_popcountll even though there was already one test in that
file already. Now of course what should change still is the argument
types to foo1/foo2 so they take long and long long respectively. He
will post a new version of the patch soon.
>
>> Bootstrapped and regression tested on AArch64-Thunderx-Linux machine.
>>
>> Please find attached the modified patch and let us know if its okay?
>
> Could you please clarify what you meant above? The patch looks fine (though
> possibly not for Stage 4), but I'm not sure of your intent.
What he meant was he tested on aarch64-linux-gnu with no regressions.
Is it ok for when stage 1 opens with the change of the testcase?
Thanks,
Andrew
>
> Thanks,
> James
next prev parent reply other threads:[~2017-02-03 5:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 3:30 [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion Hurugalawadi, Naveen
2016-12-09 7:02 ` Hurugalawadi, Naveen
2017-02-06 6:46 ` Hurugalawadi, Naveen
2017-04-25 7:03 ` [PING] " Hurugalawadi, Naveen
2017-04-25 8:37 ` Kyrill Tkachov
2017-04-26 9:04 ` Hurugalawadi, Naveen
2017-05-11 4:56 ` [PING] " Hurugalawadi, Naveen
2017-05-26 6:27 ` [PING 2] " Hurugalawadi, Naveen
2017-06-09 14:16 ` James Greenhalgh
2017-06-13 10:25 ` Hurugalawadi, Naveen
2017-06-13 13:56 ` James Greenhalgh
2017-06-14 8:53 ` Hurugalawadi, Naveen
2017-06-14 9:10 ` James Greenhalgh
2016-12-12 3:16 ` [PATCH] [AArch64] Implement popcount pattern Hurugalawadi, Naveen
2016-12-12 10:53 ` Kyrill Tkachov
2016-12-13 11:51 ` Hurugalawadi, Naveen
2016-12-13 11:59 ` Kyrill Tkachov
2017-01-25 8:07 ` [PATCH] [AArch64] Enable AES and cmp_branch fusion for Thunderx2t99 Hurugalawadi, Naveen
2017-01-25 9:29 ` Kyrill Tkachov
2017-02-02 5:03 ` Hurugalawadi, Naveen
2017-02-02 11:43 ` James Greenhalgh
2017-02-01 13:56 ` [PATCH] [AArch64] Implement popcount pattern James Greenhalgh
2017-02-02 4:03 ` Hurugalawadi, Naveen
2017-02-02 11:56 ` James Greenhalgh
2017-02-03 5:56 ` Andrew Pinski [this message]
2017-02-03 7:02 ` Hurugalawadi, Naveen
2017-02-03 10:28 ` Kyrill Tkachov
2017-02-04 4:04 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1=cjE36cLvbPr+DsgNdW83rzN6a=-dZuVgzjoh8hVoiHw@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=Andrew.Pinski@cavium.com \
--cc=Naveen.Hurugalawadi@cavium.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).