From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id A979B3858D37 for ; Sun, 22 Oct 2023 16:10:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A979B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A979B3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697991005; cv=none; b=B7xyrYpBTB+YW2aSPW6warvzYYMBc3hMWYnZUjL0YGUf5V25mb2O0dmQzFR0C6FAIaxLgn2JW0JPcqSMxIeh9kGv2tmX6VEu+GBfB7AJXvOUglFKtwecPE1qtj7QbMCaOBNG1xXROu52XbCq/WIE6ThFMtpyl8hPLbNJKxdFoY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697991005; c=relaxed/simple; bh=0iMbcNIBVK7xGKxTXhJ+DySrN5ju9nikzFmdQQqxWfA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=k2fynsv7G27pn0VuK7q+SqqS5Mvf6GhngMZXtPovMnFBVGZwYjNpWA+Zf+QZ5PJA8Fis90lS4lmI76gkAj612Jq+bk9J6EmLZqlHWvdJV/2wbW3BW6rU6Ss5mBSZx72wj5zss4NU2ZPSVNsXSdgg9n13gUanv4up3T6720V0ShM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6b9af7d41d2so1990601b3a.0 for ; Sun, 22 Oct 2023 09:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697991003; x=1698595803; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8yWR8l2lUN+LHgwIn2brX3y2vPlNVyV0OwaW7QO5eEs=; b=Ecgx7b4Shjeaf3bMZB6zkrdRDlp/Ew6K/tcoQ76xEANiaatTK30fFABCpxjcZfItiA 5fdKc2qExc7ZtV4GSipiJxtuA4490dlM0YJ8zq/IKzv5GpyX8L/5IIqPV7oeh2IDvGGP duZzVvS/LUdi/sSXrdQlcB4rA/DAS+ImAl3IjlYGaS5SiNqTMv0cqIpcK3t9z+u7A8rp IJ71ZxDVU2y1eZAZITu2GAUy/ncouBPoIvzKAr5CVE/3UEdFeYde6wFOkMsnYAa5R/G7 QrHYVj2z3vEcqWHoalujs+PueufxlbWppPaazUfD5040XMltzf8+doGPoRjKOyOroSEt iA4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697991003; x=1698595803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8yWR8l2lUN+LHgwIn2brX3y2vPlNVyV0OwaW7QO5eEs=; b=jDrQyVXuaaEkHxeYulxpfr7g7KdDIfY5Lxc5TDAfQWHr27LGmOjbLRd1jXPQttSfDE j3HT1esnHupuYNiK26jf3J48tPCND1NCiEkNygqXB2bJq1y8aUGoxYVCLR3wNd3hJgA1 VYeS9emAuYsdzeZouAgchQbQP+nkzmTXKYDbkH+A+WrNeVD3aSUS57o4tz3WdMIV17cl mOKbMxbvqMcbAmbb6UCt/dc3m0eRSrSCZHIzOWoPag9ueT/bTk/fnP/gRikK4giAKlbS SZjV72hg83hEBYitayfCy10p4crfJExrC2hd+W+xoft1w08sQaP73QqdpuqnryCrGAW9 131g== X-Gm-Message-State: AOJu0YxLr9OvKxb85Jrm/oUiFZ+s4tkW90+AlevFncgmJlSFF+uu1A3v NA5BfvxDsT1o2GGtFRDMgYS5yPNDva01ygemiT8= X-Google-Smtp-Source: AGHT+IHBg+uowEmRNnQLDSSzVLK7ux3ZkBMvkJ83znG90AGmTv7JqISrNYKItU//TX1kpvvgGRbiaJIOZ01V88jCjfc= X-Received: by 2002:a05:6a20:9387:b0:14d:9bd1:6361 with SMTP id x7-20020a056a20938700b0014d9bd16361mr6028059pzh.11.1697991002885; Sun, 22 Oct 2023 09:10:02 -0700 (PDT) MIME-Version: 1.0 References: <87zg0bhzep.fsf@oldenburg.str.redhat.com> In-Reply-To: <87zg0bhzep.fsf@oldenburg.str.redhat.com> From: Andrew Pinski Date: Sun, 22 Oct 2023 09:09:50 -0700 Message-ID: Subject: Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Oct 22, 2023 at 12:47=E2=80=AFAM Florian Weimer wrote: > > Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. > Defining the macro avoids an implicit function declaration. This does not help targets that don't use glibc though. Note for builtins testsuite there is a lib-fputs.c file which will define a fputs_unlock which is how it will link even if the libc does not define a fputs_unlock. Thanks, Andrew Pinski > > gcc/testsuite/ > > * gcc.c-torture/execute/builtins/fputs.c (_GNU_SOURCE): > Define. > > --- > gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c b/gcc/t= estsuite/gcc.c-torture/execute/builtins/fputs.c > index 93fa9736449..13e30724355 100644 > --- a/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c > +++ b/gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c > @@ -5,6 +5,7 @@ > > Written by Kaveh R. Ghazi, 10/30/2000. */ > > +#define _GNU_SOURCE /* For fputs_unlocked. */ > #include > extern void abort(void); > >