From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 0DB923858C41 for ; Thu, 26 Oct 2023 19:00:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DB923858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DB923858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1033 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698346828; cv=none; b=fDzfRcx6yb/XZFwmZ/uE1hbvL3ZHrLsVIfeTumDQDt2J53QGhnIIpFs3FgVFs1U2wLd+LT1Bb1mlNH/gPqU+zP4AB587DO2+CYlAgYQC5Q2Op/cwv1gM5MZdn8J8PtrDuDIeRmY8SKFgmsUdYMg+5SMA6dkvYJf+s1lkHToy6lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698346828; c=relaxed/simple; bh=taDyrkdBOR3xhO01939zzMWWm0D2aQIDDPG26fJMfy4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=XY4ELTtUb5KY4I6yIJEdGFIa25JQ4m8SLkfaQ63BzyD5HJpWBlL1Iapx5DoGdVniBr5xLQL1M95OM8IqUbVnCWF+AjtJdyL0iUI+tO4LqV1ncHPUrMQiNhvZCvtW8Kjz1/lJXIJlVLXkEQKGCObnSTLO5l93egXEcY6mAuo/t5k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-27ff7fe7fbcso834122a91.1 for ; Thu, 26 Oct 2023 12:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698346826; x=1698951626; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DMfI1rOOAHrAKrZjvx5dc3hHTOcoI5ukhKaBFAedG38=; b=dKk8XT/N7sLLeQa34wDLxpxslBv0tSokwM7RcmgZU9e0u/0ixoH24fAfNml45qMQxc aR8hBYgIyBboUF50ZjQA5XdvxOxxL2SiWtWqfVhPAYjtd1Jz0K7ILPBEBM4TyAqUPIaR it7Tv73cq471O/A9lj+360g9svyd2521nOH/ssh71qboDbMgnL89nQmY8Tgr8PkkQSrN JvqTUnEAjwwd18G7Db0QzWLr/KDLSSEIvmgA8YvssVfaUbfD7pGct4GybtHuI3UlcJUd kptitPu+wV3Ne8sMNfKPpyadcAPRPiAywQcWTA5OmL1zYQ+/DY+O/ycBo5KlSfQ2v2PA OWyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698346826; x=1698951626; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DMfI1rOOAHrAKrZjvx5dc3hHTOcoI5ukhKaBFAedG38=; b=TMBdOHzGeTUqRscX+W6IfOVDFcGQIS3tA9NV3A0XRE8q2FoN4mH1vww1HG3qlPb2dm Kg7zk9PTo0fE/9BHLdREjkgYybjxqDMVCcg6VbMo8GXvnFaa4QSmQg/rrk4Csg/T2fxr 9UwkXLWRAg7m8vucJzHbvnMdxAcv4vPaCFMmzUikBuFtZqkFbjKAFhSBIRhFVaI6jrgU 19JNEPW2HnkaFNjOPY29n6mB77i7OMLgm+aGaZh5xp2AgIxplG2zJtSk8YXko2f6wV4s 0X80M69ri1FvNkJDPXEd/tM4dEys0h/i8Tgi6j2jKvRF/wuZuENBSDqQZWMayCRohNzV Wqsw== X-Gm-Message-State: AOJu0Yy9STWPINv9Hi4CINqY8IaqrYw5Osn/RSZ4zTkfkM2da9DT51Em psV3YxujKemYTaY0CoJemQGAH9Lyq2e1sZwEqT8AGYj5yXg= X-Google-Smtp-Source: AGHT+IEp6whPdEy7sst6dvfcMOj4z40YQE3ji0K9cBjso/JI4hGZ2AqmZdc7W3CT2C8MIpRu5Y2BIFoWk59RZJ453N8= X-Received: by 2002:a17:90a:f686:b0:26b:e27:8bc2 with SMTP id cl6-20020a17090af68600b0026b0e278bc2mr390444pjb.45.1698346825916; Thu, 26 Oct 2023 12:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20231026185734.56102-1-iain@sandoe.co.uk> In-Reply-To: <20231026185734.56102-1-iain@sandoe.co.uk> From: Andrew Pinski Date: Thu, 26 Oct 2023 12:00:13 -0700 Message-ID: Subject: Re: [PATCH] testsuite, aarch64: Normalise options to aarch64.exp. To: iain@sandoe.co.uk Cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 26, 2023 at 11:58=E2=80=AFAM Iain Sandoe = wrote: > > tested on cfarm185 (aarch64-linux-gnu, xgene1) and with the aarch64 > Darwin prototype. It is possible that some initial fallout could occur > on some test setups (where the default has been catered for in some > way) - but that should stabilize. OK for trunk? This fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D93619 I think. Thanks, Andrew > thanks > Iain > > --- 8< --- > > When the compiler is configured --with-cpu=3D and that is different from > the baselines assumed, we see excess test fails (primarly in body code > scans which are necessarily sensitive to costs). To stabilize the > testsuite against such changes, use aarch64-with-arch-dg-options () > to provide suitable consistent defaults. > > e.g. for --with-cpu=3Dxgene1 we see over 100 excess fails which are > removed by this change. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/aarch64.exp: Use aarch64-with-arch-dg-option= s > to normaize the options to the tests in aarch64.exp. > > Signed-off-by: Iain Sandoe > --- > gcc/testsuite/gcc.target/aarch64/aarch64.exp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/aarch64.exp b/gcc/testsuite= /gcc.target/aarch64/aarch64.exp > index bd306e3b288..7612ea704e5 100644 > --- a/gcc/testsuite/gcc.target/aarch64/aarch64.exp > +++ b/gcc/testsuite/gcc.target/aarch64/aarch64.exp > @@ -37,9 +37,10 @@ if ![info exists DEFAULT_CFLAGS] then { > # Initialize `dg'. > dg-init > > -# Main loop. > -dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ > - "" $DEFAULT_CFLAGS > - > +aarch64-with-arch-dg-options "" { > + # Main loop. > + dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ > + "" $DEFAULT_CFLAGS > +} > # All done. > dg-finish > -- > 2.39.2 (Apple Git-143) >