From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40460 invoked by alias); 30 Jun 2017 20:40:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40443 invoked by uid 89); 30 Jun 2017 20:40:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2257 X-HELO: mail-yb0-f170.google.com Received: from mail-yb0-f170.google.com (HELO mail-yb0-f170.google.com) (209.85.213.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 20:40:03 +0000 Received: by mail-yb0-f170.google.com with SMTP id 84so41709209ybe.0 for ; Fri, 30 Jun 2017 13:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GtC9F8YO/+9auPUD7FqxdBZJ1042tu1Ble+4A/IO4ho=; b=XdBgH02jS6+9/qz+cbe5C2C5vAGtLgWUeCdf2z3E6SFh/LGhv/nk2qbYUXy5O1Lfdn +6hL4OTIYbFq/OzYgTwaTuabw06Q2YWdeUGZIqc9V18ExOKZe2YVkxqCJyAf5HcXSZhd mLV2og+hxN7OrWEBR3C3YCvb//rUCbN8jem3Oc4AAaTAKQa3W6Qtad8091Ymmk4voaut F3N8wB3fWuuuF7Aj2C7Cr1eHDOr4R+94Sd2xFWvM3v/zRyWPAaPBrensCU5oH5XR1POw 1b4VoGAe8X4yK4SBlu0qJq6xNjQjIZK/J6RCFBwKjFSDhUnpxUVDesR+6cn0p430jMXF Wcgg== X-Gm-Message-State: AKS2vOwUddMVg580xQXpPzsuvaMXGOuhXsaHubwy99D0g+061t/a+UHI pykN/BB+G9JGl2UnY173Svz/cSXUNA== X-Received: by 10.37.176.140 with SMTP id f12mr17844337ybj.231.1498855202213; Fri, 30 Jun 2017 13:40:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.47.200 with HTTP; Fri, 30 Jun 2017 13:40:01 -0700 (PDT) In-Reply-To: References: From: Andrew Pinski Date: Fri, 30 Jun 2017 20:40:00 -0000 Message-ID: Subject: Re: [PATCH] [PR 81245] Fix tree-if-conv calling of update_stmt after fold_stmt To: Richard Biener Cc: GCC Patches Content-Type: multipart/mixed; boundary="f403045e54e6e611c40553336b66" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02437.txt.bz2 --f403045e54e6e611c40553336b66 Content-Type: text/plain; charset="UTF-8" Content-length: 995 On Fri, Jun 30, 2017 at 1:20 AM, Richard Biener wrote: > On Thu, Jun 29, 2017 at 10:12 PM, Andrew Pinski wrote: >> Hi, >> As described in the bug, tree-if-conv is calling update_stmt on an >> old stmt which might have been removed from the IR already >> (transforming of an assignment to a call in this case). This fixes >> the problem by calling update_stmt on the new statement that fold_stmt >> might have created. >> >> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. > > update_stmt is not necessary when fold_stmt doesn't return true as > gsi_insert_before already updates the stmt. > > Thus ok with moving update_stmt under the conditional. This is what I applied. Thanks, Andrew > > Thanks, > Richard. > >> Thanks, >> Andrew Pinski >> ChangeLog: >> * tree-if-conv.c (predicate_scalar_phi): Update new_stmt if fold_stmt >> returned true. >> >> testsuite/ChangeLog: >> * gcc.dg/torture/pr81245.c: New testcase. --f403045e54e6e611c40553336b66 Content-Type: text/plain; charset="US-ASCII"; name="fixifcvt.diff.txt" Content-Disposition: attachment; filename="fixifcvt.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4kbm8s00 Content-length: 1704 SW5kZXg6IHRlc3RzdWl0ZS9nY2MuZGcvdG9ydHVyZS9wcjgxMjQ1LmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gdGVzdHN1aXRlL2djYy5kZy90b3J0 dXJlL3ByODEyNDUuYwkobm9uZXhpc3RlbnQpCisrKyB0ZXN0c3VpdGUvZ2Nj LmRnL3RvcnR1cmUvcHI4MTI0NS5jCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMTYgQEAKKy8qIHsgZGctb3B0aW9ucyAiLWZmYXN0LW1hdGgiIH0gKi8K Ky8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiBUaGlzIHRlc3QgdXNlZCB0 byBjcmFzaCB0aGUgdmVjdG9yaXplciBhcyB0aGUgaWZjb252ZXJ0IHBhc3MK KyAgIHVzZWQgdG8gY29udmVydCB0aGUgaWYgdG8gY29weXNpZ24gYnV0IGNh bGxlZCB1cGRhdGVfc3RtdCBvbgorICAgdGhlIG9sZCBzdGF0ZW1lbnQgYWZ0 ZXIgY2FsbGluZyBmb2xkX3N0bXQuICovCitkb3VibGUgc2dbMThdOwordm9p ZCBmKHZvaWQpCit7CisgIGZvciAoaW50IGkgPSAwIDtpIDwgMTg7aSsrKQor ICB7CisgICAgaWYgKHNnW2ldIDwgMC4wKQorICAgICAgc2dbaV0gPSAtMS4w OworICAgIGVsc2UKKyAgICAgIHNnW2ldID0gMS4wOworICB9Cit9CkluZGV4 OiB0cmVlLWlmLWNvbnYuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0 cmVlLWlmLWNvbnYuYwkocmV2aXNpb24gMjQ5ODQ0KQorKysgdHJlZS1pZi1j b252LmMJKHdvcmtpbmcgY29weSkKQEAgLTE4NTMsOCArMTg1MywxMSBAQAog ICAgICAgbmV3X3N0bXQgPSBnaW1wbGVfYnVpbGRfYXNzaWduIChyZXMsIHJo cyk7CiAgICAgICBnc2lfaW5zZXJ0X2JlZm9yZSAoZ3NpLCBuZXdfc3RtdCwg R1NJX1NBTUVfU1RNVCk7CiAgICAgICBnaW1wbGVfc3RtdF9pdGVyYXRvciBu ZXdfZ3NpID0gZ3NpX2Zvcl9zdG10IChuZXdfc3RtdCk7Ci0gICAgICBmb2xk X3N0bXQgKCZuZXdfZ3NpLCBpZmN2dF9mb2xsb3dfc3NhX3VzZV9lZGdlcyk7 Ci0gICAgICB1cGRhdGVfc3RtdCAobmV3X3N0bXQpOworICAgICAgaWYgKGZv bGRfc3RtdCAoJm5ld19nc2ksIGlmY3Z0X2ZvbGxvd19zc2FfdXNlX2VkZ2Vz KSkKKwl7CisJICBuZXdfc3RtdCA9IGdzaV9zdG10IChuZXdfZ3NpKTsKKwkg IHVwZGF0ZV9zdG10IChuZXdfc3RtdCk7CisJfQogCiAgICAgICBpZiAoZHVt cF9maWxlICYmIChkdW1wX2ZsYWdzICYgVERGX0RFVEFJTFMpKQogCXsK --f403045e54e6e611c40553336b66--