From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 615A4384B000 for ; Wed, 8 May 2024 16:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 615A4384B000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 615A4384B000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715184494; cv=none; b=Ybs1FtmzsD60912erPZFNYGEiKRU8uAJGLHxKjr6xNdyVvCmfVfe0xz1wOBN58MYzcXbuEF3HvxIdsS946mPbJH2FSSblHGEZxuW9LTIeTEdKiMSFRmHuY7+0tRmNlXj4Zw9vXBPdcEWKTNP5iPzKvl+UlqpqAOwLmI1+0wZ5l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715184494; c=relaxed/simple; bh=2mSGZi2EDcqmI83DEAQbBVmZQ2vQ1GvZ0BdpxqZRmC0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Qtwkc5dci2Vu+HqqNyUqlqe855qT8FMve03TBv+tJIAc86rp+hJQBCCCiPA0ZXlc2nntTX3xEgahd5/A9ilb+8mT5A93Qdb+S6EXzZh726dNBfs/1He7P3/IfFlxjeDLirH+JJ4NzCcdtEsy2JcCaI3+/g2n1KUqT6nuuD/7hBE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso3728524a12.2 for ; Wed, 08 May 2024 09:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715184491; x=1715789291; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Nx1mMKGv2I8bEhGqv7r9ZjIM2OTCQEMzn5ADkggMPF0=; b=BNQvoSI73sB1dm1WapwgXclsr/SxmAQ9LVFe4++hoZloZ+VHF0tEL79XX76cnywOCV SgSb0qSC30IrtpMtgyyHGEHWIwZ8XlsA6d/WsM5l+et+sH0+WYlLC11LWu0Mvh+6r38R dDTAcILHtBPDMiwIPcCgflYyR31WV2YW1k1duoCtT9MTkTKG6nfOfJ0+iPPsvTudHxgj cS6yyWpCjVo4GgpqAPP52sfbVWrRolDSFF/GyDc83C2pjY6y2qMo0r6KXJNhvGjUGwAS HXv1eZ0R5hlHkFZtMjnOFOZigAXX6Pa3iC/N7wMH45kYxY4eBfKgWq4Cvep9kfb53m0d 5EbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715184491; x=1715789291; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nx1mMKGv2I8bEhGqv7r9ZjIM2OTCQEMzn5ADkggMPF0=; b=lMkL1xZSPycUVpK3ZUDpTQooeVJ5u5YuRGkagc6oFZuDvjc3NsvTwWFiTz3lUTnM0e QPnTWtSdwnlA6AfFpMOuNjD2P0FTO16HSYnYCyC0be5GyWgU7h8EvwYP+iQ6tquVshyP pH2P5w+zGNFt8hZmnu5zWJTsBneQnunoe69ZMayUsaJojBG/VZq4qTBKs8RJxp7SDlLH ih2uhMawK5tLHjq8YFRRujc9Va+S73R4AS4rofDIlmj6OVuPRxSwsTHI8rtC4amN+c1q VWnOc+2MMsoJxtB0h+DouaDDPn4OejeCKUu3iwMkQzwWPrmTC0Zrg6jN2Pe9KEWqiU9G 9Bmg== X-Forwarded-Encrypted: i=1; AJvYcCWqbNdY+DfQ1x3AEFWiDEwWpkWiqUMDcac8/FNr2JS8yMH/56/jyTlMMGVO1RnluYsG8NUTc2ldV/EMZO4Mva38Re8/CB7r1g== X-Gm-Message-State: AOJu0Yz66EEOWN5I0+ElKH8BKNzgZHv89C4GhzXQ4poX+ufUqfWDF+pR 9dbWrEJuxIlFvQXiqRNreO486HfiJd69aWMYR/yi+LowHj8zQMHDIUk/F5MYcPes3KuHOatEixo FJe5q9huEqvSOQecqdabC7+SzlZA= X-Google-Smtp-Source: AGHT+IH+x7NnL/s8y6jE5GNpuyzWbYAS2rjNQEZsrDfLb4ZHOrFt/82I7L6SLliEKR6nfspqWoF7CVy9qljnYFDWtbc= X-Received: by 2002:a17:90a:c685:b0:2b2:9fe9:d9a6 with SMTP id 98e67ed59e1d1-2b6166c3024mr3149032a91.24.1715184491058; Wed, 08 May 2024 09:08:11 -0700 (PDT) MIME-Version: 1.0 References: <20230723010645.1622083-1-apinski@marvell.com> In-Reply-To: From: Andrew Pinski Date: Wed, 8 May 2024 09:07:59 -0700 Message-ID: Subject: Re: [PATCH 1/2] Fix PR 110066: crash with -pg -static on riscv To: Kito Cheng Cc: Andrew Pinski , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jul 22, 2023 at 8:36=E2=80=AFPM Kito Cheng via Gcc-patches wrote: > > OK for trunk, thanks:) I have now backported it to 13 branch. Thanks, Andrew > > Andrew Pinski via Gcc-patches =E6=96=BC 2023=E5= =B9=B47=E6=9C=8823=E6=97=A5 =E9=80=B1=E6=97=A5 > 09:07 =E5=AF=AB=E9=81=93=EF=BC=9A > > > The problem -fasynchronous-unwind-tables is on by default for riscv lin= ux > > We need turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ > > point > > to .eh_frame data from crtbeginT.o instead of the user-defined object > > during static linking. > > > > This turns it off. > > > > OK? > > > > libgcc/ChangeLog: > > > > * config.host (riscv*-*-linux*): Add t-crtstuff to tmake_file. > > (riscv*-*-freebsd*): Likewise. > > * config/riscv/t-crtstuff: New file. > > --- > > libgcc/config.host | 4 ++-- > > libgcc/config/riscv/t-crtstuff | 5 +++++ > > 2 files changed, 7 insertions(+), 2 deletions(-) > > create mode 100644 libgcc/config/riscv/t-crtstuff > > > > diff --git a/libgcc/config.host b/libgcc/config.host > > index 9d7212028d0..c94d69d84b7 100644 > > --- a/libgcc/config.host > > +++ b/libgcc/config.host > > @@ -1304,12 +1304,12 @@ pru-*-*) > > tm_file=3D"$tm_file pru/pru-abi.h" > > ;; > > riscv*-*-linux*) > > - tmake_file=3D"${tmake_file} riscv/t-softfp${host_address} t-sof= tfp > > riscv/t-elf riscv/t-elf${host_address} t-slibgcc-libgcc" > > + tmake_file=3D"${tmake_file} riscv/t-crtstuff > > riscv/t-softfp${host_address} t-softfp riscv/t-elf > > riscv/t-elf${host_address} t-slibgcc-libgcc" > > extra_parts=3D"$extra_parts crtbegin.o crtend.o crti.o crtn.o > > crtendS.o crtbeginT.o" > > md_unwind_header=3Driscv/linux-unwind.h > > ;; > > riscv*-*-freebsd*) > > - tmake_file=3D"${tmake_file} riscv/t-softfp${host_address} t-sof= tfp > > riscv/t-elf riscv/t-elf${host_address} t-slibgcc-libgcc" > > + tmake_file=3D"${tmake_file} riscv/t-crtstuff > > riscv/t-softfp${host_address} t-softfp riscv/t-elf > > riscv/t-elf${host_address} t-slibgcc-libgcc" > > extra_parts=3D"$extra_parts crtbegin.o crtend.o crti.o crtn.o > > crtendS.o crtbeginT.o" > > ;; > > riscv*-*-*) > > diff --git a/libgcc/config/riscv/t-crtstuff > > b/libgcc/config/riscv/t-crtstuff > > new file mode 100644 > > index 00000000000..685d11b3e66 > > --- /dev/null > > +++ b/libgcc/config/riscv/t-crtstuff > > @@ -0,0 +1,5 @@ > > +# -fasynchronous-unwind-tables -funwind-tables is on by default for ri= scv > > linux > > +# We turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ p= oint > > +# to .eh_frame data from crtbeginT.o instead of the user-defined objec= t > > +# during static linking. > > +CRTSTUFF_T_CFLAGS +=3D -fno-asynchronous-unwind-tables -fno-unwind-tab= les > > -- > > 2.39.1 > > > >