From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-383584-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 13112 invoked by alias); 11 Nov 2014 12:08:30 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 13102 invoked by uid 89); 11 Nov 2014 12:08:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f42.google.com
Received: from mail-la0-f42.google.com (HELO mail-la0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 11 Nov 2014 12:08:28 +0000
Received: by mail-la0-f42.google.com with SMTP id gq15so9476824lab.29        for <gcc-patches@gcc.gnu.org>; Tue, 11 Nov 2014 04:08:24 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.112.135.197 with SMTP id pu5mr35778881lbb.22.1415707704717; Tue, 11 Nov 2014 04:08:24 -0800 (PST)
Received: by 10.25.30.7 with HTTP; Tue, 11 Nov 2014 04:08:24 -0800 (PST)
In-Reply-To: <alpine.DEB.2.11.1411111019390.1640@laptop-mg.saclay.inria.fr>
References: <CAFULd4YfYZSNpwXjAD-e5Z+p-yMvO0Msji36X3nWsjdzdwMDkQ@mail.gmail.com>	<20141111081157.GY5026@tucnak.redhat.com>	<alpine.DEB.2.11.1411111019390.1640@laptop-mg.saclay.inria.fr>
Date: Tue, 11 Nov 2014 12:11:00 -0000
Message-ID: <CA+=Sn1k2hF5QotNh+srL3pNvCkTnQjVPX9657Bv6Ju+CujPyww@mail.gmail.com>
Subject: Re: [PATCH] c++ify sreal
From: Andrew Pinski <pinskia@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>, 	Richard Biener <richard.guenther@gmail.com>, Trevor Saunders <tsaunders@mozilla.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00963.txt.bz2

On Tue, Nov 11, 2014 at 1:23 AM, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Tue, 11 Nov 2014, Jakub Jelinek wrote:
>
>> On Tue, Nov 11, 2014 at 08:51:41AM +0100, Uros Bizjak wrote:
>>>
>>> Hello!
>>>
>>>>>> do $subject, and cleanup for always 64 bit hwi.
>>>>>>
>>>>>>
>>>>>> bootstrapped + regtested x86_64-unknown-linux-gnu, ok?
>>>>>
>>>>>
>>>>> Ok.  Can you please replace remaining HOST_WIDE_INT
>>>>> vestiges in there with [u]int64_t please?
>>>>
>>>>
>>>>
>>>> This patch breaks the build on debian 6.0:
>>>>
>>>> ../../gcc/sreal.c: In member function =C4=81int64_t sreal::to_int() co=
nst=C4=81:
>>>> ../../gcc/sreal.c:159: error: =C4=81INT64_MAX=C4=81 was not declared i=
n this scope
>>>
>>>
>>> Index: system.h
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> --- system.h    (revision 217338)
>>> +++ system.h    (working copy)
>>> @@ -27,6 +27,7 @@
>>>     event inttypes.h gets pulled in by another header it is already
>>>     defined.  */
>>>  #define __STDC_FORMAT_MACROS
>>> +#define __STDC_LIMIT_MACROS
>>>
>>>  /* We must include stdarg.h before stdio.h.  */
>>>  #include <stdarg.h>
>>
>>
>> Still, I don't believe it will be portable everywhere.
>> Can't you use
>> INTTYPE_MAXIMUM (int64_t) instead of INT64_MAX?  We already use that
>> in GCC...
>
>
> We could also start using the standard C++ mechanism (numeric_limits).

Except int64_t does not have to be defined for a C++ implementation.

Thanks,
Andrew

>
> (nothing wrong with INTTYPE_MAXIMUM, just an alternative)
>
> --
> Marc Glisse