From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id EBE1B3858D20 for ; Thu, 10 Nov 2022 16:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBE1B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 6so2298739pgm.6 for ; Thu, 10 Nov 2022 08:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U11BeJQQPpWId4lO0U6JRZB9DuctcdawkjJQqVYemK8=; b=Zdk8G7Qyq5W4ea0qx17HAh1UHJ3W8zDBY/Gf8uysglhzr19LPR72yoGsJkiu+EymtT hsbIltzaZolHg8K8l2bVcnJdmTnIDnEvW6QKmVdKcQvhH94RfF3FdFJ3z4Yo2I6OCRu9 k4v7Ya33WvrEr5Wn/XgvLcIGuOMe+d85LnUSyrGY43LIj3lDGDUf+ZSl+19lkAJ8WDen S30VLpLnU8TNwC08NBnexDrjngQrzIFk3GSEXAHsDYrBQjnma4lCDBm9D1uhIurV9pyY 67joKizG2LHAS3ybVe7K9QtvRsW3ne3684BT6c2C1280PfmsP5QdXd/QphWPRBFPJKox VIIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U11BeJQQPpWId4lO0U6JRZB9DuctcdawkjJQqVYemK8=; b=3p2RcysnFVoszCdZnrg2zE8WPPjnASm68ENGLBuwo/9L+1mmGpJGFg6a/buGOdBul+ n5EGFE/9mS94/oXsjOBOvPPrdaHot2GQ1teKER7FvSq17hX/POV+mmFJfY+8zNnmFIkw /LJERP+4ME1PE6JhGtT1KbLExptRC0Aja754ez4VRZ0Syn7IvAKGKBj+Myt7Zpt6HEsc TKjj+aZ8twLS1Lf6Df9QQ+z5AXBf/HNbAIbGJCVPscDHsEyLlAAw/j7Cj2VJ/Jrq449W 1R+nWqjtuAQyjg5xGUbjEfBH4d2Nsg9mIBrXf5S3KlmT3sf/Ffu8JUzwOAVcQ0KjA61V anoQ== X-Gm-Message-State: ACrzQf1XpksFe2LkbHJpA7YweWXjE9ObV+EhXuTrTdQy7pQAvKSk+py+ Ck7YTmHq6Oqm1PVb3T4Wt9w6w6IBmKZ/HkFetoA= X-Google-Smtp-Source: AMsMyM4NwgxKrMm8ZN1ETRqtO0vJhi2HpYumDAeD/4KxN3G/bMCAmDcvesHBPbPjUSq/itLFTwVd+wGVHGLXu1NtDas= X-Received: by 2002:a63:66c3:0:b0:470:8fd:7bae with SMTP id a186-20020a6366c3000000b0047008fd7baemr37642769pgc.277.1668097370839; Thu, 10 Nov 2022 08:22:50 -0800 (PST) MIME-Version: 1.0 References: <1668042934-1377-1-git-send-email-apinski@marvell.com> In-Reply-To: From: Andrew Pinski Date: Thu, 10 Nov 2022 08:22:37 -0800 Message-ID: Subject: Re: [PATCH] Remove SLOW_SHORT_ACCESS from target headers To: Richard Biener Cc: apinski@marvell.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 10, 2022 at 12:47 AM Richard Biener wrote: > > On Thu, Nov 10, 2022 at 2:21 AM Andrew Pinski via Gcc-patches > wrote: > > > > On Wed, Nov 9, 2022 at 5:16 PM apinski--- via Gcc-patches > > wrote: > > > > > > From: Andrew Pinski > > > > > > SLOW_SHORT_ACCESS is defined in bfin and i386 target > > > headers but the target macro is not used elsewhere. > > > So let's remove it from those two headers and poison it. > > > > Just to add, this target macro was defined in GCC 2.8.0 in i386.h but > > not used in any other sources. > > apinski@xeond:~/src/upstream-gcc/gcc$ git grep SLOW_SHORT_ACCESS > > releases/gcc-2.8.0 > > releases/gcc-2.8.0:gcc/config/i386/i386.h:#define SLOW_SHORT_ACCESS 0 > > > > So it looks like it was never used for the last 24+ years and it is > > time to finally remove it. > > OK. I notice you didn't remove any documentation so it was also undocumented? Yes it was never documented as far as I can tell. It was just ever defined in those 2 headers. Also it looked like bfin copied it from the i386 header too. The define has been in the i386 header since the GCC 2.8.0 release and not used anywhere else even at that point; searching git earlier becomes harder and there was no reference to it in ChangeLogs either. Thanks, Andrew > > Thanks, > Richard. > > > Thanks, > > Andrew Pinski > > > > > > > > > > OK? Built x86_64-linux-gnu and bfin-elf. > > > > > > gcc/ChangeLog: > > > > > > * config/bfin/bfin.h (SLOW_SHORT_ACCESS): Delete. > > > * config/i386/i386.h (SLOW_SHORT_ACCESS): Delete. > > > * system.h: Poison SLOW_SHORT_ACCESS > > > --- > > > gcc/config/bfin/bfin.h | 1 - > > > gcc/config/i386/i386.h | 3 --- > > > gcc/system.h | 2 +- > > > 3 files changed, 1 insertion(+), 5 deletions(-) > > > > > > diff --git a/gcc/config/bfin/bfin.h b/gcc/config/bfin/bfin.h > > > index 4e7753038a8..1d75c655df8 100644 > > > --- a/gcc/config/bfin/bfin.h > > > +++ b/gcc/config/bfin/bfin.h > > > @@ -810,7 +810,6 @@ typedef struct { > > > subsequent accesses occur to other fields in the same word of the > > > structure, but to different bytes. */ > > > #define SLOW_BYTE_ACCESS 0 > > > -#define SLOW_SHORT_ACCESS 0 > > > > > > /* Define this if most significant bit is lowest numbered > > > in instructions that operate on numbered bit-fields. */ > > > diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h > > > index b32db8da109..a5ad9f387f7 100644 > > > --- a/gcc/config/i386/i386.h > > > +++ b/gcc/config/i386/i386.h > > > @@ -1933,9 +1933,6 @@ do { \ > > > > > > #define SLOW_BYTE_ACCESS 0 > > > > > > -/* Nonzero if access to memory by shorts is slow and undesirable. */ > > > -#define SLOW_SHORT_ACCESS 0 > > > - > > > /* Define this macro if it is as good or better to call a constant > > > function address than to call an address kept in a register. > > > > > > diff --git a/gcc/system.h b/gcc/system.h > > > index c192b6c3ce7..de9c5c0d2ef 100644 > > > --- a/gcc/system.h > > > +++ b/gcc/system.h > > > @@ -1075,7 +1075,7 @@ extern void fancy_abort (const char *, int, const char *) > > > EH_FRAME_IN_DATA_SECTION TARGET_FLT_EVAL_METHOD_NON_DEFAULT \ > > > JCR_SECTION_NAME TARGET_USE_JCR_SECTION SDB_DEBUGGING_INFO \ > > > SDB_DEBUG NO_IMPLICIT_EXTERN_C NOTICE_UPDATE_CC \ > > > - CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS > > > + CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS SLOW_SHORT_ACCESS > > > > > > /* Hooks that are no longer used. */ > > > #pragma GCC poison LANG_HOOKS_FUNCTION_MARK LANG_HOOKS_FUNCTION_FREE \ > > > -- > > > 2.17.1 > > >