From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 7BC013858CDB for ; Mon, 18 Mar 2024 23:22:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BC013858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BC013858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710804138; cv=none; b=GJ/xP0NNbsiSxvVpRZ0h1I6DA//37ifmuA5sZCfd3/PZvVT3+RrObv32M0T7cUbqsyC3h4/Za+xU34RvBHaikp572aW6gyOnYLoO0NsfxtCL+NeqJsA0dr+Ycs1KHOFIJHCt5ghiMJ7ebEzOjh8i+X513MH5IMDAjYumzD3MgzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710804138; c=relaxed/simple; bh=vDrCWrl3M8Q1QxhORtsKNmQU6ZvT95BgbSJ9SgNP7hc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Z8P+0llZSPS8mQZpdl1Zb+bNryItrcdefKmcOoNgmigGKgFgxwaY7VFH7XMfr5F+ot/qqo6jJYxeA8mlsy/GkAp9zC/7MbhR0aoAwGjPquM9pqqvAuB5Zq+nN0tlVA2TAl34c3b6fsC8wZ/2vzu8jhL0DNxENVfwWBZnI0IgL5g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-29f6f8614c8so1669258a91.0 for ; Mon, 18 Mar 2024 16:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710804135; x=1711408935; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vDrCWrl3M8Q1QxhORtsKNmQU6ZvT95BgbSJ9SgNP7hc=; b=bX2cA57E3BGSR+3GXg73aC4H7+3yrrAB1IMJ45UEylSLbsRHxFm3EruLqXsD/KkzQz ahcmXzjsNq7iChk2RUndxMd6MVx5wLnYmJgUP8mQJ4Ot8K3ydeshYN4G4HAuOQ3dvky1 iVDQ2dCDmJUqIFGcsiil0o8DSrzhQdjE1hu537dbc9ifcFrPDYXH9GDBEvNxjWPIia0d j9brcsbBEE7PO5KTMZMhAveIcMRyduesLNpuVCyEDmq106XflC9T92xuZ23hNk9Y7bPq zDdMT/hIW1MvfWYffnyvey384y67Tl/T7V2XfOtfMfXXwegZvp943DCUhxw44Cjrp6Xx 1UDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710804135; x=1711408935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vDrCWrl3M8Q1QxhORtsKNmQU6ZvT95BgbSJ9SgNP7hc=; b=vXcoIjcJKqly4aFnfLyJt8ZCAj0Sr5ouODLd7aAa6+07ajH9OpU6EEaN31R07RQa9E pOXGsh+Fv3A3gfC9OfJHLPiUWwck3jfSnz+Tows38CjnsqFQ/3ZC6NYR/KsHs8jEtzkt iHsWGiCaNjewYpoQxycxdRChM2sk7PNH9eeUBtnfxfJ17ii0Y2CwSN60Uwig7GxpK1R2 P7RY/llqSqp9u7fRUgBZhWXfEojy3bWXiHRWRqNEYvdCUr96h+MnqEpvPo4+fW8W0GZG JmwsYfsgwcS4atjXo63nDKImEvWaFXjp9rp341W9Ct50I9jvc5w+aMpSerQdfXtw7bBb w34g== X-Forwarded-Encrypted: i=1; AJvYcCVKIbb4GKAFhCegc6+geXQgVzPmXxNmpkTeEfi/hQ79iiqJEFegvvCkYdb6UiGXRjXx3CF2PxzalJGeZuOP8kXo5uqkQ60RcA== X-Gm-Message-State: AOJu0YyL5vpBQ+CMem8+Ry56Hx1MwZXe4u4/sVSqcHyU0NB6Dq6PzFX3 rQCrs60MDOubjlVVDp+igOhOIcLb2DJYj9qS9lPTzdyAtPdte+/2cCx8IL0H/pa+CWnZKEgca8n e15/lJGj8SpXwOkQbLxlIZwKMVz0= X-Google-Smtp-Source: AGHT+IGJNyHFFI7w+mW8/L1cplEqG2DqcbQT5NWivZBjoqm5cr7tVEWq/RQks1RxHKF2b20lSWO5cd44gsSgBxV7Ers= X-Received: by 2002:a17:90a:d3d5:b0:29f:c9eb:34fd with SMTP id d21-20020a17090ad3d500b0029fc9eb34fdmr1014408pjw.17.1710804135297; Mon, 18 Mar 2024 16:22:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Mon, 18 Mar 2024 16:22:03 -0700 Message-ID: Subject: Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target To: Fangrui Song Cc: Evgeny Karpov , "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" , "Richard Earnshaw (lists)" , "christophe.lyon@linaro.org" , "Andrew Pinski (QUIC)" , Maxim Kuvyrkov , Radek Barton , =?UTF-8?Q?Martin_Storsj=C3=B6?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 18, 2024 at 3:59=E2=80=AFPM Fangrui Song w= rote: > > On Mon, Mar 18, 2024 at 3:10=E2=80=AFPM Evgeny Karpov > wrote: > > > > > > Monday, March 18, 2024 2:34 PM > > Christophe Lyon wrote: > > > > > I had a look at the v2 series, and besides a minor comment patch #8, = ISTM than > > > all the comments your received about v1 have been addressed, indeed. > > > > > > > While unit testing for the x86_64-w64-mingw32 target is still in > > > > progress, the first 4 patches do not obviously change other targets= , > > > > including aarch64-linux-gnu. > > > > Could they be merged once stage 1 starts, or could it be done even > > > > now? > > > > > > What would be the benefit of committing only the first 4 patches? > > > (whether now or when stage 1 reopens) > > > > > > Thanks, > > > > > > Christophe > > > > Work on obtaining regression test results for x86_x64-w64-mingw32 was s= till in progress at that moment. > > The first 4 patches do not obviously change other targets, so it was sa= fe to merge them. > > Now, based on the regression test results https://gcc.gnu.org/pipermail= /gcc-patches/2024-March/647967.html, > > it appears safe to merge the entire series. > > > > Regards, > > Evgeny > > LLVM has had an aarch64 mingw ABI support for a long time. Does this > patch series introduce a different ABI? > If yes, do you have a summary? > > Does the patch need any adaptation on the LLVM side, or should a > different target triple be picked? > I have always been wondering what "32" in "x86_x64-w64-mingw32" means. It was always mingw32, it comes from win32 API interface which dates to when windows also a 16bit API too. The API has always been named win32 and Microsoft didn't rename it to win64 though. Thanks, Andrew Pinski > > https://github.com/llvm/llvm-project/pull/78908 even introduced the > first use of the triple "arm64ec-w64-mingw32" into llvm-project. > > > -- > =E5=AE=8B=E6=96=B9=E7=9D=BF