From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id E67C33858D1E for ; Mon, 26 Jun 2023 16:14:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E67C33858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-52cb8e5e9f5so2251123a12.0 for ; Mon, 26 Jun 2023 09:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687796044; x=1690388044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zbfBPcsO6rowyCTEV4hicwhAe4dQ8oIsWn3dAAYYrpg=; b=J9I8DtYvd6T/aEgrJZLaoUJK9HNV/ykwdiXVQ1c7wftLaJW9OawSBrIL361yENLbxj 9sS7yLeO8fDI0qGaLsCUQKKtBkWdwYhjL7gtPLX9bAsPn6+jw0qZlF3y0L+YPDhIO8Gf EUKPuEyd46iJIxBNxLSBA81JJQEP1BTOsux3Qk64m41pjha3obFNPQXemV9BvD32oIzd NnFzsfdJ4CO12MChYqHrtHYX6r5orbj5f35E5MngoMyyOoBcqYm2PIpgu4Km870+1NRa 2K19nUcoNNKRcDFdwZdaCSreQitMekq+77ggujYSqHKLGvtjTSAMxw0kQst6nYP44FSU 2c5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687796044; x=1690388044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbfBPcsO6rowyCTEV4hicwhAe4dQ8oIsWn3dAAYYrpg=; b=YMeBassPt/AQLzclZTXdgi7cG0XrxBxeJA7a+Ny96LzE44X6zE/xcPRJsC//s6cO5R FqHjBAF3Jjym1bjzwu9r0KybGlXL4oKpkih0lnrll2/DQ9WoXfVffHUQrjQkn8HE+fPv yEWh4Y9CBmkhdtUozbCGQptSlVRr4eUGNY4lTyvXNC0xzsJsRMaKU5OcqktPlYSXdwki lRZ28ATpMxH4z7+OzDTq0+t27Yy1PMMaCTqFIFa9tokOPyM05c/mrV00fZAkdFYA9N2V DtokdHRXWU1UtT+s3WsjleCgk9Ff6pcSwjt/S8JK16rQxqzAzQ0J2iQP2+63BfH82o0X Xo9w== X-Gm-Message-State: AC+VfDyGgryhXh+BL5MHT8+4861GMo0637BhgUD59FKhlVehZhGjH1bl oWAGIg7mbC6T/0GkBBhCBt8/ufrb+dDDfOb2fo4= X-Google-Smtp-Source: ACHHUZ72gk9oKJ1kgSMQ52LraVs7I+BmSp3a9iz+T39qgDBOjRVJrIpqsHR8uEPwk9DNQatkccUqZOFOHEPBIMRR2yw= X-Received: by 2002:a17:90a:c905:b0:25e:a36c:46ef with SMTP id v5-20020a17090ac90500b0025ea36c46efmr40397558pjt.13.1687796044069; Mon, 26 Jun 2023 09:14:04 -0700 (PDT) MIME-Version: 1.0 References: <20230505151719.1031737-1-apinski@marvell.com> <20230626055827.t57twu4yykagzdpt@lug-owl.de> In-Reply-To: <20230626055827.t57twu4yykagzdpt@lug-owl.de> From: Andrew Pinski Date: Mon, 26 Jun 2023 09:13:51 -0700 Message-ID: Subject: Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist To: Jan-Benedict Glaw Cc: Andrew Pinski , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jun 25, 2023 at 10:59=E2=80=AFPM Jan-Benedict Glaw wrote: > > Hi Andrew, > > On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches wrote: > > While looking into a different issue, I noticed that it > > would take until the second forwprop pass to do some > > forward proping and it was because the ssa name was > > used more than once but the second statement was > > "dead" and we don't remove that until much later. > [...] > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > Since this patch, I see a bit of fallout building the Linux kernel > using the adder875_defconfig: > > # CC arch/powerpc/kernel/ptrace/ptrace-view.o > powerpc-linux-gcc -Wp,-MMD,arch/powerpc/kernel/ptrace/.ptrace-view.o.d = -nostdinc -I./arch/powerpc/include -I./arch/powerpc/include/generated -I./= include -I./arch/powerpc/include/uapi -I./arch/powerpc/include/generated/ua= pi -I./include/uapi -I./include/generated/uapi -include ./include/linux/com= piler-version.h -include ./include/linux/kconfig.h -include ./include/linux= /compiler_types.h -D__KERNEL__ -I ./arch/powerpc -fmacro-prefix-map=3D./=3D= -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-trigraphs -fno-strict-alias= ing -fno-common -fshort-wchar -fno-PIE -Werror=3Dimplicit-function-declarat= ion -Werror=3Dimplicit-int -Werror=3Dreturn-type -Wno-format-security -funs= igned-char -std=3Dgnu11 -mbig-endian -m32 -msoft-float -pipe -ffixed-r2 -mm= ultiple -mno-readonly-in-sdata -mcpu=3D860 -mno-prefixed -mno-pcrel -mno-al= tivec -mno-vsx -mno-mma -fno-asynchronous-unwind-tables -mno-string -mbig-e= ndian -mstack-protector-guard=3Dtls -mstack-protector-guard-reg=3Dr2 -fno-d= elete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-fo= rmat-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races= -Wframe-larger-than=3D1024 -fstack-protector-strong -Wno-main -Wno-unused-= but-set-variable -Wno-unused-const-variable -Wno-dangling-pointer -fomit-fr= ame-pointer -ftrivial-auto-var-init=3Dzero -fno-stack-clash-protection -Wde= claration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno= -stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninit= ialized -Wno-array-bounds -Wno-alloc-size-larger-than -Wimplicit-fallthroug= h=3D5 -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=3Ddate= -time -Werror=3Dincompatible-pointer-types -Werror=3Ddesignated-init -Wno-p= acked-not-aligned -g -mstack-protector-guard-offset=3D544 -Werror -DUTS_MAC= HINE=3D'"ppc"' -DKBUILD_MODFILE=3D'"arch/powerpc/kernel/ptrace/ptrace-vi= ew"' -DKBUILD_BASENAME=3D'"ptrace_view"' -DKBUILD_MODNAME=3D'"ptrace_view"'= -D__KBUILD_MODNAME=3Dkmod_ptrace_view -c -o arch/powerpc/kernel/ptrace/ptr= ace-view.o arch/powerpc/kernel/ptrace/ptrace-view.c > during GIMPLE pass: pre > arch/powerpc/kernel/ptrace/ptrace-view.c: In function 'gpr32_set_common': > arch/powerpc/kernel/ptrace/ptrace-view.c:649:5: internal compiler error: = in gimple_redirect_edge_and_branch, at tree-cfg.cc:6262 > 649 | int gpr32_set_common(struct task_struct *target, > | ^~~~~~~~~~~~~~~~ > 0x1a562a6 internal_error(char const*, ...) > ???:0 > 0x826ea1 fancy_abort(char const*, int, char const*) > ???:0 > 0x9b77c9 redirect_edge_and_branch(edge_def*, basic_block_def*) > ???:0 > 0x9b7e43 split_edge(edge_def*) > ???:0 > 0xee1cc7 split_critical_edges(bool) > ???:0 > Please submit a full bug report, with preprocessed source (by using -frep= ort-bug). > Please include the complete backtrace with any bug report. > See for instructions. > make[4]: *** [scripts/Makefile.build:252: arch/powerpc/kernel/ptrace/ptra= ce-view.o] Error 1 > make[3]: *** [scripts/Makefile.build:494: arch/powerpc/kernel/ptrace] Err= or 2 > make[2]: *** [scripts/Makefile.build:494: arch/powerpc/kernel] Error 2 > make[1]: *** [scripts/Makefile.build:494: arch/powerpc] Error 2 > make: *** [Makefile:2026: .] Error 2 Can you file a bug (https://gcc.gnu.org/bugzilla/) with the preprocessed source (which -freport-bug will provide). In the meantime I will try to reproduce it and see what is going on. Thanks, Andrew > > > (Full log at http://toolchain.lug-owl.de/laminar/jobs/linux-powerpc-adder= 875_defconfig/100) > > Thanks, > Jan-Benedict > > --