public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] fixed testcase riscv/pr103302.c
@ 2021-12-23  7:36 shihua
  2021-12-23  7:41 ` Andrew Pinski
  0 siblings, 1 reply; 3+ messages in thread
From: shihua @ 2021-12-23  7:36 UTC (permalink / raw)
  To: gcc-patches
  Cc: jim.wilson.gcc, kito.cheng, palmer, andrew, cmuellner,
	philipp.tomsich, yulong, sinan, lazyparser, jiawei, LiaoShihua

From: LiaoShihua <shihua@iscas.ac.cn>

        because riscv32 not support __int128, so skip if -march=rv32*.

gcc/testsuite\ChangeLog:
        * gcc.target/riscv/pr103302.c: skip if -march=rv32*
---
 gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
index 822c4087416..2cfb12498a2 100644
--- a/gcc/testsuite/gcc.target/riscv/pr103302.c
+++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
@@ -1,4 +1,5 @@
 /* { dg-do run } */
+/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */
 /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
 
 typedef unsigned char u8;
-- 
2.31.1.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fixed testcase riscv/pr103302.c
  2021-12-23  7:36 [PATCH] fixed testcase riscv/pr103302.c shihua
@ 2021-12-23  7:41 ` Andrew Pinski
  2021-12-27  4:05   ` Kito Cheng
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2021-12-23  7:41 UTC (permalink / raw)
  To: shihua
  Cc: GCC Patches, cmuellner, Andrew Waterman, sinan, Kito Cheng,
	Dr. Philipp Tomsich, jiawei, yulong

On Wed, Dec 22, 2021 at 11:37 PM <shihua@iscas.ac.cn> wrote:
>
> From: LiaoShihua <shihua@iscas.ac.cn>
>
>         because riscv32 not support __int128, so skip if -march=rv32*.
>
> gcc/testsuite\ChangeLog:
>         * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> ---
>  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
> index 822c4087416..2cfb12498a2 100644
> --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */

Better fix:
/* { dg-do run { target int128 } } */

Thanks,
Andrew Pinski

>  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
>
>  typedef unsigned char u8;
> --
> 2.31.1.windows.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fixed testcase riscv/pr103302.c
  2021-12-23  7:41 ` Andrew Pinski
@ 2021-12-27  4:05   ` Kito Cheng
  0 siblings, 0 replies; 3+ messages in thread
From: Kito Cheng @ 2021-12-27  4:05 UTC (permalink / raw)
  To: Andrew Pinski
  Cc: shihua, Christoph Muellner, Andrew Waterman, Sinan Lin,
	Dr. Philipp Tomsich, jiawei, GCC Patches, yulong

Hi ShiHua:

Thanks for the fix, committed with Andrew's comment and minor fix for
commit comment.

On Thu, Dec 23, 2021 at 3:41 PM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Wed, Dec 22, 2021 at 11:37 PM <shihua@iscas.ac.cn> wrote:
> >
> > From: LiaoShihua <shihua@iscas.ac.cn>
> >
> >         because riscv32 not support __int128, so skip if -march=rv32*.
> >
> > gcc/testsuite\ChangeLog:
> >         * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> > ---
> >  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > index 822c4087416..2cfb12498a2 100644
> > --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> > +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > @@ -1,4 +1,5 @@
> >  /* { dg-do run } */
> > +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */
>
> Better fix:
> /* { dg-do run { target int128 } } */
>
> Thanks,
> Andrew Pinski
>
> >  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
> >
> >  typedef unsigned char u8;
> > --
> > 2.31.1.windows.1
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-27  4:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23  7:36 [PATCH] fixed testcase riscv/pr103302.c shihua
2021-12-23  7:41 ` Andrew Pinski
2021-12-27  4:05   ` Kito Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).