From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pinskia@gmail.com>
Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com
 [IPv6:2607:f8b0:4864:20::e2c])
 by sourceware.org (Postfix) with ESMTPS id 960CC3858417
 for <gcc-patches@gcc.gnu.org>; Sun, 30 Jan 2022 02:38:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 960CC3858417
Received: by mail-vs1-xe2c.google.com with SMTP id az20so7732925vsb.8
 for <gcc-patches@gcc.gnu.org>; Sat, 29 Jan 2022 18:38:24 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=9oDuXI5xHMzUXzEI47XrmhL9a0c4VP/Gy2fPKQ2d2tc=;
 b=i4i2H1cqG+ObI5aWN5sun62NaKxzyXNv24K9rYwsjpsE00G4y+3wPlWIMcPICV+xCA
 paQhiFdjhxIA7NCo+mAhB2Vcbddchg/R8gUalS5BnLN3R+ISjN1IKpJYt6saxiIhW1XR
 hNh7nA/22DXiYJVytdbeMklXv+VgpznlX8SUWSCMWYMek2ouEV9Y1L+HrGVYA3hlhl1q
 vRe0daL/cFpst+7P4YJTPiaDXUawqAMm1LCG/XRCwcCQritu5ooWz3K3gFRn9w1UTJGk
 EPlKgzDfzcLngj07MT8KJYdAEKxOuymGieLS4Q3/hiiZm5SqHywztl6bq+IqSdBYhk7Y
 wuUg==
X-Gm-Message-State: AOAM533BkQqt+LaF72XWpT36l023Ok8x29zmW6jGB5pp4fj76RW7/09b
 555mn8RLvlNZyRmUc3vCQHL4V19SYiIlTW+mxOo=
X-Google-Smtp-Source: ABdhPJzG6RE4zmlMMboahgyO92weaw5bq6H4FHib9JGvRDhvRUsxw8sEWyUs9xqBqJOecHn3TxjCBoA5qW12BQJ/JUc=
X-Received: by 2002:a67:e096:: with SMTP id f22mr6324593vsl.8.1643510304152;
 Sat, 29 Jan 2022 18:38:24 -0800 (PST)
MIME-Version: 1.0
References: <CALHvHFUuCO13CFatCQdJArg9j7fhSpjGp8Yvx2ws3bPb+d8Teg@mail.gmail.com>
 <ef562416-3002-9dd9-3a73-1775fb25223f@gmail.com>
 <20220129162334.GV2646553@tucnak>
 <f6d22ace-eac2-80d9-f9f3-afb060ebafac@gmail.com>
 <CALHvHFXZZHmfS4gcAavad87A3L7BsvcVJLem-DV-5qHPw3TTTA@mail.gmail.com>
In-Reply-To: <CALHvHFXZZHmfS4gcAavad87A3L7BsvcVJLem-DV-5qHPw3TTTA@mail.gmail.com>
From: Andrew Pinski <pinskia@gmail.com>
Date: Sat, 29 Jan 2022 18:38:11 -0800
Message-ID: <CA+=Sn1kO4D02ztVkFed44WRO22MgA-tvhGKtcuyY+VY+BQkTbg@mail.gmail.com>
Subject: Re: [PATCH] match.pd: Fix up 1 / X for unsigned X optimization
 [PR104280]
To: Zhao Wei Liew <zhaoweiliew@gmail.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>, Jakub Jelinek <jakub@redhat.com>, 
 GCC Patches <gcc-patches@gcc.gnu.org>, Richard Biener <rguenther@suse.de>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Jan 2022 02:38:26 -0000

On Sat, Jan 29, 2022 at 6:30 PM Zhao Wei Liew via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Sincere apologies for the issues. I wasn't aware of the need for a cast but
> after reading the PRs, I understand that now. On the other hand, the
> incorrect test case was simply a major oversight on my part.
>
> I'll be sure to be more careful next time.

Well I think gimple-match should have caught the cast issue really. I
filed https://gcc.gnu.org/PR104286 for that. I hope to submit a patch
for stage 1 to catch that so it will be harder to happen in the first
place.

Thanks,
Andrew

>
> Thanks for the fixes!