From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83692 invoked by alias); 5 Apr 2017 16:17:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83672 invoked by uid 89); 5 Apr 2017 16:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Envelope-From:sk:Andrew. X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Received: from mail-bl2nam02on0058.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) (104.47.38.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 16:17:24 +0000 Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=cavium.com; Received: from mail-yw0-f180.google.com (209.85.161.180) by SN2PR07MB2623.namprd07.prod.outlook.com (10.167.15.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Wed, 5 Apr 2017 16:17:23 +0000 Received: by mail-yw0-f180.google.com with SMTP id p77so8390529ywg.1 for ; Wed, 05 Apr 2017 09:17:23 -0700 (PDT) X-Gm-Message-State: AFeK/H0xj38ZxRouUsvp7UUv16lrSpSYmXYyW/IfXYwag1dfAueKU22hRmr8lUfGsvzPcnw8kpxvIUJt9sdJWA== X-Received: by 10.129.85.20 with SMTP id j20mr18890986ywb.287.1491409040244; Wed, 05 Apr 2017 09:17:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.174.101 with HTTP; Wed, 5 Apr 2017 09:17:19 -0700 (PDT) In-Reply-To: References: From: Andrew Pinski Date: Wed, 05 Apr 2017 16:17:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH][AArch64] Enable AUTOPREFETCHER_WEAK with -mcpu=generic To: Wilco Dijkstra Cc: GCC Patches , nd , James Greenhalgh , "Andrew.pinski@cavium.com" , Evandro Menezes , "jim.wilson@linaro.org" Content-Type: text/plain; charset=UTF-8 X-ClientProxiedBy: BN6PR20CA0026.namprd20.prod.outlook.com (10.171.173.12) To SN2PR07MB2623.namprd07.prod.outlook.com (10.167.15.135) X-MS-Office365-Filtering-Correlation-Id: 257f282d-313c-40ac-7868-08d47c3f3e24 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:SN2PR07MB2623; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2623;3:v4bhefkt2+aGry72ZkAec0oSTWEC8MhLRqUMuyUGtnqrBdURpoA54DnAPB/BeotfcdpU7ypQx7NiFmAmnui/pRHUZTyKpC96M/+hye+y5Uc9y2dnB1XMnEU2JzAtpg5WVSvWMn6sKDrdG7cZp8+aiOicrx/qnyyIkRQuHgDukSrKUnsZI5CIbhRFRlHLAifjyZZvImyWftXMtP+3dRVsEj9Eypfqhk/iJ9WMV6hMi4vOiTURi084fB/li3k6XaTtYnZOYhsOuVnoxx23yq9dqhS2Kw7tpsic8JD3bQ1DMu0MmuA5u7tELgxpDRgEm028ioLefkhR9z9h1ztERAnXeQ==;25:HRjjoB4CuxpV6HSBvCF+16pGAylm9JsibER6nXQrrCYWtnwfFJAoZR9mhKTxnwoSE+8yb1/dqJFBYuijPkGX9yHcDDnZHZYx1ofnPa3/QtQ1r+YQHgGfGaG66bGVPJGfd2dDQZy8BU8x4xyAiWItLSQPz0oAUBuTrchQIz/UChCO5K1I5BMYEd6NJQs4G/C8EMnW3C/qpaejpXJHBwU3Et8+LgxDMP5+ItTwvkrZsyF8VCCqszhMPHNyt2Kye2fNeWczvx2ObOZdF2SXQz4uEme/5GcKIgo7eJqrhuR+a9E1NICy1g3PCe8OuHulikbHDplyOJOddV20z55WBHVCMsRwGDMs0lfAevz4T8U0ke7ATmILVFPPPcfcCnkRuGJ50fjoKaCQnJDH3IrOu6ZkpX3uIlCkjw2QDXPrTrhAkEd6sfmjZzG6rdfLVPht6Ri0iexFccVVDt5Kst04bucjvg== X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2623;31:fQkVJq/Y1h7vdtdkxtE2DMYRukcdnO+cKJyvqHWamnGxZcKtlwiZjYRD1bfzJnzK+EKYLzd38BfwuIUPKelLWjyFwP0Ez/JyVqqi9GxLS9GZT+/RkJO1anDpZgzEo7aNCIxnBwJiks+g9uNqMn/JOfXWvbLCWTKwBxkez6PvKrm3T4Gzqj2SEg5LzV1iwv9tUxyoKcB6LXXrJSkA4t6NXaoV7/NHNP8u7Z/RLzRta/nAdWHjLwmiOiq3C9jpkKCtBXnGZMt+vRyb75iKbse6cg==;20:c4s0rUMISKRtAaCYRsznThJQwcmCuEQaCstqImG/bOkbylyWw0ux16IVif/S+zUj0GtXy6rGAnmgkFfPwObtJiWEq4EZ/cnJi8XesNFH0tcjRRGpfL2mT5IQ38tqQvJguh6zThryd6VJLk+U1c2aImFtFKC1MHgHJCw1vqv6RdUJmXvC5vTf+r18paP4laDhs4UbWIp+l6nsjFo11Brc0mbNNeUKbZuR38mSCduk5FlqnDoJ9UDGkWugiY5xTAXTPINy7VzkNlg7hfIrvYavzuKfBetLrosu1yLbpFC3FLPWRtdcBjhGFSsknFJMJ24xoTr5wGADFDfN/vdVua7LK7RLbyCCXlYAFpkCXKShRkmWx4+PwkbwUSFwnhEOZJ/LGmogCa41ujJOe0dO13bAZAl06Z0Yk+Ya0ZZYCppQtZTyAf0EkagbenanNnp5gE9I/dYFe56La9B3zaJ8+TaPRbJbKMDla5UGFJnRK8T6qTNXgUMsWUjDFKsGUhnf+vRE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148);SRVR:SN2PR07MB2623;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2623; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2623;4:AMqmBQYqdxTd6xDuj1H2qySNw5jvzuSKK2vcOH9wHGaVrW1xU23yNFe5cfaxUkmRwF9poIrTDi3hvrks0NfS3JmEa+6ejVTSpKFI8v58q82Uf8+mt33fY0QBxBsvps0GJ/wHJmAWVdlCliLfQE7KhadhVD9lKjBQ238r6uhV6vQWQoA98tQ3ySulRdlWm1wO9el7lULC/7yuz8mBw+9l02yoKeR2mhimsu9InE9ktV3X6/3rsIlzUTbvAkaF/tk5JZK6fCWob1jRh9ushkHplN7GR96TBKBxHVg4rsZ4yFv1gv+rttmJYvO4O/irTPMyFKjNtfnZXjyDXymHJcTxM/7fAxOtrGIFloGJrL9A1Pm9qmmB1DPbCta1dI6Jy2mMSz9ygTAVTuynUo2SSa0QEUvhXJdf35tf+VhOb6+FDZpPNaF/mqkcDxJ6RpGoRh6yjZzwmLaXBJPq8ADWSpvUgeQejvLuQEnl8oLBuRrprVV5ZyV990+vVLNnD/F7Rq2ZXdCLy/jCNmY86uH2PKwYZ6lDabGHFudb/fLSx1ij5/uCmcXXdpbw9eILEt6kQlIItG5MgDzcxt6JQ1FjKMFi3tFCZQu0zoQQoEIjaVWCK8OjPRgSrYP0bJOSM71trimb3aS35bmZYK9/fKLLRM22VaT1/uJFw4O2iMsiazenjLw18xdEM9g88hEYzPWDsa4eBXQnXyeJALgTNtVGT99FKB6yOQ+il52hmeeiQWUTWIbJeeoEEKmatmTHpgDbXReurWc00HRVcXP8u3zR/dOErQ== X-Forefront-PRVS: 0268246AE7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39840400002)(39400400002)(39410400002)(39450400003)(54534003)(24454002)(377454003)(377424004)(8676002)(81166006)(61266001)(4326008)(47776003)(38730400002)(59536001)(305945005)(7736002)(54356999)(63696999)(122856001)(50986999)(76176999)(23676002)(66066001)(93516999)(5660300001)(6862004)(53546009)(189998001)(229853002)(61726006)(110136004)(2950100002)(107886003)(3846002)(6116002)(42186005)(6306002)(498394004)(54906002)(53936002)(9686003)(98316002)(50466002)(2906002)(966004)(6246003)(9896002)(55446002)(41533002)(55456009);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2623;H:mail-yw0-f180.google.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3TUIyNjIzOzIzOjhjaDRCMGRYeUdPTGtFa25wYmtlRzdGcjdh?= =?utf-8?B?aDN1TEU5UmthYlU4cVJKY2VvYmRmWFBwKzFmY2ExWFJRZURydTU3eWFSVVVl?= =?utf-8?B?MkRIdkZFVlpyS25xVFJCTng2VGpDbmFnWGJGeTVDdWNOSXdHZTFzUlR6SHNN?= =?utf-8?B?SGtjMk1BOFowUDFObkJNbzNESDBGcldKUFRUbE9Sc0paVzZ0YzN6WXBxWTJp?= =?utf-8?B?SWw1UE1nVkRTTDF3WUZBUlU4ci92UThGRVNBWUxuTTlZSmt6SXhaRkNEMWhW?= =?utf-8?B?TWQ2R2ZDdU5ZNDFERXBXSXFCcGlqMVE3NEhrM3BKNnR6eHNGTTJqU2YvSjdt?= =?utf-8?B?Rlcvd1I4ZzRLZjVlK1JqQkJ1SW9NUUh1bXR2aXI5U1dwRWE2bXByVXVjNGY1?= =?utf-8?B?aW9tYTBGYnVydFFUVXdiek1EeXVCTWRvOUg3a2Z2Rmh5blRWU04rczIwVnUy?= =?utf-8?B?MEtvS1dMbGtlSjVIM3BGVkU3N2R0TzVtTE0yWjJwYTB2a0l2cG1EaXdjWFg3?= =?utf-8?B?cEovUEJFSG9qSHdxaFJlTVdvYXBad09KQWZHR3FVUXRVRHgvWEtHVFF2bEdH?= =?utf-8?B?eUdzbThZcklNNWdESW11WUtwbzlQbVJnYlkvUXJURTVJaWZPNjFBK3l1ODkw?= =?utf-8?B?ek9nSUMwRWxHME9yUFV4RjU5NVdHSFM1TUx6emxwdStKRGduWHJOaWRYWnFT?= =?utf-8?B?WGtNaFJJaDE1VUNpbnF0T2p4dVJRdDExaWtOUjE2MXNYcEZnSFVMemNJNTlL?= =?utf-8?B?ZDJGVFB0L1h2dkIvNkkxMU5rUGovVzd0Vmt4cTZxa0lPSmw0NmIrcE13OVcr?= =?utf-8?B?Sk1td0d3R1p0QmYyQXhKRHRqMVlCd1hhZnJrZHNXRStyUE1icXkxMzlOempo?= =?utf-8?B?ZkkxL2IxOTR6Y2ZqY0tVUzZ6a0Y4NERzUFE1azlGWm5BS3FUL1NjMDViSlg4?= =?utf-8?B?TUQ4NCtEYnowSjZzUFp6MC8wVFFsdVB5REhuRERqaWZVSTRFbEZGemJEYncv?= =?utf-8?B?UE1mWFM4aS9KL1p0clFlayt2TnEzbEtYakxRZ0xwRnV3ZkEwN29JbTJkUUpz?= =?utf-8?B?OVZ2SDI4NExOM2g4RW5xeVVzbHUzUjJLR1BoOU9WVDNidzNvcW1nTG5jVVZh?= =?utf-8?B?TU1pay9YdndTNEdBdGNlK0p2S24wa2NRZ3k0dTVhK3BGNC9NZFdySE40MThX?= =?utf-8?B?MDIzQmYxd0dwSmtNYnVXZmw2b09GclJoTFBJUit1eU05Wmx6ckZQNjdodDVC?= =?utf-8?B?ZFIwRkJMaFJ5S25iZGJ3UmdFeXRBYnhTNkliVFIvaVRBMGJsbG1wa2I0T3BV?= =?utf-8?B?NUVJYllBUG80ZTh2L3R1RER0NUtLOHJTTVliR1RqdVNZR3o4OGpJKzIwckxZ?= =?utf-8?B?UHh2djJ6NTEwQzRYdTVPanV3dGxHWE1saTFhVEdQcTRWdUFXcjJtYWk0NGVz?= =?utf-8?B?czdMZHNTT0NTblF0eSszeWdROStiZ2xOa2ZQQlk4UEQxMDY5Q0NsNjBWMFN4?= =?utf-8?B?MmVZMXZqZXVRSWVnZldmclVUY2hDKzdlWjEwK1pEU3FoNlA5dmpPQnU2UzNU?= =?utf-8?B?aHdXZUhldHJ2QWxFZDBEa2lRZ3pvVS9EdXdQUy8rWDRPK2Z0Tnp4SExDNUNJ?= =?utf-8?B?Ykc4Z1EzWHdtcHFrOWE1T1g0Q2FCdnpxQTdtMEVPbGt0SVVnNk1Sa0MrZlBt?= =?utf-8?B?anhULzFMRTNOWk1nc09JeGRmUWV6djZSRE9pUUlpMDVtbE9LdnlqUk81ZkRu?= =?utf-8?Q?7dS29gKobBctAEoM0aV/XvecUIZLvNfifp8nY=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2623;6:+JIcK4o5An9yZgmwkfJoTJ3zUo4WXrTtUO6RR4PXcj8LD2alNgHuwZ7xhPoWnU5S3JZW22/qA6mbNDhjAGoDctUysSovyuNCXDojaWjhx6lddF60b4+gb5DNBMhMylXr1UpoDrXLaOc/l6DoH5uEgik2ZvZRe2Dgb9Dkk4TdmyTDQGcSy+R3VQ9KZpfk+HNuesg/6uqUIhSnKmURrCWXV5UzLBd4ubdS0zsV/ynCIIwPenQJYaYCwtJedKhAEvjwFERcqAmByeXfSivM6VmZFOkbtPgKUm6luJ+U2f2r9L6YhX/17XvTXQGzA3I38FEGDwbtNtohA2d9xWmbRDe+vy4Jphh0J1TPwBvIweyYchMMPYr2L1B1lA7biNqMArKdA6fZ34mwgUyU0JSJDdOpDw==;5:yZfoDLqGzGCh8cs+7WC7AVJ5ZaIDNnMrxd/QBr5IpenRRudkMZgb4UqoWQI6qE+ghcrr+i4DE7tIjcti9tNGTf48jxEzC6OrCNP2rZMlEk9fxxYEitqJHI5Tsb7rlpYpLqS/BHZBjNj4hKK/MRJpjg==;24:xBygVqjZcPllXj+c8eDFae+z5wndVhIRR5PTZ061e/5rK18ranBZ32GcnkYIuAhOd8eLm+LlkQbE11vhHhNXTAANCJf/avoHTB9UuZmBSIE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2623;7:0crir6WgNw34lH3Cw4oJhuFIQLImEKczHBRXlYdBRmggpkRH2BzL8hRahU6/Ho/rHqABcp9TZ+xqs88fjWztgk4opCRYNq7AvlNbRwXyAy33xK5eMfNLWwc7t1AWmSSW72pUrBQDnAwyPgVPL+lbqDznhsAnborRKbHff532aM9hdQaulVttth8YyCvgu+GN2vakAFL1L/2wqFfCy3TqV+yUnEK4yIp+MgNAQZQ+UB04RW/eSeG+UkPYt2yYoVRqVACnv6rc4mAbtLdLwURUbC/c0tosrwtAbvAFGeg0vfWTpEp5ty90tSarvM1BIZveqINE2zlZrppSM4LRZZHq1g== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 16:17:23.3433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2623 X-SW-Source: 2017-04/txt/msg00238.txt.bz2 On Wed, Apr 5, 2017 at 5:38 AM, Wilco Dijkstra wrote: > Many supported cores use the AUTOPREFETCHER_WEAK setting which tries > to order loads and stores to improve streaming performance. Since significant > gains were reported in http://patchwork.ozlabs.org/patch/534469/ it seems > like a good idea to enable this setting too for -mcpu=generic. Since the > weak model only keeps the order if it doesn't make the schedule worse, it > should not impact performance adversely on cores that don't show a gain. > Any objections? This is ok with me. Thanks, Andrew > > ChangeLog: > 2017-04-05 Wilco Dijkstra > > * gcc/config/aarch64/aarch64.c (generic_tunings): Update prefetch model. > > -- > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 8b729b1b1f87316e940d7fc657f235a935ffa93e..b249ce2b310707c7ded2827d505ce2ddfcfbf976 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -547,7 +547,7 @@ static const struct tune_params generic_tunings = > 2, /* min_div_recip_mul_df. */ > 0, /* max_case_values. */ > 0, /* cache_line_size. */ > - tune_params::AUTOPREFETCHER_OFF, /* autoprefetcher_model. */ > + tune_params::AUTOPREFETCHER_WEAK, /* autoprefetcher_model. */ > (AARCH64_EXTRA_TUNE_NONE) /* tune_flags. */ > };