From: Andrew Pinski <pinskia@gmail.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Andrew Pinski <apinski@marvell.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 7/7] Expand directly for single bit test
Date: Sun, 21 May 2023 11:45:38 -0700 [thread overview]
Message-ID: <CA+=Sn1kW9vsvV_Lbk6fxdap9ef6wmQbY9ArN-UaL2qDL9RFDwA@mail.gmail.com> (raw)
In-Reply-To: <CA+=Sn1=3KFagi2c+rR3L=XkOQyEd8ED-wLZ0y_y5cTQ2h6bUwQ@mail.gmail.com>
On Sun, May 21, 2023 at 11:25 AM Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Sun, May 21, 2023 at 11:17 AM David Edelsohn via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > Hi, Andrew
> >
> > Thanks for this series of patches to improve do_store_flag. Unfortunately
> > this specific patch in the series has caused a bootstrap failure on
> > powerpc-aix. I bisected this failure to this specific patch. Note that I
> > am building as 32 bit, so this could be a specific issue about bit size.
> >
> > * expr.cc (fold_single_bit_test): Rename to ...
> > (expand_single_bit_test): This and expand directly.
> > (do_store_flag): Update for the rename function.
>
> Did this include the fix I did for big-endian at
> r14-1022-g7f3df8e65c71e5 ? I had found that I broke big-endian last
> night with that patch and pushed the fix once I figured out what I did
> wrong.
> If you already tried post the fix, I will try to look into it as soon
> as possible.
I just re-read my message and I think it might have been confusing.
Last night I noticed the patch which you pointed out broke big-endian
targets, I pushed r14-1022-g7f3df8e65c71e5 as the fix. I am wondering
if your testing included this fix.
If yes then I will try to figure out the best way of figuring out how
I broke this target too.
Thanks,
Andrew
>
> Thanks,
> Andrew
>
> >
> >
> > Thanks, David
next prev parent reply other threads:[~2023-05-21 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 18:16 David Edelsohn
2023-05-21 18:25 ` Andrew Pinski
2023-05-21 18:45 ` Andrew Pinski [this message]
2023-05-21 19:23 ` Jeff Law
2023-05-21 23:01 ` David Edelsohn
-- strict thread matches above, loose matches on Subject: below --
2023-05-20 2:14 [PATCH 0/7] Improve do_store_flag Andrew Pinski
2023-05-20 2:14 ` [PATCH 7/7] Expand directly for single bit test Andrew Pinski
2023-05-20 4:55 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1kW9vsvV_Lbk6fxdap9ef6wmQbY9ArN-UaL2qDL9RFDwA@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=apinski@marvell.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).