From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 867543858408 for ; Mon, 26 Jun 2023 18:49:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 867543858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-26309247002so363680a91.0 for ; Mon, 26 Jun 2023 11:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687805380; x=1690397380; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Kq0oX9VwuXb/Dyfqx1vILDcC3o5CUhlaodyufiE3vO8=; b=ETsILHr6gOgQccIc6/xhuLyIYHXJLDpD5ldnqqCojpKyMe40ZYUZUYapDiWDm6aUU+ 35RiE7l4RHqSlHmwrAaSNO+ql0+AI5iMtMERu8akBnY2+NuLaNHi7XNPzIYHFIWkc82F WbZ5otveu0CLy4pCIlB5Is0oS95ZIQ2m+xVOJQ1VFEhjJp1FR8AD/Heuyv+tK9rtfvHR WF6i+LAwi5fEl4Fw/O+emHaTyZ3q8/9/IJAgd7CIAO8M7g+Jey6fwO+KlKNRgw2qvRI+ kzVVAEXZnL+XI0HfUijAtKJPTOKchKmSLwop7Dp1/KU5AzlfjsRi9D7pxEGoHxen/F64 SnXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687805380; x=1690397380; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kq0oX9VwuXb/Dyfqx1vILDcC3o5CUhlaodyufiE3vO8=; b=IJQjAsp3peX047y5Un8JB2O80vV3vDSYXTbSPZNEDwqAj1Sto8BZ1kMFO2zSNnB44Q BR3FznvHqoOM3FG+L5R0m7ioaSFVVPuvWKWPIXM2UnkfYT/Owyt5gjYgve1bRpZE3Lzo UzlJ3dkEFRNzihkIwVlyonSgSTu1RZVSketlW+Bv2yPdMloS3LXZq2codPLIY35MRYKY RO9uBjoU/wEy7PBBu+vxzLu39pFFeEDaidEFBqjls5ET0P4Ik1m1PvxxYyCkiK6gzPY2 Utbc0oinBPZuVjw/dnr3SBYyvzYMxr9L46ZOEL3ULCYPujbrPjmWO6YQ7Xhk1ePVTtM3 LrAA== X-Gm-Message-State: AC+VfDzEH0zemPt6bboFTgBUCIgudiBCufryA5oshxlGalgh0VPTN1Sf Jm6vdnL/FWsxTrJshRbe9K/rULZNNZZUCI0hNyw= X-Google-Smtp-Source: ACHHUZ5iHEO1C3R658SfI1BEj4N0T3ybgcR3sj15H7vlJGBpBTtQ1e95EPtC2A8PvSib3CYKeMpN2FNSjGrmk8s/fLs= X-Received: by 2002:a17:90a:c595:b0:262:ebfd:ce44 with SMTP id l21-20020a17090ac59500b00262ebfdce44mr3349256pjt.34.1687805380469; Mon, 26 Jun 2023 11:49:40 -0700 (PDT) MIME-Version: 1.0 References: <20230505151719.1031737-1-apinski@marvell.com> <20230626055827.t57twu4yykagzdpt@lug-owl.de> In-Reply-To: From: Andrew Pinski Date: Mon, 26 Jun 2023 11:49:28 -0700 Message-ID: Subject: Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist To: Jan-Benedict Glaw Cc: Andrew Pinski , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jun 26, 2023 at 9:13=E2=80=AFAM Andrew Pinski w= rote: > > On Sun, Jun 25, 2023 at 10:59=E2=80=AFPM Jan-Benedict Glaw wrote: > > > > Hi Andrew, > > > > On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches wrote: > > > While looking into a different issue, I noticed that it > > > would take until the second forwprop pass to do some > > > forward proping and it was because the ssa name was > > > used more than once but the second statement was > > > "dead" and we don't remove that until much later. > > [...] > > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > > > Since this patch, I see a bit of fallout building the Linux kernel > > using the adder875_defconfig: > > > > # CC arch/powerpc/kernel/ptrace/ptrace-view.o > > powerpc-linux-gcc -Wp,-MMD,arch/powerpc/kernel/ptrace/.ptrace-view.o.= d -nostdinc -I./arch/powerpc/include -I./arch/powerpc/include/generated -I= ./include -I./arch/powerpc/include/uapi -I./arch/powerpc/include/generated/= uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/c= ompiler-version.h -include ./include/linux/kconfig.h -include ./include/lin= ux/compiler_types.h -D__KERNEL__ -I ./arch/powerpc -fmacro-prefix-map=3D./= =3D -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-trigraphs -fno-strict-al= iasing -fno-common -fshort-wchar -fno-PIE -Werror=3Dimplicit-function-decla= ration -Werror=3Dimplicit-int -Werror=3Dreturn-type -Wno-format-security -f= unsigned-char -std=3Dgnu11 -mbig-endian -m32 -msoft-float -pipe -ffixed-r2 = -mmultiple -mno-readonly-in-sdata -mcpu=3D860 -mno-prefixed -mno-pcrel -mno= -altivec -mno-vsx -mno-mma -fno-asynchronous-unwind-tables -mno-string -mbi= g-endian -mstack-protector-guard=3Dtls -mstack-protector-guard-reg=3Dr2 -fn= o-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno= -format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-ra= ces -Wframe-larger-than=3D1024 -fstack-protector-strong -Wno-main -Wno-unus= ed-but-set-variable -Wno-unused-const-variable -Wno-dangling-pointer -fomit= -frame-pointer -ftrivial-auto-var-init=3Dzero -fno-stack-clash-protection -= Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -= Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uni= nitialized -Wno-array-bounds -Wno-alloc-size-larger-than -Wimplicit-fallthr= ough=3D5 -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=3Dd= ate-time -Werror=3Dincompatible-pointer-types -Werror=3Ddesignated-init -Wn= o-packed-not-aligned -g -mstack-protector-guard-offset=3D544 -Werror -DUTS_= MACHINE=3D'"ppc"' -DKBUILD_MODFILE=3D'"arch/powerpc/kernel/ptrace/ptrace= -view"' -DKBUILD_BASENAME=3D'"ptrace_view"' -DKBUILD_MODNAME=3D'"ptrace_vie= w"' -D__KBUILD_MODNAME=3Dkmod_ptrace_view -c -o arch/powerpc/kernel/ptrace/= ptrace-view.o arch/powerpc/kernel/ptrace/ptrace-view.c > > during GIMPLE pass: pre > > arch/powerpc/kernel/ptrace/ptrace-view.c: In function 'gpr32_set_common= ': > > arch/powerpc/kernel/ptrace/ptrace-view.c:649:5: internal compiler error= : in gimple_redirect_edge_and_branch, at tree-cfg.cc:6262 > > 649 | int gpr32_set_common(struct task_struct *target, > > | ^~~~~~~~~~~~~~~~ > > 0x1a562a6 internal_error(char const*, ...) > > ???:0 > > 0x826ea1 fancy_abort(char const*, int, char const*) > > ???:0 > > 0x9b77c9 redirect_edge_and_branch(edge_def*, basic_block_def*) > > ???:0 > > 0x9b7e43 split_edge(edge_def*) > > ???:0 > > 0xee1cc7 split_critical_edges(bool) > > ???:0 > > Please submit a full bug report, with preprocessed source (by using -fr= eport-bug). > > Please include the complete backtrace with any bug report. > > See for instructions. > > make[4]: *** [scripts/Makefile.build:252: arch/powerpc/kernel/ptrace/pt= race-view.o] Error 1 > > make[3]: *** [scripts/Makefile.build:494: arch/powerpc/kernel/ptrace] E= rror 2 > > make[2]: *** [scripts/Makefile.build:494: arch/powerpc/kernel] Error 2 > > make[1]: *** [scripts/Makefile.build:494: arch/powerpc] Error 2 > > make: *** [Makefile:2026: .] Error 2 > > Can you file a bug (https://gcc.gnu.org/bugzilla/) with the > preprocessed source (which -freport-bug will provide). In the meantime > I will try to reproduce it and see what is going on. Note I am suspecting it is related to GCC PR 103979 . I am still trying to reproduce the ICE. > > Thanks, > Andrew > > > > > > > > (Full log at http://toolchain.lug-owl.de/laminar/jobs/linux-powerpc-add= er875_defconfig/100) > > > > Thanks, > > Jan-Benedict > > > > --