From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 131F53858C33 for ; Tue, 25 Jul 2023 21:59:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 131F53858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-267f870e6ffso1698533a91.0 for ; Tue, 25 Jul 2023 14:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690322338; x=1690927138; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UqWmAWlo3mWAaoogC3ZOD3Nif6UU7uMGVi06pzcO5mI=; b=E9fuPmOCwL7Bb1feP27SfmbwyQS4tILVkRAnvrJsTz9FklPy8ASWT6RWXk1rpycWtE Xn4fBs25w7tikkGc6/I1kOpYseW6ncmnfY4L4akXHj/HbjED0LS61Pj4RDGceGEmVQa6 BhwVhPy9lkuIKKUVab3mcZ/YjvdC/6pcn2Q5YeDwDBT/G83Fboi1ZKQDyaWNrjtoVuZ/ S3AyOGlfyc4r7PxAdDvXOFixeZnoNIXHS61X8id7aHGkicXJKS/JffKSm/+NtZprY8L5 D1/l1jHWh4VL6jrGyFBQ47b1K7rZ918PoIYY7fdqVX6mTAuBCI9lnJYNhwH4/8MwF19g Je+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690322338; x=1690927138; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UqWmAWlo3mWAaoogC3ZOD3Nif6UU7uMGVi06pzcO5mI=; b=bA4DjlWDDd72EBjb5EJyngHDm3NW7c3T0kDciR+sxIG9DBl09qbMI4pO+VhbJY0Jjm uKs2FbydUn0fWcMXWPAMi7kEJkpjTn2JafZf3t2MyBKfPFvzGrKRmpU7X85ZqqH2ILqu aaW4pdr34MvdG4IGX+wuFLutzPwxBU3J3b9iT9+rQ2nwgyyiIlUk76OYsYJoSiHurJ+H DvW4bMrAGgfrerEeOoBfBibhBN1qxHjIIMkySqsU08oucc70m/ZvVqWP0FJ4dafTMqwQ AjjUumYxp5sUS3kOpQdrTqaSWg3vq0+FYcXkIZPI0ZsmpIQTxW78qY1UZAeH/7Bbmmm+ f7kg== X-Gm-Message-State: ABy/qLYiX2eHPkTuLjKnHF/1MK6XdsTmfWIeTinT3K9DTiPNT0vFiye0 z10WgG209S85ypWEFiP5pfiZ3bZE+N8WZ8CuWFw= X-Google-Smtp-Source: APBJJlFdn/5bruMVxsZZkBbN9j9mZNNb/tClJohay3W4JDijC9b0bceIrT64yfu0lrZA4ppaaBcl5IrYIYiOoJrwkHQ= X-Received: by 2002:a17:90a:ba94:b0:260:e256:27c7 with SMTP id t20-20020a17090aba9400b00260e25627c7mr349829pjr.15.1690322337775; Tue, 25 Jul 2023 14:58:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Tue, 25 Jul 2023 14:58:45 -0700 Message-ID: Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986] To: Jakub Jelinek Cc: David Edelsohn , Drew Ross , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 25, 2023 at 1:54=E2=80=AFPM Andrew Pinski w= rote: > > On Tue, Jul 25, 2023 at 12:45=E2=80=AFPM Jakub Jelinek via Gcc-patches > wrote: > > > > On Tue, Jul 25, 2023 at 03:42:21PM -0400, David Edelsohn via Gcc-patche= s wrote: > > > Hi, Drew > > > > > > Thanks for addressing this missed optimization. > > > > > > The testcase includes an incorrect assumption: signed char, which > > > causes the testcase to fail on PowerPC. > > > > > > Should the testcase be updated to specify signed char in the function > > > signatures or should -fsigned-char be added to the command line > > > options? > > > > I think we should use signed char instead of char in the testcase. > > I also think it should be `signed char` instead as I mentioned in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110803 . Committed the testsuite fix as r14-2767-g67357270772b91 . Thanks, Andrew > > Thanks, > Andrew > > > > > Jakub > >