public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes.
@ 2024-07-27  8:36 Lulu Cheng
  2024-07-27  8:41 ` Xi Ruoyao
  2024-07-27 19:27 ` Andrew Pinski
  0 siblings, 2 replies; 5+ messages in thread
From: Lulu Cheng @ 2024-07-27  8:36 UTC (permalink / raw)
  To: gcc-patches; +Cc: xry111, i, xuchenghua, chenglulu

gcc/ChangeLog:

	* config/loongarch/loongarch.md (<optab>n<mode>): Rename to ...
	(<optab>n<mode>3): This.
---
 gcc/config/loongarch/loongarch.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
index 459ad30b9bb..4e4ddd515c9 100644
--- a/gcc/config/loongarch/loongarch.md
+++ b/gcc/config/loongarch/loongarch.md
@@ -1668,7 +1668,7 @@ (define_insn "*norsi3_internal"
   [(set_attr "type" "logical")
    (set_attr "mode" "SI")])
 
-(define_insn "<optab>n<mode>"
+(define_insn "<optab>n<mode>3"
   [(set (match_operand:X 0 "register_operand" "=r")
 	(neg_bitwise:X
 	    (not:X (match_operand:X 1 "register_operand" "r"))
-- 
2.39.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes.
  2024-07-27  8:36 [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes Lulu Cheng
@ 2024-07-27  8:41 ` Xi Ruoyao
  2024-07-27  8:44   ` Lulu Cheng
  2024-07-27 19:27 ` Andrew Pinski
  1 sibling, 1 reply; 5+ messages in thread
From: Xi Ruoyao @ 2024-07-27  8:41 UTC (permalink / raw)
  To: Lulu Cheng, gcc-patches; +Cc: i, xuchenghua

On Sat, 2024-07-27 at 16:36 +0800, Lulu Cheng wrote:
> gcc/ChangeLog:
> 
> 	* config/loongarch/loongarch.md (<optab>n<mode>): Rename to ...
> 	(<optab>n<mode>3): This.

Ok.

Note that [x]vorn<mode>3 and [x]vandn<mode>3 should be renamed as well.

> ---
>  gcc/config/loongarch/loongarch.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
> index 459ad30b9bb..4e4ddd515c9 100644
> --- a/gcc/config/loongarch/loongarch.md
> +++ b/gcc/config/loongarch/loongarch.md
> @@ -1668,7 +1668,7 @@ (define_insn "*norsi3_internal"
>    [(set_attr "type" "logical")
>     (set_attr "mode" "SI")])
>  
> -(define_insn "<optab>n<mode>"
> +(define_insn "<optab>n<mode>3"
>    [(set (match_operand:X 0 "register_operand" "=r")
>  	(neg_bitwise:X
>  	    (not:X (match_operand:X 1 "register_operand" "r"))

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes.
  2024-07-27  8:41 ` Xi Ruoyao
@ 2024-07-27  8:44   ` Lulu Cheng
  0 siblings, 0 replies; 5+ messages in thread
From: Lulu Cheng @ 2024-07-27  8:44 UTC (permalink / raw)
  To: Xi Ruoyao, gcc-patches; +Cc: i, xuchenghua


在 2024/7/27 下午4:41, Xi Ruoyao 写道:
> On Sat, 2024-07-27 at 16:36 +0800, Lulu Cheng wrote:
>> gcc/ChangeLog:
>>
>> 	* config/loongarch/loongarch.md (<optab>n<mode>): Rename to ...
>> 	(<optab>n<mode>3): This.
> Ok.
>
> Note that [x]vorn<mode>3 and [x]vandn<mode>3 should be renamed as well.

Uh, I just forgot about them, I'm modifying the content of the vector.

Thanks!

>
>> ---
>>   gcc/config/loongarch/loongarch.md | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
>> index 459ad30b9bb..4e4ddd515c9 100644
>> --- a/gcc/config/loongarch/loongarch.md
>> +++ b/gcc/config/loongarch/loongarch.md
>> @@ -1668,7 +1668,7 @@ (define_insn "*norsi3_internal"
>>     [(set_attr "type" "logical")
>>      (set_attr "mode" "SI")])
>>   
>> -(define_insn "<optab>n<mode>"
>> +(define_insn "<optab>n<mode>3"
>>     [(set (match_operand:X 0 "register_operand" "=r")
>>   	(neg_bitwise:X
>>   	    (not:X (match_operand:X 1 "register_operand" "r"))


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes.
  2024-07-27  8:36 [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes Lulu Cheng
  2024-07-27  8:41 ` Xi Ruoyao
@ 2024-07-27 19:27 ` Andrew Pinski
  1 sibling, 0 replies; 5+ messages in thread
From: Andrew Pinski @ 2024-07-27 19:27 UTC (permalink / raw)
  To: Lulu Cheng; +Cc: gcc-patches, xry111, i, xuchenghua

On Sat, Jul 27, 2024 at 1:38 AM Lulu Cheng <chenglulu@loongson.cn> wrote:
>
> gcc/ChangeLog:
>
>         * config/loongarch/loongarch.md (<optab>n<mode>): Rename to ...
>         (<optab>n<mode>3): This.


Thanks for doing this for loongarch. Once I finish up my patch set;
loongarch should get benefit. Also it might be useful after my patch
set goes in that a loongarch specific testcases are added too. I
estimate by the end of this coming week when it will be done/approved
but that is just an estimate.

Thanks,
Andrew

> ---
>  gcc/config/loongarch/loongarch.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
> index 459ad30b9bb..4e4ddd515c9 100644
> --- a/gcc/config/loongarch/loongarch.md
> +++ b/gcc/config/loongarch/loongarch.md
> @@ -1668,7 +1668,7 @@ (define_insn "*norsi3_internal"
>    [(set_attr "type" "logical")
>     (set_attr "mode" "SI")])
>
> -(define_insn "<optab>n<mode>"
> +(define_insn "<optab>n<mode>3"
>    [(set (match_operand:X 0 "register_operand" "=r")
>         (neg_bitwise:X
>             (not:X (match_operand:X 1 "register_operand" "r"))
> --
> 2.39.3
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes.
@ 2024-07-27  8:54 Lulu Cheng
  0 siblings, 0 replies; 5+ messages in thread
From: Lulu Cheng @ 2024-07-27  8:54 UTC (permalink / raw)
  To: gcc-patches; +Cc: xry111, i, xuchenghua, chenglulu

gcc/ChangeLog:

	* config/loongarch/loongarch.md (<optab>n<mode>): Rename to ...
	(<optab>n<mode>3): This.
---
 gcc/config/loongarch/loongarch.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
index 459ad30b9bb..4e4ddd515c9 100644
--- a/gcc/config/loongarch/loongarch.md
+++ b/gcc/config/loongarch/loongarch.md
@@ -1668,7 +1668,7 @@ (define_insn "*norsi3_internal"
   [(set_attr "type" "logical")
    (set_attr "mode" "SI")])
 
-(define_insn "<optab>n<mode>"
+(define_insn "<optab>n<mode>3"
   [(set (match_operand:X 0 "register_operand" "=r")
 	(neg_bitwise:X
 	    (not:X (match_operand:X 1 "register_operand" "r"))
-- 
2.39.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-27 19:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-27  8:36 [PATCH] LoongArch: Use iorn and andn standard pattern names for scalar modes Lulu Cheng
2024-07-27  8:41 ` Xi Ruoyao
2024-07-27  8:44   ` Lulu Cheng
2024-07-27 19:27 ` Andrew Pinski
2024-07-27  8:54 Lulu Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).