public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [Committed/AARCH64] Fix *extr_insv_lower_reg<mode> pattern
@ 2014-07-27  6:13 Andrew Pinski
  0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2014-07-27  6:13 UTC (permalink / raw)
  To: GCC Patches

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

The problem here is that the pattern marks the second operand as a
rewrite constraint but this operand is never written to.  It looks
like it was a copy and pasto.

Committed as obvious and should improve register allocation in some cases.

Thanks,
Andrew Pinski

ChangeLog:
* config/aarch64/aarch64.md (*extr_insv_lower_reg<mode>): Remove + from
the read only register.

[-- Attachment #2: fixconstraint.diff.txt --]
[-- Type: text/plain, Size: 634 bytes --]

Index: config/aarch64/aarch64.md
===================================================================
--- config/aarch64/aarch64.md	(revision 213089)
+++ config/aarch64/aarch64.md	(working copy)
@@ -3390,7 +3390,7 @@ (define_insn "*extr_insv_lower_reg<mode>
   [(set (zero_extract:GPI (match_operand:GPI 0 "register_operand" "+r")
 			  (match_operand 1 "const_int_operand" "n")
 			  (const_int 0))
-	(zero_extract:GPI (match_operand:GPI 2 "register_operand" "+r")
+	(zero_extract:GPI (match_operand:GPI 2 "register_operand" "r")
 			  (match_dup 1)
 			  (match_operand 3 "const_int_operand" "n")))]
   "!(UINTVAL (operands[1]) == 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-07-27  2:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-27  6:13 [Committed/AARCH64] Fix *extr_insv_lower_reg<mode> pattern Andrew Pinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).