From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126616 invoked by alias); 16 Jun 2015 09:10:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126603 invoked by uid 89); 16 Jun 2015 09:10:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f172.google.com Received: from mail-lb0-f172.google.com (HELO mail-lb0-f172.google.com) (209.85.217.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 16 Jun 2015 09:10:54 +0000 Received: by lblr1 with SMTP id r1so6602393lbl.0 for ; Tue, 16 Jun 2015 02:10:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.151.178 with SMTP id ur18mr5518438lbb.59.1434445851480; Tue, 16 Jun 2015 02:10:51 -0700 (PDT) Received: by 10.25.130.7 with HTTP; Tue, 16 Jun 2015 02:10:51 -0700 (PDT) In-Reply-To: <557FE6FA.9020803@foss.arm.com> References: <3247494.5bgQPARZRk@polaris> <2396877.AqT21tpnmO@polaris> <557FE6FA.9020803@foss.arm.com> Date: Tue, 16 Jun 2015 09:11:00 -0000 Message-ID: Subject: Re: [patch 2/6] scalar-storage-order merge: C front-end From: Andrew Pinski To: Ramana Radhakrishnan Cc: Eric Botcazou , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01088.txt.bz2 On Tue, Jun 16, 2015 at 2:06 AM, Ramana Radhakrishnan wrote: > > > On 16/06/15 09:54, Eric Botcazou wrote: >> >> This is the C front-end + C family part. >> >> * doc/extend.texi (type attributes): Document >> scalar_storage_order. >> * doc/invoke.texi (Warnings): Document -Wno-scalar-storage-order. >> c-family/ >> * c-common.c (c_common_attributes): Add scalar_storage_order. >> (handle_scalar_storage_order_attribute): New function. >> * c.opt (Wscalar-storage-order): New warning. >> c/ >> * c-decl.c (finish_struct): If the structure has reverse scalar >> storage >> order, rewrite the type of array fields with scalar component. >> * c-typeck.c (build_unary_op) : Remove left-overs. >> Issue >> errors on bit-fields and reverse SSO here and not... >> (c_mark_addressable): ...here. >> >> doc/extend.texi | 47 +++++++++++++++++++++++++++++++++++++++++++++ >> doc/invoke.texi | 6 +++++ >> c-family/c.opt | 4 +++ >> c-family/c-common.c | 54 >> +++++++++++++++++++++++++++++++++++++++++++++++++- >> c/c-typeck.c | 53 >> +++++++++++++++++++++++++++++++------------------- >> c/c-decl.c | 45 +++++++++++++++++++++++++++++-------------- >> 6 files changed, 175 insertions(+), 34 deletions(-) >> > > A very cursory glance at the patch set but should we restrict this attribute > to apply only to scalar types rather than allow them on vector extensions. > I haven't had enough coffee this morning but a first thought is that if it > does apply on vector type extensions, clarifying the lane ordering up front > would be helpful especially as we now allow indexing into short vectors. I think it applies to vector types but really it acts the same way as we apply attributes on arrays, that is on the inner scalar type instead. Thanks, Andrew > > > regards > Ramana > > >