From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 65C0B3858D1E for ; Tue, 2 May 2023 21:49:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65C0B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5208be24dcbso2986854a12.1 for ; Tue, 02 May 2023 14:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683064163; x=1685656163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4rdJkazM4+vbAJq7Sg5LThHDFvWTt5nAUcYo+Vw0pMY=; b=WrmqvIdQp6PyjPuUC+qbnlRGTzLNa7e31vUdzeH9ZZNuEzBJISIBr+cKbIeagLLBZY ZWPhBkDEny6qWuZnCk/2KabVWhMsUxeGaTlNzuoUpMWDN0ngin+0xuQX+M+TXQtbJTHe K1+hJ8oUkGdyftjQVOg2t8FTp80gGjScxwzDTSQEurgsjayPHVkLsAHXNiDGrYIM2W+4 2kBUVw0ZlXOHlss4Id6yQTgRVOE/H0CZgdl6n+cgNBueJdjCAMyxqM6KzpkRnhW3WNab gw8vechYebKFzNeMDmAr0yFU1TPsBeJxt+tYMqQluP1vs6WSNJ/jUAT1kfyd4oyuzyxA KEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683064163; x=1685656163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4rdJkazM4+vbAJq7Sg5LThHDFvWTt5nAUcYo+Vw0pMY=; b=cAOCwH4XwxJI0Oi0FjR7oqyDdnpNu42QtFS3DHcLMhsb40jR2NcOxY21eBzjJv+WwK HE8adQuqZqtl8z17LeVk5pIL+3Er2h0ydxBDxaKiGFs8H0bFUB7lAX7RNdwN69pndx4D GDMs+mEfecAaqDuX1D7fOkhG02mmdZZhQfXK7QaFQpxs1FtsC1Ye39JkGn+Cucf6O76x vnWplMu7H/XaypF89KWTQh//qNljh+A//pJs+2z+WFzkHj42MfVZK+TENhxZf40wMsVU HsjEotUSO7em3KjfMQPy1OE0q+73TlkJecsgygmEuiIMVXbY+SmWVDnD0GUDShCQrICz Tq8Q== X-Gm-Message-State: AC+VfDxD0nS5FEGPo9CjnfCQLJYEJX20juKOyw1EOD3KLlq4yItjixMW oVMX4JhX2pumCivS7dkOpCFdaV1wxby5Pg5j+5U= X-Google-Smtp-Source: ACHHUZ5pCQwa71rsBDsMOLtA25M9h0L8jufmumDxiCSUOIMtcwK0qSy/cOZUwiZaXPQQrLzZRtM7UxsvtMpKWmP56Jo= X-Received: by 2002:a05:6a20:e195:b0:f5:68c9:6f83 with SMTP id ks21-20020a056a20e19500b000f568c96f83mr21240332pzb.18.1683064163213; Tue, 02 May 2023 14:49:23 -0700 (PDT) MIME-Version: 1.0 References: <20230430211248.761908-1-apinski@marvell.com> In-Reply-To: From: Andrew Pinski Date: Tue, 2 May 2023 14:49:10 -0700 Message-ID: Subject: Re: [PATCH] MATCH: Port CLRSB part of builtin_zero_pattern To: Richard Biener Cc: Andrew Pinski , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 2, 2023 at 5:24=E2=80=AFAM Richard Biener via Gcc-patches wrote: > > On Sun, Apr 30, 2023 at 11:13=E2=80=AFPM Andrew Pinski via Gcc-patches > wrote: > > > > This ports the clrsb builtin part of builtin_zero_pattern > > to match.pd. A simple pattern to port. > > > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > > > gcc/ChangeLog: > > > > * match.pd (a !=3D 0 ? CLRSB(a) : CST -> CLRSB(a)): New > > pattern. > > --- > > gcc/match.pd | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/gcc/match.pd b/gcc/match.pd > > index 0e782cde71d..bf918ba70ce 100644 > > --- a/gcc/match.pd > > +++ b/gcc/match.pd > > @@ -7787,6 +7787,14 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > > (cond (ne @0 integer_zerop@1) (func@4 (convert? @2)) integer_zerop@3= ) > > @4)) > > > > +/* a !=3D 0 ? FUN(a) : CST -> Fun(a) for some CLRSB builtins > > + where CST is precision-1. */ > > +(for func (CLRSB) > > + (simplify > > + (cond (ne @0 integer_zerop@1) (func@5 (convert?@4 @2)) INTEGER_CST@3= ) > > As you don't seem to use @2 why not match (func@5 @4) only? Thanks for catching this, @2 should really have been @0, otherwise we get the wrong answer in general. I fixed the other patterns I just added for this same issue too. This is what I committed instead: /* a !=3D 0 ? FUN(a) : CST -> Fun(a) for some CLRSB builtins where CST is precision-1. */ (for func (CLRSB) (simplify (cond (ne @0 integer_zerop@1) (func@4 (convert?@3 @0)) INTEGER_CST@2) (if (wi::to_widest (@2) =3D=3D TYPE_PRECISION (TREE_TYPE (@3)) - 1) @4))) Thanks, Andrew > > Otherwise LGTM. > > > + (if (wi::to_widest (@3) =3D=3D TYPE_PRECISION (TREE_TYPE (@4)) - 1) > > + @5))) > > + > > #if GIMPLE > > /* a !=3D 0 ? CLZ(a) : CST -> .CLZ(a) where CST is the result of the i= nternal function for 0. */ > > (for func (CLZ) > > -- > > 2.31.1 > >