From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115673 invoked by alias); 12 Dec 2016 23:53:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115008 invoked by uid 89); 12 Dec 2016 23:53:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=tamarchristinaarmcom, sk:Tamar.C, Tamar.Christina@arm.com, sk:tamar.c X-HELO: mail-yw0-f195.google.com Received: from mail-yw0-f195.google.com (HELO mail-yw0-f195.google.com) (209.85.161.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Dec 2016 23:53:23 +0000 Received: by mail-yw0-f195.google.com with SMTP id s68so8962211ywg.0 for ; Mon, 12 Dec 2016 15:53:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zHs+KAFDv2W7+yzZhvsrv7Xz30FEulwlKH4nLT3x8fc=; b=J+zIELvsjLyEyqQWHDLnqxar+ETs+7V90tjeirDqKohLFANlz31+raZWZINTJ9UYUC chLZALvvGfj3VLXyeIVMNZEynBiDdzpTqxdGsmQEtMWkXLJE8X8jnYkRJPNtxFm6eQH5 6crWVogJretZ2hs5qPhxeqd6+c3S3CsfB2sd1HHQ4WW/K+022KWXZkYfMNWos6qn21kO yqC7eyvpLx6HNte5FOBmNwzEO2Q3sH5/H57PYLoQbp1KT3aUBMyDt1FxCgRUrPSxnVm/ uZIvamUdMsoIapm2mimf+259H7dcQwtPYFl2W3QJRL9nuXKy8XtONnE0QXwD0kzC8VWB QTbQ== X-Gm-Message-State: AKaTC00FNBD4ioCr2QGnvBIwxBdKSsl9XwkNeqmehkuXZ6OLZ+5QjpQ99M22LDE3hiTjekkbyQFuUpsUz/jVpw== X-Received: by 10.13.238.67 with SMTP id x64mr88196445ywe.291.1481586801531; Mon, 12 Dec 2016 15:53:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.42.65 with HTTP; Mon, 12 Dec 2016 15:53:21 -0800 (PST) In-Reply-To: References: <583D8726.10305@foss.arm.com> <20161129135459.GA6333@arm.com> From: Andrew Pinski Date: Mon, 12 Dec 2016 23:53:00 -0000 Message-ID: Subject: Re: [AArch64][ARM][GCC][PATCHv2 3/3] Add tests for missing Poly64_t intrinsics to GCC To: Tamar Christina Cc: Christophe Lyon , Kyrill Tkachov , James Greenhalgh , GCC Patches , "christophe.lyon@st.com" , Marcus Shawcroft , Richard Earnshaw , nd Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg01097.txt.bz2 On Mon, Dec 12, 2016 at 3:29 AM, Tamar Christina wrote: > Hi Andrew, > > These should be fixed now. Yes they are fixed. Thanks, Andrew > > Thanks, > Tamar > > ________________________________________ > From: Andrew Pinski > Sent: Wednesday, December 7, 2016 4:33:51 AM > To: Christophe Lyon > Cc: Tamar Christina; Kyrill Tkachov; James Greenhalgh; GCC Patches; christophe.lyon@st.com; Marcus Shawcroft; Richard Earnshaw; nd > Subject: Re: [AArch64][ARM][GCC][PATCHv2 3/3] Add tests for missing Poly64_t intrinsics to GCC > > On Wed, Nov 30, 2016 at 1:04 AM, Christophe Lyon > wrote: >> Hi Tamar, >> >> >> On 29 November 2016 at 14:54, James Greenhalgh wrote: >>> On Tue, Nov 29, 2016 at 01:48:22PM +0000, Kyrill Tkachov wrote: >>>> >>>> On 29/11/16 09:50, Tamar Christina wrote: >>>> >Hi All, >>>> > >>>> >The new patch contains the proper types for the intrinsics that should be returning uint64x1 >>>> >and has the rest of the comments by Christophe in them. >>>> >>>> Ok with an appropriate ChangeLog entry. >>> >>> Also OK from an AArch64 persepctive based on the detailed review from >>> Christophe. >>> >>> Thanks, >>> James >>> >> >> After you committed this patch (r242962), I've noticed some >> regressions as follows: >> * on aarch64, vreinterpret_p128 and vreinterpret_p64 fail to compile >> with errors like >> warning: implicit declaration of function 'vreinterpretq_p64_p128 >> warning: implicit declaration of function 'vreinterpretq_p128_s8 >> error: incompatible types when assigning to type 'poly64x2_t' from type 'int' >> etc... >> >> * on arm configured for armv8-a, several tests fail to link or compile: >> vbsl.c:(.text+0x24f0): undefined reference to `expected_poly64x1' >> vdup-vmov.c:227:38: error: 'expected0_poly64x1' undeclared >> vdup_lane.c:(.text+0x1584): undefined reference to `expected_poly64x1' >> >> You can have more details at >> http://people.linaro.org/~christophe.lyon/cross-validation/gcc/trunk/242962/report-build-info.html > > I see the expected_poly64x1 failures also for aarch64: > https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg00738.html > > FAIL: gcc.target/aarch64/advsimd-intrinsics/vbsl.c -O0 (test for > excess errors) > Excess errors: > vbsl.c:(.text+0x1dec): undefined reference to `expected_poly64x1' > vbsl.c:(.text+0x1df0): undefined reference to `expected_poly64x1' > vbsl.c:(.text+0x1e20): undefined reference to `expected_poly64x1' > vbsl.c:(.text+0x1e24): undefined reference to `expected_poly64x1' > vbsl.c:(.text+0x2a74): undefined reference to `expected_poly64x2' > vbsl.c:(.text+0x2a78): undefined reference to `expected_poly64x2' > vbsl.c:(.text+0x2aa8): undefined reference to `expected_poly64x2' > vbsl.c:(.text+0x2aac): undefined reference to `expected_poly64x2' > > .... > FAIL: gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c -O0 (test > for excess errors) > Excess errors: > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:175:38: > error: 'expected0_poly64x1' undeclared (first use in this function); > did you mean 'expected_poly64x1'? > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:175:38: > error: 'expected0_poly64x2' undeclared (first use in this function); > did you mean 'expected0_poly64x1'? > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:178:38: > error: 'expected1_poly64x1' undeclared (first use in this function); > did you mean 'expected0_poly64x1'? > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:178:38: > error: 'expected1_poly64x2' undeclared (first use in this function); > did you mean 'expected1_poly64x1'? > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:181:38: > error: 'expected2_poly64x1' undeclared (first use in this function); > did you mean 'expected1_poly64x1'? > /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:181:38: > error: 'expected2_poly64x2' undeclared (first use in this function); > did you mean 'expected2_poly64x1'? > > > etc. > >> >> >> Christophe