From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19265 invoked by alias); 25 Oct 2015 11:56:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19254 invoked by uid 89); 25 Oct 2015 11:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lf0-f42.google.com Received: from mail-lf0-f42.google.com (HELO mail-lf0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 25 Oct 2015 11:56:02 +0000 Received: by lffv3 with SMTP id v3so121874224lff.0 for ; Sun, 25 Oct 2015 04:55:58 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.135.136 with SMTP id ps8mr14640579lbb.38.1445774158193; Sun, 25 Oct 2015 04:55:58 -0700 (PDT) Received: by 10.25.208.82 with HTTP; Sun, 25 Oct 2015 04:55:58 -0700 (PDT) In-Reply-To: References: <1445613635-12306-1-git-send-email-alan.lawrence@arm.com> Date: Sun, 25 Oct 2015 12:31:00 -0000 Message-ID: Subject: Re: [PATCH] PR/67682, break SLP groups up if only some elements match From: Andrew Pinski To: Alan Lawrence Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02603.txt.bz2 On Sun, Oct 25, 2015 at 7:51 PM, Alan Lawrence wrote: > On 23 October 2015 at 16:20, Alan Lawrence wrote: >> diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-7.c b/gcc/testsuite/gcc.dg/vect/bb-slp-7.c >> index ab54a48..b012d78 100644 >> --- a/gcc/testsuite/gcc.dg/vect/bb-slp-7.c >> +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-7.c >> @@ -16,12 +16,12 @@ main1 (unsigned int x, unsigned int y) >> unsigned int *pout = &out[0]; >> unsigned int a0, a1, a2, a3; >> >> - /* Non isomorphic. */ >> + /* Non isomorphic, even 64-bit subgroups. */ >> a0 = *pin++ + 23; >> - a1 = *pin++ + 142; >> + a1 = *pin++ * 142; >> a2 = *pin++ + 2; >> a3 = *pin++ * 31; > > Erm, oops, I seem to have posted a version without the corresponding > change to result-checking in bb-slp-7.c... > > Also on second thoughts a small change to improve efficiency > of the recursion by skipping some known-impossible bits, would not add > much complexity. > > So I'll post a new version shortly with those changes. Maybe it is better to make a new test for the changed file and keep the old one with the updated result checking? That way the testcase is the same between versions and the only thing that changes is the result checking. Thanks, Andrew > > Thanks, Alan