From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16430 invoked by alias); 29 Apr 2015 00:25:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16420 invoked by uid 89); 29 Apr 2015 00:25:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f51.google.com Received: from mail-la0-f51.google.com (HELO mail-la0-f51.google.com) (209.85.215.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Apr 2015 00:25:01 +0000 Received: by layy10 with SMTP id y10so8620553lay.0 for ; Tue, 28 Apr 2015 17:24:57 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.22.34 with SMTP id a2mr5956306laf.59.1430267097650; Tue, 28 Apr 2015 17:24:57 -0700 (PDT) Received: by 10.25.130.210 with HTTP; Tue, 28 Apr 2015 17:24:57 -0700 (PDT) In-Reply-To: <54900732.4010604@arm.com> References: <54900732.4010604@arm.com> Date: Wed, 29 Apr 2015 01:25:00 -0000 Message-ID: Subject: Re: [PATCH][AARCH64]Add ACLE 2.0 predefined macros: __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR From: Andrew Pinski To: Renlin Li Cc: "gcc-patches@gcc.gnu.org" , marcus Shawcroft , ramana Radhakrishnan Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01813.txt.bz2 On Tue, Dec 16, 2014 at 2:19 AM, Renlin Li wrote: > Hi all, > > This is a simple patch to add another two ACLE 2.0 predefined macros into > aarch64 backend. > They are __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR. Currently, those > two values are hard-wired to 16. > > The following clauses from ACLE 2.0 documentation indicate the meaning of > those two macros: > > The macro __ARM_ALIGN_MAX_STACK_PWR indicates (as the exponent of a power of > 2) the maximum available stack alignment. > The macro __ARM_ALIGN_MAX_PWR indicates (as the exponent of a power of 2) > the maximum available alignment of static data. > > aarch64-none-elf target is tested on on the model. No new regression. > > Is it Okay for trunk? Have you tested these alignments? That is have we tested 65536 alignment for both stack and static data? I suspect the stack alignment that is support is not 64k but much smaller. And the supported static data alignment is much larger, maybe 20 or more. Thanks, Andrew Pinski > > Regards, > Renlin Li > > gcc/ChangeLog > > 2014-12-16 Renlin Li > > * config/aarch64/aarch64.h(TARGET_CPU_CPP_BUILTINS): Define > __ARM_ALIGN_MAX_PWR > and __ARM_ALIGN_MAX_STACK_PWR.