From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16432 invoked by alias); 15 Nov 2012 21:24:50 -0000 Received: (qmail 16418 invoked by uid 22791); 15 Nov 2012 21:24:49 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 21:24:39 +0000 Received: by mail-wi0-f169.google.com with SMTP id x18so3227499wia.2 for ; Thu, 15 Nov 2012 13:24:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.220.78 with SMTP id n56mr1105920wep.135.1353014678692; Thu, 15 Nov 2012 13:24:38 -0800 (PST) Received: by 10.217.64.194 with HTTP; Thu, 15 Nov 2012 13:24:38 -0800 (PST) In-Reply-To: <87ip968twz.fsf@talisman.default> References: <27d19005-b82d-4ecc-a81e-14208937ce0f@EXCHHUB01.MIPS.com> <1352921235.22862.6.camel@ubuntu-sellcey> <1352929552.22862.13.camel@ubuntu-sellcey> <87ip968twz.fsf@talisman.default> Date: Thu, 15 Nov 2012 21:24:00 -0000 Message-ID: Subject: Re: [patch] Performance patch for MIPS conditional move in expr.c From: Andrew Pinski To: Andrew Pinski , Steve Ellcey , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01311.txt.bz2 On Thu, Nov 15, 2012 at 12:58 PM, Richard Sandiford wrote: > Andrew Pinski writes: >> 2012-07-26 Andrew Pinski >> >> Bug #3261 >> * config/mips/mips.md (*mov_on_): >> Remove mode check from comparisons. >> (*mov_on_): Likewise. >> (*mov_on__ne): New pattern to match >> when (ne A 0) can be just A. >> >> * testsuite/gcc.target/mips/movcc-4.c: New testcase. > > OK, thanks (but remember to remove the internal bug reference :-)). > I think this is early enough during stage 3 for the usual target > flexibility to apply. I was posting it for Steve's benefit really. I was in the process of updating the patch to the trunk and trying it out there before doing a formal submission :). As I found out the testcase needs to be changed to work with the new mips target test infrastructure. I will post a revised patch with the removal of the internal bug number once I finish fixing the testcase itself. Thanks, Andrew Pinski