From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id B7D3C3858419 for ; Mon, 29 Jan 2024 09:23:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7D3C3858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B7D3C3858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706520206; cv=none; b=wCIC+mjvR9CT8sTWoMo9RZZMsQJcrWFKn7S+G8nGz5cr+rE/4tXpIMeFsclC7tIPjK3Q5jDbH2Fjm+pE0CJq8V4FkxDh7No8K9vS15pLJ7xRA2XnWEwIIT9qcYxm/XmW/XXftrUrWIWNh+LES+Pz46z0mOABxW0XUheiM6n0tTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706520206; c=relaxed/simple; bh=+lqDtSgbPSXQqIdxmfdREPyBtGOAE3cBiXo2YHzbA0M=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=bxI8z9tYRdjRnFBf/HRSIrHmMDtf8p1WMveByleYpOv8MsrP1rXOY+B3FXAlQjAvspcB9seRm39BglyaTZph+/6w8YUAxECZGfeLkvkKE2jC2pqcuecNuwQZNhNWdNYYcvyAA/Yki2wP+co6EfbIWWwE7m0vbTP6FifXq04rYKQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2901ceb0d33so2650545a91.1 for ; Mon, 29 Jan 2024 01:23:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706520204; x=1707125004; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wnSy83ee0Rq5LtqyTNz0jRfzJC0d0snUL++URknTtSI=; b=ZSoP7eBZLO3WEiWiSF1jZWi/OGXQkDZBT053hCYFruH2lLMHuZGwfv5RDOhpx8G9T8 iWWBXPsMUTuDsxEAwMvX+swa4dtFweSYhsMNqY2+X0DoZxUHpbxrtfXZEq/tILB01jQy hOWGR8NAOqorrAvevsLc/Z1dDm+TLx2A1w0UPeXjf6mdoKR/9iJZITDIJAaNkMDs0BLE vNvkPl1GQd6DSPMcIhgSy/RbdULzjbStp1NBQfclGS7DxAMhD5wtJGmlkNC4EH1Y1P7K CM3dW0nEU/MaG+VN237YpId60EZZo9B1GHT5Lb58JVAIPD3trGrrwtcjeEi2q2T81wzD jclw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706520204; x=1707125004; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wnSy83ee0Rq5LtqyTNz0jRfzJC0d0snUL++URknTtSI=; b=jm39B6xG1uy61nPOkMIIorr2bf91NpmVQFjLm5pzTb6jhcRy1tIn3s2p/EXUcUfCmM pTgXa/jFjOQzyN5bkckGdXhrBFH/kS/iCFc8aInlpiobVZ8M1oH+yEMfO+7s/qf9yUQW csDHjDX8fp5FR/xj8lw/ZhC3WE/IF84yXu36wWj/AFm3gu7JWYuASYbDHa+Oulz4OHDH LvBs8CIvJuSyr7B7GZ5BHwyUul7GkldEw5oL5CbaR233CLtAqA8R7ML9Vtmaum5+Z/ZM V6ZOg/CLLMdODMCwyUrbAHWk6LHMvt7gQ+YlxQz6qT9EyhdynoXfXpy9DEME/phFzixp MWeA== X-Gm-Message-State: AOJu0YyIwygSoJRWtRbG5MsY/jnGzhNkv9wVYVZ0u5Dhj1MNuk5vflLV Ca8jBQeTBw+hEKZM5TGA3A1GSFvzT7+eGTAAHgFEcds1Npuzy1Ou9ZHofsGwEUEoM4678Yj8sFD DSz1ZhjCEvicivno5XnX3GrI5DxY= X-Google-Smtp-Source: AGHT+IFbPnH4Hbg1A3uYBw3D24utqgaH/ybq1AdUA5ys4YYPRHqpHNwPYUCMYcsCJTCO/RUqDCA1U6ufOqfgt6L6CPM= X-Received: by 2002:a17:90a:f60b:b0:291:52e:559c with SMTP id bw11-20020a17090af60b00b00291052e559cmr6293534pjb.37.1706520203668; Mon, 29 Jan 2024 01:23:23 -0800 (PST) MIME-Version: 1.0 References: <20240129092016.1176-1-jinma@linux.alibaba.com> In-Reply-To: <20240129092016.1176-1-jinma@linux.alibaba.com> From: Andrew Pinski Date: Mon, 29 Jan 2024 01:23:11 -0800 Message-ID: Subject: Re: [PATCH] RISC-V: THEAD: Fix improper immediate value for MODIFY_DISP instruction on 32-bit systems. To: Jin Ma Cc: gcc-patches@gcc.gnu.org, jeffreyalaw@gmail.com, palmer@dabbelt.com, richard.sandiford@arm.com, kito.cheng@gmail.com, christoph.muellner@vrull.eu, rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, jinma.contrib@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 29, 2024 at 1:21=E2=80=AFAM Jin Ma wr= ote: > > When using '%ld' to print 'long long int' variable, 'fprintf' will > produce messy output on a 32-bit system, in an incorrect instruction > being generated, such as 'th.lwib a1,(a0),-16,4294967295'. And the > following error occurred during compilation: > > Assembler messages: > Error: improper immediate value (18446744073709551615) > > gcc/ChangeLog: > > * config/riscv/thead.cc (th_print_operand_address): Change %ld > to %lld. > --- > gcc/config/riscv/thead.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/thead.cc b/gcc/config/riscv/thead.cc > index 2955bc5f8a9..9ee6444b627 100644 > --- a/gcc/config/riscv/thead.cc > +++ b/gcc/config/riscv/thead.cc > @@ -1141,7 +1141,7 @@ th_print_operand_address (FILE *file, machine_mode = mode, rtx x) > return true; > > case ADDRESS_REG_WB: > - fprintf (file, "(%s),%ld,%u", reg_names[REGNO (addr.reg)], > + fprintf (file, "(%s),%lld,%u", reg_names[REGNO (addr.reg)], > INTVAL (addr.offset) >> addr.shift, addr.shift); This is wrong, you should instead use HOST_WIDE_INT_PRINT_DEC or HOST_WIDE_INT_PRINT_UNSIGNED. Thanks, Andrew Pinski > return true; > > -- > 2.17.1 >