From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tHj7=6N=gmail.com=pinskia@sourceware.org>
Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f])
	by sourceware.org (Postfix) with ESMTPS id 83BE4385B510
	for <gcc-patches@gcc.gnu.org>; Fri, 17 Feb 2023 17:09:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83BE4385B510
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pl1-x62f.google.com with SMTP id f8so2155331plr.10
        for <gcc-patches@gcc.gnu.org>; Fri, 17 Feb 2023 09:09:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=WqrUVvMt1+/TIzgaCMqcpXeOpkMBgDm3rs8jQgEYJhc=;
        b=IfCodPt1sdQqIc9v/yFhCvSxlhX8YmJoXN2khHjrlx2VUiyol8FLriFHvr4gTq71xq
         G89Pq7SYPag125pk5mzrqtJz5EqGLTu+V5Ms+J9nmyytguX3eLNX3pZtKcEMalAJBleW
         OyxPRHd8TGiSDImuhQ4Lz5jY3K2YqGU6xspBJsND/c94mieWhSl2JRw4y4pR7C2eTqbq
         xntYFuOOc4rRPRgcZgAis86brmBJL/4RrF3Gedeg/Mkw6CaarG8bn2fw46aObn6tewf9
         l+pAAcy6dF0BgNTDJyLosZ6qFJZsSY8hFmiW0V0K7uR27rHw69MHnKfn9kjB3Cz5deCM
         1Kjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=WqrUVvMt1+/TIzgaCMqcpXeOpkMBgDm3rs8jQgEYJhc=;
        b=V2liLxD/iP68ZI7ZrtR8ckPZaGvSSM2ASLeKK61g9hHauCixqN7kgHGlIj3bv5aTap
         oTG6/0FiwcH+qofDA4rGIFuh46qwx3rdOe4NazmLlLJh/Psvvlk5XDJjjL3zUCd6HhC5
         AREE8fT7Z02BqrC//OPlAn56y4ze51JhtfWlZgTuzj9Jqub/TB1zqYQYBxnV5t9EKNRU
         Xq7nKxG9Qo3wxQm/ih/j/G+UfOixGVa7fhqy5OfRgS4TRAZGm0T4Y8AkB0mzMyqziT62
         YROBuNB9cr5i0YYuvQK8j+QPtVndBiiIgvRfv2tYzlOq3rFmD2nQgiBo9sh740oG9ZKM
         8tmw==
X-Gm-Message-State: AO0yUKUgmKa7kTQo5eDKkifZRXdnW6OkDYxeEuSGKgeTnna6RzxEXEES
	Zdeyuq3AbE+9BC87EbUt5C6kPh5NEQcex9ygMkA=
X-Google-Smtp-Source: AK7set/vwA1eIKPhbcdGd24I3qw9RQBWjMWHENkpsYmoo/s56bXmefIavDwJOWdBDh3eeGfjtpTsI2hpBq5219oRbic=
X-Received: by 2002:a17:903:3293:b0:19a:b151:eb8d with SMTP id
 jh19-20020a170903329300b0019ab151eb8dmr248360plb.12.1676653790330; Fri, 17
 Feb 2023 09:09:50 -0800 (PST)
MIME-Version: 1.0
References: <16fa34b8-ad8a-20f2-b285-3b3f5bf5d5b2@linux.ibm.com>
In-Reply-To: <16fa34b8-ad8a-20f2-b285-3b3f5bf5d5b2@linux.ibm.com>
From: Andrew Pinski <pinskia@gmail.com>
Date: Fri, 17 Feb 2023 09:09:38 -0800
Message-ID: <CA+=Sn1kw9aD2=7oN+C+r5TNgBZi9nshJQ+BHbe+DVnUTD=9wJw@mail.gmail.com>
Subject: Re: [PATCH] rs6000: fmr gets used instead of faster xxlor [PR93571]
To: Ajit Agarwal <aagarwa1@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, bergner@linux.ibm.com, 
	", Segher Boessenkool" <segher@kernel.crashing.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Fri, Feb 17, 2023 at 8:59 AM Ajit Agarwal via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> Hello All:
>
> This patch replaces fmr instruction (6 cycles) with xxlor instruction ( 2 cycles)
> Bootstrapped and regtested on powerpc64-linux-gnu.

I don't think this can be unconditionally replaced.
xxlor only exists in newer Power ISA.

Thanks,
Andrew Pinski

>
> copyright assignment form is still in the process of being sent.
>
> Thanks & Regards
> Ajit
>
>         rs6000: fmr gets used instead of faster xxlor [PR93571]
>
>         This patch replaces 6 cycles fmr instruction with xxlor
>         2 cycles.
>
>         2023-02-17  Ajit Kumar Agarwal  <aagarwa1@linux.ibm.com>
>
> gcc/ChangeLog:
>
>         * config/rs6000/rs6000.md (*movdf_hardfloat64): Replace fmr with xxlor instruction.
> ---
>  gcc/config/rs6000/rs6000.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
> index 4a7812fa592..dfd6c73ffcb 100644
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -8436,7 +8436,7 @@
>    "@
>     stfd%U0%X0 %1,%0
>     lfd%U1%X1 %0,%1
> -   fmr %0,%1
> +   xxlor %0,%1,%1
>     lxsd %0,%1
>     stxsd %1,%0
>     lxsdx %x0,%y1
> --
> 2.31.1
>
>