* [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE
@ 2015-12-11 19:54 Andrew Pinski
2015-12-19 3:57 ` Andrew Pinski
2015-12-21 13:31 ` Richard Earnshaw (lists)
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Pinski @ 2015-12-11 19:54 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
Hi,
The Linux kernel calls lse as atomics in /proc/cpuinfo. We should
change aarch64-option-extensions.def to take that into account.
OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions
and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
see if lse gets enabled.
Thanks,
Andrew Pinski
ChangeLog:
* config/aarch64/aarch64-option-extensions.def (LSE): Change
FEAT_STRING to "atomics".
[-- Attachment #2: fixlse.diff.txt --]
[-- Type: text/plain, Size: 792 bytes --]
Index: aarch64-option-extensions.def
===================================================================
--- aarch64-option-extensions.def (revision 231572)
+++ aarch64-option-extensions.def (working copy)
@@ -40,4 +40,4 @@ AARCH64_OPT_EXTENSION ("simd", AARCH64_F
AARCH64_FL_SIMD | AARCH64_FL_CRYPTO, "asimd")
AARCH64_OPT_EXTENSION("crypto", AARCH64_FL_CRYPTO | AARCH64_FL_FPSIMD, AARCH64_FL_CRYPTO, "aes pmull sha1 sha2")
AARCH64_OPT_EXTENSION("crc", AARCH64_FL_CRC, AARCH64_FL_CRC, "crc32")
-AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "lse")
+AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "atomics")
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE
2015-12-11 19:54 [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE Andrew Pinski
@ 2015-12-19 3:57 ` Andrew Pinski
2015-12-21 13:31 ` Richard Earnshaw (lists)
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Pinski @ 2015-12-19 3:57 UTC (permalink / raw)
To: GCC Patches
On Fri, Dec 11, 2015 at 11:54 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
> The Linux kernel calls lse as atomics in /proc/cpuinfo. We should
> change aarch64-option-extensions.def to take that into account.
>
> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions
> and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
> see if lse gets enabled.
Ping.
apinski@arm64:~/src/linux-upstream$ cat /proc/cpuinfo |head -9
processor : 0
BogoMIPS : 200.00
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics
CPU implementer : 0x43
CPU architecture: 8
CPU variant : 0x1
CPU part : 0x0a1
CPU revision : 0
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * config/aarch64/aarch64-option-extensions.def (LSE): Change
> FEAT_STRING to "atomics".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE
2015-12-11 19:54 [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE Andrew Pinski
2015-12-19 3:57 ` Andrew Pinski
@ 2015-12-21 13:31 ` Richard Earnshaw (lists)
1 sibling, 0 replies; 3+ messages in thread
From: Richard Earnshaw (lists) @ 2015-12-21 13:31 UTC (permalink / raw)
To: Andrew Pinski, GCC Patches; +Cc: Matthew Wahab
On 11/12/15 19:54, Andrew Pinski wrote:
> Hi,
> The Linux kernel calls lse as atomics in /proc/cpuinfo. We should
> change aarch64-option-extensions.def to take that into account.
>
> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions
> and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
> see if lse gets enabled.
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * config/aarch64/aarch64-option-extensions.def (LSE): Change
> FEAT_STRING to "atomics".
>
Matthew checked in the original patch and he's currently on vacation, so
I can't check why he put 'lse' here. However, I've checked with the
kernel team and they've confirmed that 'atomics' is correct, so OK.
R.
>
> fixlse.diff.txt
>
>
> Index: aarch64-option-extensions.def
> ===================================================================
> --- aarch64-option-extensions.def (revision 231572)
> +++ aarch64-option-extensions.def (working copy)
> @@ -40,4 +40,4 @@ AARCH64_OPT_EXTENSION ("simd", AARCH64_F
> AARCH64_FL_SIMD | AARCH64_FL_CRYPTO, "asimd")
> AARCH64_OPT_EXTENSION("crypto", AARCH64_FL_CRYPTO | AARCH64_FL_FPSIMD, AARCH64_FL_CRYPTO, "aes pmull sha1 sha2")
> AARCH64_OPT_EXTENSION("crc", AARCH64_FL_CRC, AARCH64_FL_CRC, "crc32")
> -AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "lse")
> +AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "atomics")
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-21 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 19:54 [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE Andrew Pinski
2015-12-19 3:57 ` Andrew Pinski
2015-12-21 13:31 ` Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).