From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104415 invoked by alias); 20 Jun 2017 21:07:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 104399 invoked by uid 89); 20 Jun 2017 21:07:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=PLUS X-HELO: mail-yw0-f179.google.com Received: from mail-yw0-f179.google.com (HELO mail-yw0-f179.google.com) (209.85.161.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 21:07:24 +0000 Received: by mail-yw0-f179.google.com with SMTP id e142so57383037ywa.1 for ; Tue, 20 Jun 2017 14:07:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dsnpAMuf7jgcTOjd1LrNYUQiS9kb5+ZhsKo+LBu9v+s=; b=flvoQWFyzA2TSAkncLqh92EFBQRwYC7bEF5IZYeG/xOrciP/LZrjvD+qeSml1owy6F 3swZSp4LPePlhFLcSVguPCruV7DhMBWpLD6esy+wOil7ycrg93KUB6pyReoAe6y2sbhQ x8cuNIwZQjkfKuv7R/Zft6gpGczUq35wCzWi5Wy4jgPQFfMvnuc+dFr77B9BoFe7kFXB x5YLsGxlI7x1mLDdZaUZ9t3mbVrhaGZ3QOA+SMWTjGH5VFj2vlkrxfCVOYB/SGQ3l5Bt 9ICTToVvy62NdbDvftRyM5dvnc8EocmEkIn6U8uagMKpFxpW/djXctQWSi5JIHewpdU7 0fVQ== X-Gm-Message-State: AKS2vOyu3rpxZWIWvYgKUGs+zQ/4k4pGBTKltktjZrdk0LOWx298geYz OC6WsPkro0BaMvGIMGFnAu9bTGhxcg== X-Received: by 10.13.236.131 with SMTP id v125mr3448406ywe.77.1497992842690; Tue, 20 Jun 2017 14:07:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.47.200 with HTTP; Tue, 20 Jun 2017 14:07:22 -0700 (PDT) In-Reply-To: References: <20170607171603.GA36988@arm.com> From: Andrew Pinski Date: Tue, 20 Jun 2017 21:07:00 -0000 Message-ID: Subject: Re: [PATCH/AARCH64] Improve/correct ThunderX 1 cost model for Arith_shift To: James Greenhalgh Cc: GCC Patches , nd Content-Type: multipart/mixed; boundary="94eb2c083958440c7c05526aa3c8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01514.txt.bz2 --94eb2c083958440c7c05526aa3c8 Content-Type: text/plain; charset="UTF-8" Content-length: 4011 On Mon, Jun 19, 2017 at 2:00 PM, Andrew Pinski wrote: > On Wed, Jun 7, 2017 at 10:16 AM, James Greenhalgh > wrote: >> On Fri, Dec 30, 2016 at 10:05:26PM -0800, Andrew Pinski wrote: >>> Hi, >>> Currently for the following function: >>> int f(int a, int b) >>> { >>> return a + (b <<7); >>> } >>> >>> GCC produces: >>> add w0, w0, w1, lsl 7 >>> But for ThunderX 1, it is better if the instruction was split allowing >>> better scheduling to happen in most cases, the latency is the same. I >>> get a small improvement in coremarks, ~1%. >>> >>> Currently the code does not take into account Arith_shift even though >>> the comment: >>> /* Strip any extend, leave shifts behind as we will >>> cost them through mult_cost. */ >>> Say it does not strip out the shift, aarch64_strip_extend does and has >>> always has since the back-end was added to GCC. >>> >>> Once I fixed the code around aarch64_strip_extend, I got a regression >>> for ThunderX 1 as some shifts/extends (left shifts <=4 and/or zero >>> extends) are considered free so I needed to add a new tuning flag. >>> >>> Note I will get an even more improvement for ThunderX 2 CN99XX, but I >>> have not measured it yet as I have not made the change to >>> aarch64-cost-tables.h yet as I am waiting for approval of the renaming >>> patch first before submitting any of the cost table changes. Also I >>> noticed this problem with this tuning first and then looked back at >>> what I needed to do for ThunderX 1. >>> >>> OK? Bootstrapped and tested on aarch64-linux-gnu without any >>> regressions (both with and without --with-cpu=thunderx). >> >> This is mostly OK, but I don't like the name "easy"_shift_extend. Cheap >> or free seems better. I have some other minor points below. > > > Ok, that seems like a good idea. I used easy since that was the > wording our hardware folks had came up with. I am changing the > comments to make clearer when this flag should be used. > I should a new patch out by the end of today. Due to the LSE ICE which I reported in the other thread, it took me longer to send out a new patch. Anyways here is the updated patch with the changes requested. OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. Thanks, Andrew Pinski * config/aarch64/aarch64-cost-tables.h (thunderx_extra_costs): Increment Arith_shift and Arith_shift_reg by 1. * config/aarch64/aarch64-tuning-flags.def (cheap_shift_extend): New tuning flag. * config/aarch64/aarch64.c (thunderx_tunings): Enable AARCH64_EXTRA_TUNE_CHEAP_SHIFT_EXTEND. (aarch64_strip_extend): Add new argument and test for it. (aarch64_cheap_mult_shift_p): New function. (aarch64_rtx_mult_cost): Call aarch64_cheap_mult_shift_p and don't add a cost if it is true. Update calls to aarch64_strip_extend. (aarch64_rtx_costs): Update calls to aarch64_strip_extend. > > Thanks, > Andrew > > >> >>> Index: config/aarch64/aarch64-tuning-flags.def >>> =================================================================== >>> --- config/aarch64/aarch64-tuning-flags.def (revision 243974) >>> +++ config/aarch64/aarch64-tuning-flags.def (working copy) >>> @@ -35,4 +35,8 @@ two load/stores are not at least 8 byte >>> pairs. */ >>> AARCH64_EXTRA_TUNING_OPTION ("slow_unaligned_ldpw", SLOW_UNALIGNED_LDPW) >>> >>> +/* Logical shift left <=4 with/without zero extend are considered easy >>> + extended, also zero extends without the shift. */ >> >> >> I'm struggling to parse this comment. "also zero extends without the shift" >> is what is getting me. I'm also not certain I follow when I should set this >> flag. If all shifts are cheap/free on my platform, should I set this flag? >> >>> +AARCH64_EXTRA_TUNING_OPTION ("easy_shift_extend", EASY_SHIFT_EXTEND) >>> + >>> #undef AARCH64_EXTRA_TUNING_OPTION >> >> >>> + >>> +/* Return true iff X is an easy shift without a sign extend. */ >>> + >> >> Again I don't like calling <= 4 "easy", it feels imprecise. >> >> Thanks, >> James >> --94eb2c083958440c7c05526aa3c8 Content-Type: text/plain; charset="US-ASCII"; name="improvecost.diff.txt" Content-Disposition: attachment; filename="improvecost.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j46282wi0 Content-length: 7772 SW5kZXg6IGdjYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LWNvc3QtdGFibGVz LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ2NjL2NvbmZpZy9hYXJj aDY0L2FhcmNoNjQtY29zdC10YWJsZXMuaAkocmV2aXNpb24gMjQ5NDI0KQor KysgZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQtY29zdC10YWJsZXMuaAko d29ya2luZyBjb3B5KQpAQCAtMTM2LDggKzEzNiw4IEBAIGNvbnN0IHN0cnVj dCBjcHVfY29zdF90YWJsZSB0aHVuZGVyeF9leHQKICAgICAwLAkJCS8qIExv Z2ljYWwuICAqLwogICAgIDAsCQkJLyogU2hpZnQuICAqLwogICAgIDAsCQkJ LyogU2hpZnRfcmVnLiAgKi8KLSAgICBDT1NUU19OX0lOU05TICgxKSwJLyog QXJpdGhfc2hpZnQuICAqLwotICAgIENPU1RTX05fSU5TTlMgKDEpLAkvKiBB cml0aF9zaGlmdF9yZWcuICAqLworICAgIENPU1RTX05fSU5TTlMgKDEpKzEs CS8qIEFyaXRoX3NoaWZ0LiAgKi8KKyAgICBDT1NUU19OX0lOU05TICgxKSsx LAkvKiBBcml0aF9zaGlmdF9yZWcuICAqLwogICAgIENPU1RTX05fSU5TTlMg KDEpLAkvKiBVTlVTRUQ6IExvZ19zaGlmdC4gICovCiAgICAgQ09TVFNfTl9J TlNOUyAoMSksCS8qIFVOVVNFRDogTG9nX3NoaWZ0X3JlZy4gICovCiAgICAg MCwJCQkvKiBFeHRlbmQuICAqLwpJbmRleDogZ2NjL2NvbmZpZy9hYXJjaDY0 L2FhcmNoNjQtdHVuaW5nLWZsYWdzLmRlZgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBnY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC10dW5pbmctZmxh Z3MuZGVmCShyZXZpc2lvbiAyNDk0MjQpCisrKyBnY2MvY29uZmlnL2FhcmNo NjQvYWFyY2g2NC10dW5pbmctZmxhZ3MuZGVmCSh3b3JraW5nIGNvcHkpCkBA IC0zNSw0ICszNSwxMCBAQCB0d28gbG9hZC9zdG9yZXMgYXJlIG5vdCBhdCBs ZWFzdCA4IGJ5dGUKIHBhaXJzLiAgICovCiBBQVJDSDY0X0VYVFJBX1RVTklO R19PUFRJT04gKCJzbG93X3VuYWxpZ25lZF9sZHB3IiwgU0xPV19VTkFMSUdO RURfTERQVykKIAorLyogU29tZSBvZiB0aGUgb3B0aW9uYWwgc2hpZnQgdG8g c29tZSBhcnRoZW1hdGljIGluc3RydWN0aW9ucyBhcmUKKyAgIGNvbnNpZGVy ZWQgY2hlYXAuICBMb2dpY2FsIHNoaWZ0IGxlZnQgPD00IHdpdGggb3Igd2l0 aG91dCBhCisgICB6ZXJvIGV4dGVuZCBhcmUgY29uc2lkZXJlZCBjaGVhcC4g IFNpZ24gZXh0ZW5kOyBub24gbG9naWNhbCBzaGlmdCBsZWZ0CisgICBhcmUg bm90IGNvbnNpZGVyZWQgY2hlYXAuICAqLworQUFSQ0g2NF9FWFRSQV9UVU5J TkdfT1BUSU9OICgiY2hlYXBfc2hpZnRfZXh0ZW5kIiwgQ0hFQVBfU0hJRlRf RVhURU5EKQorCiAjdW5kZWYgQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9O CkluZGV4OiBnY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGdjYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0 LmMJKHJldmlzaW9uIDI0OTQyNCkKKysrIGdjYy9jb25maWcvYWFyY2g2NC9h YXJjaDY0LmMJKHdvcmtpbmcgY29weSkKQEAgLTc2Niw3ICs3NjYsOCBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IHR1bmVfcGFyYW1zIHRodW5kZXJ4CiAgIDIs CS8qIG1pbl9kaXZfcmVjaXBfbXVsX2RmLiAgKi8KICAgMCwJLyogbWF4X2Nh c2VfdmFsdWVzLiAgKi8KICAgdHVuZV9wYXJhbXM6OkFVVE9QUkVGRVRDSEVS X09GRiwJLyogYXV0b3ByZWZldGNoZXJfbW9kZWwuICAqLwotICAoQUFSQ0g2 NF9FWFRSQV9UVU5FX1NMT1dfVU5BTElHTkVEX0xEUFcpLAkvKiB0dW5lX2Zs YWdzLiAgKi8KKyAgKEFBUkNINjRfRVhUUkFfVFVORV9TTE9XX1VOQUxJR05F RF9MRFBXCisgICB8IEFBUkNINjRfRVhUUkFfVFVORV9DSEVBUF9TSElGVF9F WFRFTkQpLAkvKiB0dW5lX2ZsYWdzLiAgKi8KICAgJmdlbmVyaWNfcHJlZmV0 Y2hfdHVuZQogfTsKIApAQCAtNjA3Nyw5ICs2MDc4LDEwIEBAIGFhcmNoNjRf c3RyaXBfc2hpZnQgKHJ0eCB4KQogLyogSGVscGVyIGZ1bmN0aW9uIGZvciBy dHggY29zdCBjYWxjdWxhdGlvbi4gIFN0cmlwIGFuIGV4dGVuZAogICAgZXhw cmVzc2lvbiBmcm9tIFguICBSZXR1cm5zIHRoZSBpbm5lciBvcGVyYW5kIGlm IHN1Y2Nlc3NmdWwsIG9yIHRoZQogICAgb3JpZ2luYWwgZXhwcmVzc2lvbiBv biBmYWlsdXJlLiAgV2UgZGVhbCB3aXRoIGEgbnVtYmVyIG9mIHBvc3NpYmxl Ci0gICBjYW5vbmljYWxpemF0aW9uIHZhcmlhdGlvbnMgaGVyZS4gICovCisg ICBjYW5vbmljYWxpemF0aW9uIHZhcmlhdGlvbnMgaGVyZS4gSWYgU1RSSVBf U0hJRlQgaXMgdHJ1ZSwgdGhlbgorICAgd2UgY2FuIHN0cmlwIG9mZiBhIHNo aWZ0IGFsc28uICAqLwogc3RhdGljIHJ0eAotYWFyY2g2NF9zdHJpcF9leHRl bmQgKHJ0eCB4KQorYWFyY2g2NF9zdHJpcF9leHRlbmQgKHJ0eCB4LCBib29s IHN0cmlwX3NoaWZ0KQogewogICBydHggb3AgPSB4OwogCkBAIC02MTAzLDcg KzYxMDUsOCBAQCBhYXJjaDY0X3N0cmlwX2V4dGVuZCAocnR4IHgpCiAKICAg LyogTm93IGhhbmRsZSBleHRlbmRlZCByZWdpc3RlciwgYXMgdGhpcyBtYXkg YWxzbyBoYXZlIGFuIG9wdGlvbmFsCiAgICAgIGxlZnQgc2hpZnQgYnkgMS4u NC4gICovCi0gIGlmIChHRVRfQ09ERSAob3ApID09IEFTSElGVAorICBpZiAo c3RyaXBfc2hpZnQKKyAgICAgICYmIEdFVF9DT0RFIChvcCkgPT0gQVNISUZU CiAgICAgICAmJiBDT05TVF9JTlRfUCAoWEVYUCAob3AsIDEpKQogICAgICAg JiYgKCh1bnNpZ25lZCBIT1NUX1dJREVfSU5UKSBJTlRWQUwgKFhFWFAgKG9w LCAxKSkpIDw9IDQpCiAgICAgb3AgPSBYRVhQIChvcCwgMCk7CkBAIC02MTI3 LDYgKzYxMzAsMzkgQEAgYWFyY2g2NF9zaGlmdF9wIChlbnVtIHJ0eF9jb2Rl IGNvZGUpCiAgIHJldHVybiBjb2RlID09IEFTSElGVCB8fCBjb2RlID09IEFT SElGVFJUIHx8IGNvZGUgPT0gTFNISUZUUlQ7CiB9CiAKKworLyogUmV0dXJu IHRydWUgaWZmIFggaXMgYW4gY2hlYXAgc2hpZnQgd2l0aG91dCBhIHNpZ24g ZXh0ZW5kLiAqLworCitzdGF0aWMgYm9vbAorYWFyY2g2NF9jaGVhcF9tdWx0 X3NoaWZ0X3AgKHJ0eCB4KQoreworICBydHggb3AwLCBvcDE7CisKKyAgb3Aw ID0gWEVYUCAoeCwgMCk7CisgIG9wMSA9IFhFWFAgKHgsIDEpOworCisgIGlm ICghKGFhcmNoNjRfdHVuZV9wYXJhbXMuZXh0cmFfdHVuaW5nX2ZsYWdzCisg ICAgICAgICAgICAgICAgICAgICAgJiBBQVJDSDY0X0VYVFJBX1RVTkVfQ0hF QVBfU0hJRlRfRVhURU5EKSkKKyAgICByZXR1cm4gZmFsc2U7CisKKyAgaWYg KEdFVF9DT0RFIChvcDApID09IFNJR05fRVhURU5EKQorICAgIHJldHVybiBm YWxzZTsKKworICBpZiAoR0VUX0NPREUgKHgpID09IEFTSElGVCAmJiBDT05T VF9JTlRfUCAob3AxKQorICAgICAgJiYgVUlOVFZBTCAob3AxKSA8PSA0KQor ICAgIHJldHVybiB0cnVlOworCisgIGlmIChHRVRfQ09ERSAoeCkgIT0gTVVM VCB8fCAhQ09OU1RfSU5UX1AgKG9wMSkpCisgICAgcmV0dXJuIGZhbHNlOwor CisgIEhPU1RfV0lERV9JTlQgbDIgPSBleGFjdF9sb2cyIChJTlRWQUwgKG9w MSkpOworCisgIGlmIChsMiA+IDAgJiYgbDIgPD0gNCkKKyAgICByZXR1cm4g dHJ1ZTsKKworICByZXR1cm4gZmFsc2U7Cit9CisKIC8qIEhlbHBlciBmdW5j dGlvbiBmb3IgcnR4IGNvc3QgY2FsY3VsYXRpb24uICBDYWxjdWxhdGUgdGhl IGNvc3Qgb2YKICAgIGEgTVVMVCBvciBBU0hJRlQsIHdoaWNoIG1heSBiZSBw YXJ0IG9mIGEgY29tcG91bmQgUExVUy9NSU5VUyBydHguCiAgICBSZXR1cm4g dGhlIGNhbGN1bGF0ZWQgY29zdCBvZiB0aGUgZXhwcmVzc2lvbiwgcmVjdXJz aW5nIG1hbnVhbGx5IGluIHRvCkBAIC02MTY0LDcgKzYyMDAsMTEgQEAgYWFy Y2g2NF9ydHhfbXVsdF9jb3N0IChydHggeCwgZW51bSBydHhfYwogCSAgICB7 CiAJICAgICAgaWYgKGNvbXBvdW5kX3ApCiAJICAgICAgICB7Ci0JICAgICAg ICAgIGlmIChSRUdfUCAob3AxKSkKKwkJICAvKiBJZiB0aGUgc2hpZnQgaXMg Y29uc2lkZXJlZCBjaGVhcCwKKwkJICAgICB0aGVuIGRvbid0IGFkZCBhbnkg Y29zdC4gKi8KKwkJICBpZiAoYWFyY2g2NF9jaGVhcF9tdWx0X3NoaWZ0X3Ag KHgpKQorCQkgICAgOworCSAgICAgICAgICBlbHNlIGlmIChSRUdfUCAob3Ax KSkKIAkJICAgIC8qIEFSSVRIICsgc2hpZnQtYnktcmVnaXN0ZXIuICAqLwog CQkgICAgY29zdCArPSBleHRyYV9jb3N0LT5hbHUuYXJpdGhfc2hpZnRfcmVn OwogCQkgIGVsc2UgaWYgKGlzX2V4dGVuZCkKQEAgLTYxODIsNyArNjIyMiw3 IEBAIGFhcmNoNjRfcnR4X211bHRfY29zdCAocnR4IHgsIGVudW0gcnR4X2MK IAkgICAgfQogCSAgLyogU3RyaXAgZXh0ZW5kcyBhcyB3ZSB3aWxsIGhhdmUg Y29zdGVkIHRoZW0gaW4gdGhlIGNhc2UgYWJvdmUuICAqLwogCSAgaWYgKGlz X2V4dGVuZCkKLQkgICAgb3AwID0gYWFyY2g2NF9zdHJpcF9leHRlbmQgKG9w MCk7CisJICAgIG9wMCA9IGFhcmNoNjRfc3RyaXBfZXh0ZW5kIChvcDAsIHRy dWUpOwogCiAJICBjb3N0ICs9IHJ0eF9jb3N0IChvcDAsIFZPSURtb2RlLCBj b2RlLCAwLCBzcGVlZCk7CiAKQEAgLTcwMjYsMTMgKzcwNjYsMTMgQEAgY29z dF9taW51czoKIAkgICAgaWYgKHNwZWVkKQogCSAgICAgICpjb3N0ICs9IGV4 dHJhX2Nvc3QtPmFsdS5leHRlbmRfYXJpdGg7CiAKLQkgICAgb3AxID0gYWFy Y2g2NF9zdHJpcF9leHRlbmQgKG9wMSk7CisJICAgIG9wMSA9IGFhcmNoNjRf c3RyaXBfZXh0ZW5kIChvcDEsIHRydWUpOwogCSAgICAqY29zdCArPSBydHhf Y29zdCAob3AxLCBWT0lEbW9kZSwKIAkJCSAgICAgICAoZW51bSBydHhfY29k ZSkgR0VUX0NPREUgKG9wMSksIDAsIHNwZWVkKTsKIAkgICAgcmV0dXJuIHRy dWU7CiAJICB9CiAKLQlydHggbmV3X29wMSA9IGFhcmNoNjRfc3RyaXBfZXh0 ZW5kIChvcDEpOworCXJ0eCBuZXdfb3AxID0gYWFyY2g2NF9zdHJpcF9leHRl bmQgKG9wMSwgZmFsc2UpOwogCiAJLyogQ29zdCB0aGlzIGFzIGFuIEZNQS1h bGlrZSBvcGVyYXRpb24uICAqLwogCWlmICgoR0VUX0NPREUgKG5ld19vcDEp ID09IE1VTFQKQEAgLTcxMDUsNyArNzE0NSw3IEBAIGNvc3RfcGx1czoKIAkg ICAgaWYgKHNwZWVkKQogCSAgICAgICpjb3N0ICs9IGV4dHJhX2Nvc3QtPmFs dS5leHRlbmRfYXJpdGg7CiAKLQkgICAgb3AwID0gYWFyY2g2NF9zdHJpcF9l eHRlbmQgKG9wMCk7CisJICAgIG9wMCA9IGFhcmNoNjRfc3RyaXBfZXh0ZW5k IChvcDAsIHRydWUpOwogCSAgICAqY29zdCArPSBydHhfY29zdCAob3AwLCBW T0lEbW9kZSwKIAkJCSAgICAgICAoZW51bSBydHhfY29kZSkgR0VUX0NPREUg KG9wMCksIDAsIHNwZWVkKTsKIAkgICAgcmV0dXJuIHRydWU7CkBAIC03MTEz LDcgKzcxNTMsNyBAQCBjb3N0X3BsdXM6CiAKIAkvKiBTdHJpcCBhbnkgZXh0 ZW5kLCBsZWF2ZSBzaGlmdHMgYmVoaW5kIGFzIHdlIHdpbGwKIAkgICBjb3N0 IHRoZW0gdGhyb3VnaCBtdWx0X2Nvc3QuICAqLwotCW5ld19vcDAgPSBhYXJj aDY0X3N0cmlwX2V4dGVuZCAob3AwKTsKKwluZXdfb3AwID0gYWFyY2g2NF9z dHJpcF9leHRlbmQgKG9wMCwgZmFsc2UpOwogCiAJaWYgKEdFVF9DT0RFIChu ZXdfb3AwKSA9PSBNVUxUCiAJICAgIHx8IGFhcmNoNjRfc2hpZnRfcCAoR0VU X0NPREUgKG5ld19vcDApKSkK --94eb2c083958440c7c05526aa3c8--