From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id A9B933858D20 for ; Sun, 21 May 2023 03:28:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9B933858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-25345ca8748so3989480a91.1 for ; Sat, 20 May 2023 20:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684639695; x=1687231695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HtGlj0tIh8Y55RCbzhZEadIhPl8ztlN6NCH0N5AOIiM=; b=QzrV3CmxYoOprd809Yn6N3q6wFqf420wTK8L1vyNJEp0qLEMOXOzFCM8qf7EU/bPCL YDu95YtpsOy90oagQAKRJYzoh9H9cV5moI6OgAA479oLBEIybleiaT2Zd0DZULBOr0wH rdi/QplJWpX1YfLmoN0Wl8pdFMtFIb4Bsatug8oN+TLmC7ZsUddFXEaWYh7rYTBihfZH sLsvjfobrLoTRqEnjGWtrEh0dtUpF6gniL+wp845U287X6P3E4mKCmYxXu+aNZMvUBxZ 9mLWdXnzuLWYZ1K6JcHr7/lej40bKsoOkmltTda2czVXIbRzDBaovYO9NsjflyVFMnoH D4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684639695; x=1687231695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HtGlj0tIh8Y55RCbzhZEadIhPl8ztlN6NCH0N5AOIiM=; b=QPphmjqmZ2vx0mo1jIhwAb+QoHa9v8RpeVSCrlP0trAgRW+FkA/pum1FMcIFNxK5Iy xOVSoURx/xkHsrkjSSgzsskSEzYoHOK5Vy/XOC3m1J2TqdcBaH8Ym67AIlCRgIXDYzzp 19MJYRppVsSdWZ3uIZBPnRB9gu2wapo8sji9H1f72EYWpjx6v1o7C2CHw70XZAG/lXyf tkdlHrnbb6z9BqEd8+kwzkV5TLFW6Dsu+XaUu3qKleqJhq14IbAsfstnoo2gPCjGGF1l axahzlvvVoxL96lSMG6J8eZs7LCGozfSgr2H6IwnpXSJpJAUWRPkkz4vdWgyZes1jl9V bKtA== X-Gm-Message-State: AC+VfDwBxG/LszlD4E1/VIQj3yaFMmxC4wpW4ohsNPKDV9y6dbzn6Vxr 3rOEoGn9oAMggqWfUWVTGimFC2haS9cb7rZpCVk= X-Google-Smtp-Source: ACHHUZ5SBm1MI9Fx9BJKBsmHe9K6M5zfu/sq1jp9ZC5JFNv0FK/BgK6a5T/Pl/hN+zu//zkg1dgoJJaQAEKY/frYJ3s= X-Received: by 2002:a17:90a:b94c:b0:24e:df1:df8 with SMTP id f12-20020a17090ab94c00b0024e0df10df8mr5828415pjw.49.1684639694626; Sat, 20 May 2023 20:28:14 -0700 (PDT) MIME-Version: 1.0 References: <20230521010949.1957550-1-apinski@marvell.com> <8110c2f0-cf70-3360-b59a-5f1df798cebd@gmail.com> In-Reply-To: <8110c2f0-cf70-3360-b59a-5f1df798cebd@gmail.com> From: Andrew Pinski Date: Sat, 20 May 2023 20:28:02 -0700 Message-ID: Subject: Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, May 20, 2023 at 8:25=E2=80=AFPM Jeff Law wr= ote: > > > > On 5/20/23 21:05, Andrew Pinski wrote: > > On Sat, May 20, 2023 at 6:26=E2=80=AFPM Jeff Law via Gcc-patches > > wrote: > >> > >> > >> > >> On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: > >>> The problem is I used expand_expr with the target but > >>> we don't want to use the target here as it is the wrong > >>> mode for the original expression. The testcase would ICE > >>> deap down while trying to do a move to use the target. > >>> Anyways just calling expand_expr with NULL_EXPR fixes > >>> the issue. > >>> > >>> Committed as obvious after a bootstrap/test on x86_64-linux-gnu. > >>> > >>> PR middle-end/109919 > >>> > >>> gcc/ChangeLog: > >>> > >>> * expr.cc (expand_single_bit_test): Don't use the > >>> target for expand_expr. > >>> > >>> gcc/testsuite/ChangeLog: > >>> > >>> * gcc.c-torture/compile/pr109919-1.c: New test. > >> Thanks. I'll respin the targets that failed. If you don't hear from > >> me, assume everything is happy again after this fix. > > > > Oh, I am going to test on aarch64-linux-gnu too just in case. > > Expand is definitely something which I am not used to working on so I > > figured I had made a mistake somewhere. I suspect I still made a > > similar mistake later on too. > I'm seeing some execution failures. Building H8 bits now to debug as > it's the target I'm most familiar with. More info as it's available. Is H8 big-endian? I could have messed that up. Thanks, Andrew Pinski > > jeff