public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: George Thomas <georgethomas.mec@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFC, middlend] Fix for PR54218
Date: Fri, 11 Jan 2013 16:23:00 -0000	[thread overview]
Message-ID: <CA+=Sn1mBjo2kDw7HVDCiRQqQ9--qxjAJR7aKvtgSa8mBLP9nuA@mail.gmail.com> (raw)
In-Reply-To: <CAKJOuMrHAEHyt4fwd4oJnQT_754dbSjijv6TgCAyd2LsxZL1ww@mail.gmail.com>

On Fri, Jan 11, 2013 at 8:17 AM, George Thomas
<georgethomas.mec@gmail.com> wrote:
> Hi,
>
> I am sending a patch which solves the debugging issue (PR 54218).
>
> The fix is to allocate stack space only once for parameters in expand pass.
>
> The patch is attached. Could someone suggest if its right ?

I have just a formatting issue:
+         if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL)
+          {
+            if (!bitmap_bit_p (SA.partition_has_default_def, i))

I think it would have been better if you had done instead:
	  if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL
             && !bitmap_bit_p (SA.partition_has_default_def, i))

So there are no other white space changes.

Also missing a changelog entry too.

Thanks,
Andrew

  reply	other threads:[~2013-01-11 16:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 16:17 George Thomas
2013-01-11 16:23 ` Andrew Pinski [this message]
2013-01-11 17:37   ` George Thomas
2013-01-14 14:42     ` Richard Biener
2013-01-16 18:36       ` George Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1mBjo2kDw7HVDCiRQqQ9--qxjAJR7aKvtgSa8mBLP9nuA@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=georgethomas.mec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).