From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZqSk=EV=gmail.com=pinskia@sourceware.org>
Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529])
	by sourceware.org (Postfix) with ESMTPS id 3D11F385AC26
	for <gcc-patches@gcc.gnu.org>; Tue,  5 Sep 2023 21:42:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D11F385AC26
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-56963f2e48eso1666704a12.1
        for <gcc-patches@gcc.gnu.org>; Tue, 05 Sep 2023 14:42:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1693950171; x=1694554971; darn=gcc.gnu.org;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=/DfUi1E3zmrZCN9he6Ie4k0uijdZWlzYtC72gVngSkw=;
        b=KPIGrCtsbJmybq45qR2HBsWJh6c8Lw1pgjFoAaC0l+bQ/cHidau69+V3d13nZQnrx2
         aiIIciqwBzCpFHIug0pDPFrn+e3A+tENRBfxaTsTeEF4ziBFySQoXwztHfWzMOcQrZjE
         8lBZdZJ4odDe8yl1dAAy4+X6JzTLV/NiiuD4nX7CXeQ0hlL0tMQ/uoxfk1Y9lLHAlTw+
         JIuhRhsjInYiCh4eoCHV+2BFGkDMoZrSODTTZiar8CYW0se24TCqhMhDt1eOBS1UH5yg
         HbXXMRDV5lTP7gP0PNlgzl18iwjJL4KI7pOfO4xaUCOXHEuj11XuORsehGW77Kmygbsj
         Mrng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1693950171; x=1694554971;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=/DfUi1E3zmrZCN9he6Ie4k0uijdZWlzYtC72gVngSkw=;
        b=jfwRiGqLSVk9wHG0LTgTDXeDndSN1nrHHTSamO5bCGwxz9mwwFglSIcbm8qY5Jwpqg
         TGkRF9YP+porLGKA7gZJXYfXUmF12AnNb9i0xFhcSPcIlAj8oSbcUV1hBzSwd403hwZH
         QnuRKbeqSlmQUooQhxauL8tBceihVXGmuWaLPPQeYVAhmc24V5bvnAH4taIpFQSZLFWz
         SWbD5jlC7ZvmO7bDiNfwWqYeQgThWiGQOD7XbMTmAE5kRZhWynIGx4yIIP3t4hl364l2
         tB3mm9aYgb2708WCDxutYwaCaj6KnMZ1Z76oO7BoZ7POOFwxgYmugzQRwicWSbbvJN8Q
         6zHw==
X-Gm-Message-State: AOJu0Yy/VZE6dOMqX6qg464O6I+lxTdkKv3dWko1I2kTRb1vOGw6CCFP
	5v1cyrEOMfRsdOMWApgDjf1jVCVj6xkszA2Gzi4=
X-Google-Smtp-Source: AGHT+IHaocEaJ3bHPYz7Ez97sjQzzBsUeVRZiyn94rq6o7XLY7/+S/Kat3O99axCX833QFS4V0JSgKnqJ3D1tPwZw2U=
X-Received: by 2002:a17:90a:a602:b0:267:faba:705 with SMTP id
 c2-20020a17090aa60200b00267faba0705mr10099597pjq.10.1693950171125; Tue, 05
 Sep 2023 14:42:51 -0700 (PDT)
MIME-Version: 1.0
References: <ZPbZGGqmV8L+/rni@tucnak>
In-Reply-To: <ZPbZGGqmV8L+/rni@tucnak>
From: Andrew Pinski <pinskia@gmail.com>
Date: Tue, 5 Sep 2023 14:42:39 -0700
Message-ID: <CA+=Sn1mO2NW4pqRXtD4qcr+hdfJ_fB4C1ES-57dD47vWxbqLXg@mail.gmail.com>
Subject: Re: [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989]
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Sep 5, 2023 at 12:31=E2=80=AFAM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi!
>
> Recent match.pd changes trigger ICE in build_minus_one_cst, apparently
> I forgot to handle BITINT_TYPE in these (while I've handled it in
> build_zero_cst).
>
> Will commit as obvious together with the rest of the series when the last
> patches are approved.

I assume there was a testcase that will be added when _BitInt
front-end support gets added.

Thanks,
Andrew

>
> 2023-09-05  Jakub Jelinek  <jakub@redhat.com>
>
>         PR c/102989
>         * tree.cc (build_one_cst, build_minus_one_cst): Handle BITINT_TYP=
E
>         like INTEGER_TYPE.
>
> --- gcc/tree.cc.jj      2023-09-04 09:45:33.444059843 +0200
> +++ gcc/tree.cc 2023-09-05 08:57:31.420059962 +0200
> @@ -2546,7 +2546,7 @@ build_one_cst (tree type)
>      {
>      case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
>      case POINTER_TYPE: case REFERENCE_TYPE:
> -    case OFFSET_TYPE:
> +    case OFFSET_TYPE: case BITINT_TYPE:
>        return build_int_cst (type, 1);
>
>      case REAL_TYPE:
> @@ -2599,7 +2599,7 @@ build_minus_one_cst (tree type)
>      {
>      case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
>      case POINTER_TYPE: case REFERENCE_TYPE:
> -    case OFFSET_TYPE:
> +    case OFFSET_TYPE: case BITINT_TYPE:
>        return build_int_cst (type, -1);
>
>      case REAL_TYPE:
>
>         Jakub
>