* [PATCH 18/12] Handle BITINT_TYPE in build_{,minus_}one_cst [PR102989]
@ 2023-09-05 7:30 Jakub Jelinek
2023-09-05 21:42 ` [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989] Andrew Pinski
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2023-09-05 7:30 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
Hi!
Recent match.pd changes trigger ICE in build_minus_one_cst, apparently
I forgot to handle BITINT_TYPE in these (while I've handled it in
build_zero_cst).
Will commit as obvious together with the rest of the series when the last
patches are approved.
2023-09-05 Jakub Jelinek <jakub@redhat.com>
PR c/102989
* tree.cc (build_one_cst, build_minus_one_cst): Handle BITINT_TYPE
like INTEGER_TYPE.
--- gcc/tree.cc.jj 2023-09-04 09:45:33.444059843 +0200
+++ gcc/tree.cc 2023-09-05 08:57:31.420059962 +0200
@@ -2546,7 +2546,7 @@ build_one_cst (tree type)
{
case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
case POINTER_TYPE: case REFERENCE_TYPE:
- case OFFSET_TYPE:
+ case OFFSET_TYPE: case BITINT_TYPE:
return build_int_cst (type, 1);
case REAL_TYPE:
@@ -2599,7 +2599,7 @@ build_minus_one_cst (tree type)
{
case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
case POINTER_TYPE: case REFERENCE_TYPE:
- case OFFSET_TYPE:
+ case OFFSET_TYPE: case BITINT_TYPE:
return build_int_cst (type, -1);
case REAL_TYPE:
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989]
2023-09-05 7:30 [PATCH 18/12] Handle BITINT_TYPE in build_{,minus_}one_cst [PR102989] Jakub Jelinek
@ 2023-09-05 21:42 ` Andrew Pinski
2023-09-05 21:52 ` Jakub Jelinek
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2023-09-05 21:42 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Richard Biener, gcc-patches
On Tue, Sep 5, 2023 at 12:31 AM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi!
>
> Recent match.pd changes trigger ICE in build_minus_one_cst, apparently
> I forgot to handle BITINT_TYPE in these (while I've handled it in
> build_zero_cst).
>
> Will commit as obvious together with the rest of the series when the last
> patches are approved.
I assume there was a testcase that will be added when _BitInt
front-end support gets added.
Thanks,
Andrew
>
> 2023-09-05 Jakub Jelinek <jakub@redhat.com>
>
> PR c/102989
> * tree.cc (build_one_cst, build_minus_one_cst): Handle BITINT_TYPE
> like INTEGER_TYPE.
>
> --- gcc/tree.cc.jj 2023-09-04 09:45:33.444059843 +0200
> +++ gcc/tree.cc 2023-09-05 08:57:31.420059962 +0200
> @@ -2546,7 +2546,7 @@ build_one_cst (tree type)
> {
> case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
> case POINTER_TYPE: case REFERENCE_TYPE:
> - case OFFSET_TYPE:
> + case OFFSET_TYPE: case BITINT_TYPE:
> return build_int_cst (type, 1);
>
> case REAL_TYPE:
> @@ -2599,7 +2599,7 @@ build_minus_one_cst (tree type)
> {
> case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE:
> case POINTER_TYPE: case REFERENCE_TYPE:
> - case OFFSET_TYPE:
> + case OFFSET_TYPE: case BITINT_TYPE:
> return build_int_cst (type, -1);
>
> case REAL_TYPE:
>
> Jakub
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989]
2023-09-05 21:42 ` [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989] Andrew Pinski
@ 2023-09-05 21:52 ` Jakub Jelinek
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Jelinek @ 2023-09-05 21:52 UTC (permalink / raw)
To: Andrew Pinski; +Cc: Richard Biener, gcc-patches
On Tue, Sep 05, 2023 at 02:42:39PM -0700, Andrew Pinski wrote:
> On Tue, Sep 5, 2023 at 12:31 AM Jakub Jelinek via Gcc-patches
> > Recent match.pd changes trigger ICE in build_minus_one_cst, apparently
> > I forgot to handle BITINT_TYPE in these (while I've handled it in
> > build_zero_cst).
> >
> > Will commit as obvious together with the rest of the series when the last
> > patches are approved.
>
> I assume there was a testcase that will be added when _BitInt
> front-end support gets added.
After working around the build_nonstandard_integer_type in match.pd (in that
case the single one, I know there are some others) the ICE was on
dg-torture/bitint-42.c at -O1/-Os, so no new testcase needs to be added.
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-05 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-05 7:30 [PATCH 18/12] Handle BITINT_TYPE in build_{,minus_}one_cst [PR102989] Jakub Jelinek
2023-09-05 21:42 ` [PATCH 18/12] Handle BITINT_TYPE in build_{, minus_}one_cst [PR102989] Andrew Pinski
2023-09-05 21:52 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).