public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH/AARCH64] Have the verbose cost model output output be controllable
Date: Sat, 24 Sep 2016 08:52:00 -0000	[thread overview]
Message-ID: <CA+=Sn1mOJZya_f7YBNujizEowo8ijbBqchVj7DzfsnZEugd2RQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Hi,
  As reported in PR 61367, the aarch64 back-end is too verbose when it
is dealing with the cost model.  I tend to agree, no other back-end is
this verbose.  So I decided to add an option to enable this verbose
output if requested.

I did NOT document it in invoke.texi because I don't feel like this is
an option which an user should use.  But I can add it if requested.

OK?  Bootstrapped and tested on aarch64-linux-gnu with no regressions.

Thanks,
Andrew Pinski

ChangeLog:
* config/aarch64/aarch64.opt (mverbose-cost-dump): New option.
* config/aarch64/aarch64.c (aarch64_rtx_costs): Use
flag_aarch64_verbose_cost instead of checking for details dump.
(aarch64_rtx_costs_wrapper): Likewise.

[-- Attachment #2: disableverbosecostdump.diff.txt --]
[-- Type: text/plain, Size: 1230 bytes --]

Index: config/aarch64/aarch64.c
===================================================================
--- config/aarch64/aarch64.c	(revision 240461)
+++ config/aarch64/aarch64.c	(working copy)
@@ -7351,7 +7351,8 @@
       break;
     }
 
-  if (dump_file && (dump_flags & TDF_DETAILS))
+  if (dump_file
+      && flag_aarch64_verbose_cost)
     fprintf (dump_file,
       "\nFailed to cost RTX.  Assuming default cost.\n");
 
@@ -7367,7 +7368,8 @@
 {
   bool result = aarch64_rtx_costs (x, mode, outer, param, cost, speed);
 
-  if (dump_file && (dump_flags & TDF_DETAILS))
+  if (dump_file
+      && flag_aarch64_verbose_cost)
     {
       print_rtl_single (dump_file, x);
       fprintf (dump_file, "\n%s cost: %d (%s)\n",
Index: config/aarch64/aarch64.opt
===================================================================
--- config/aarch64/aarch64.opt	(revision 240461)
+++ config/aarch64/aarch64.opt	(working copy)
@@ -167,3 +167,7 @@
 Enable the division approximation.  Enabling this reduces
 precision of division results to about 16 bits for
 single precision and to 32 bits for double precision.
+
+mverbose-cost-dump
+Common Var(flag_aarch64_verbose_cost)
+Enables verbose cost model dummping in the debug dump files.

             reply	other threads:[~2016-09-24  5:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24  8:52 Andrew Pinski [this message]
2016-10-06 22:12 ` Andrew Pinski
2016-10-07  8:01 ` Kyrill Tkachov
2016-11-15 16:48   ` Andrew Pinski
2016-11-15 17:01     ` James Greenhalgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1mOJZya_f7YBNujizEowo8ijbBqchVj7DzfsnZEugd2RQ@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).