From: Andrew Pinski <pinskia@gmail.com>
To: Michael Collison <michael.collison@linaro.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations
Date: Thu, 25 Sep 2014 04:01:00 -0000 [thread overview]
Message-ID: <CA+=Sn1mRZV6pn9urzkwJ_FP=7yVvfBLUEVwsievQE6DZAs+F7Q@mail.gmail.com> (raw)
In-Reply-To: <54238FEF.6030006@linaro.org>
On Wed, Sep 24, 2014 at 8:45 PM, Michael Collison
<michael.collison@linaro.org> wrote:
> On certain patterns in atomics.md the constraint 'n' is used in combination
> with the predicate atomic_op_operand. The constraint is too general and
> allows constants that are disallowed by the predicate. This causes an ICE In
> final_scan_insn when the insn cannot be split because the constraint and
> predicate do not match.
>
> Tested on aarch64-none-elf, aarch64-linux-gnu. Additionally the originally
> reporter of the bug, (doko@ubuntu.com), applied the patch and successfully
> bootstrapped and tested with no regressions.
Testcase?
>
> 2014-09-23 Michael Collison <michael.collison@linaro.org>
>
> * config/aarch64/iterators.md (lconst_atomic): New mode attribute to
> support constraints for CONST_INT in atomic operations.
> * config/aarch64/atomics.md
> (atomic_<atomic_optab><mode>): Use lconst_atomic constraint.
> (atomic_nand<mode>): Likewise.
> (atomic_fetch_<atomic_optab><mode>): Likewise.
> (atomic_fetch_nand<mode>): Likewise.
> (atomic_<atomic_optab>_fetch<mode>): Likewise.
> (atomic_nand_fetch<mode>): Likewise.
>
> --
> Michael Collison
> Linaro Toolchain Working Group
> michael.collison@linaro.org
>
next prev parent reply other threads:[~2014-09-25 4:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 3:45 Michael Collison
2014-09-25 4:01 ` Andrew Pinski [this message]
2014-09-25 4:08 ` Michael Collison
2014-09-25 4:10 ` Andrew Pinski
2014-09-25 4:13 ` Michael Collison
2014-09-25 4:17 ` Andrew Pinski
2014-09-25 10:12 ` Segher Boessenkool
2014-09-25 17:33 ` Michael Collison
2014-09-25 19:30 ` Segher Boessenkool
2014-10-09 12:28 ` Christophe Lyon
2014-11-04 10:44 ` Marcus Shawcroft
2015-05-08 10:42 ` Richard Biener
2015-06-15 12:20 ` Christophe Lyon
2015-06-16 8:36 ` Christophe Lyon
2015-06-16 10:31 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1mRZV6pn9urzkwJ_FP=7yVvfBLUEVwsievQE6DZAs+F7Q@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=michael.collison@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).